mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
192d56e2ca
trim-audio stream-copies, and a window below one frame ships a container with zero audio frames as a 200 success. Floor the window at 0.1s in the schema, and refuse after endS clamps to the real duration if the window drops under the floor. Fixes #671.
84 lines
3.0 KiB
TypeScript
84 lines
3.0 KiB
TypeScript
import { mkdtempSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { ffmpegAvailable, probeMedia } from "@snapotter/media-engine";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
const MP3 = readFixture(fixtures.audio.tiny("mp3"));
|
|
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
async function runTool(settings: Record<string, unknown>) {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "tiny.mp3", contentType: "audio/mpeg", content: MP3 },
|
|
{ name: "settings", content: JSON.stringify(settings) },
|
|
]);
|
|
return testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/audio/trim-audio",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
}
|
|
|
|
describe.skipIf(!ffmpegAvailable())("trim-audio (requires ffmpeg)", () => {
|
|
it("trims mp3 from 0 to 0.5s and returns 200", async () => {
|
|
const res = await runTool({ startS: 0, endS: 0.5 });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
const dl = await testApp.app.inject({
|
|
method: "GET",
|
|
url: envelope.downloadUrl,
|
|
});
|
|
expect(dl.statusCode).toBe(200);
|
|
expect(dl.rawPayload.length).toBeGreaterThan(50);
|
|
|
|
// Verify trimmed duration via probeMedia (mirror trim-video's pattern)
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "trim-audio-test-"));
|
|
const probeFile = join(tmpDir, "trimmed.mp3");
|
|
writeFileSync(probeFile, dl.rawPayload);
|
|
const info = await probeMedia(probeFile);
|
|
expect(info.durationS).not.toBeNull();
|
|
// Stream-copy on mp3 may overshoot slightly due to frame boundaries,
|
|
// but should be well under the original 1s duration.
|
|
expect(info.durationS as number).toBeLessThanOrEqual(2);
|
|
expect(info.durationS as number).toBeGreaterThan(0);
|
|
}, 60_000);
|
|
|
|
it("rejects when end is before start", async () => {
|
|
const res = await runTool({ startS: 0.5, endS: 0.2 });
|
|
expect(res.statusCode).toBe(400);
|
|
});
|
|
|
|
it("rejects a sub-frame trim window instead of returning an empty file", async () => {
|
|
const res = await runTool({ startS: 0, endS: 0.000001 });
|
|
expect(res.statusCode).toBe(400);
|
|
});
|
|
|
|
it("rejects when clamping endS to the duration leaves a sub-frame window", async () => {
|
|
// tiny.mp3 is ~1.0-1.045s depending on the ffprobe build; endS clamps to
|
|
// the duration, leaving well under 0.1s either way.
|
|
const res = await runTool({ startS: 0.98, endS: 9 });
|
|
expect(res.statusCode).toBe(422);
|
|
expect(JSON.parse(res.body).details).toMatch(/Trim window/);
|
|
});
|
|
});
|