mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
ae6a4c8b7c
Removes Sentry tracing entirely (BullMQ idle polling burned 4.8M transactions in 2 days at the baked 0.1 rate), decouples PostHog sampling, and replaces the type-only error scrub with a vetted-field sanitizer plus SafeError/ToolInputError contracts. One classified capture path with per-signature throttles and a per-process ceiling makes storms impossible (NODE-1E was 4,541 events from one 30s loop). Browser errors move to a dedicated web Sentry project with their own source maps. Adds the SNAPOTTER_TELEMETRY runtime kill switch and silences test fleets. Crash fixes: remote 204/304 SSRF process kill (NODE-20), conversion-preset boot crash loop (NODE-21), Redis version preflight + unhandled subscribe rejection (NODE-1T), Sign PDF on plain-http origins (NODE-1K/1M), wavesurfer/pdf.js teardown rejections (NODE-1P/1N), bundle-import ZlibError to 400 (NODE-1Z), chart-maker input errors declassified (NODE-1H/1J), asset requests skip the session DB lookup (NODE-1D).
60 lines
2.3 KiB
TypeScript
60 lines
2.3 KiB
TypeScript
/**
|
|
* Regression guard for the single deliberate Sentry capture path.
|
|
*
|
|
* Before the overhaul a failed tool job was captured twice (processToolJob
|
|
* catch + worker.on("failed")) and wrapped in new Error(String(err)), which
|
|
* produced frameless events. These tests pin the contract: one reportError
|
|
* call yields exactly one captureException with the ORIGINAL error object,
|
|
* and the throttle allows one capture per distinct signature.
|
|
*/
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { reportError, resetThrottleForTests } from "../../../apps/api/src/lib/error-report.js";
|
|
|
|
const h = vi.hoisted(() => {
|
|
const scope = { setTag: vi.fn(), setLevel: vi.fn(), setFingerprint: vi.fn() };
|
|
return {
|
|
scope,
|
|
captureException: vi.fn(),
|
|
withScope: vi.fn((cb: (s: typeof scope) => unknown) => cb(scope)),
|
|
};
|
|
});
|
|
|
|
vi.mock("@sentry/node", () => ({
|
|
captureException: h.captureException,
|
|
withScope: h.withScope,
|
|
}));
|
|
|
|
vi.mock("../../../apps/api/src/lib/analytics-gate.js", () => ({
|
|
analyticsEnabled: () => true,
|
|
}));
|
|
|
|
beforeEach(() => {
|
|
resetThrottleForTests();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
describe("capture path", () => {
|
|
it("a single worker-failure reportError yields exactly one capture, unwrapped, tagged", async () => {
|
|
const boom = new Error("boom");
|
|
await reportError(boom, { source: "worker", pool: "image" });
|
|
|
|
expect(h.captureException).toHaveBeenCalledTimes(1);
|
|
// The original object flows through: no new Error(String(err)) wrapping,
|
|
// so stacks, codes, and marker properties survive.
|
|
expect(h.captureException).toHaveBeenCalledWith(boom);
|
|
expect(h.scope.setTag).toHaveBeenCalledWith("source", "worker");
|
|
expect(h.scope.setTag).toHaveBeenCalledWith("pool", "image");
|
|
});
|
|
|
|
it("captures once per distinct signature; operational repeats are throttled", async () => {
|
|
const full = Object.assign(new Error("disk full"), { code: "ENOSPC" });
|
|
await reportError(full, { source: "worker", pool: "image" });
|
|
await reportError(full, { source: "worker", pool: "image" });
|
|
expect(h.captureException).toHaveBeenCalledTimes(1);
|
|
|
|
const denied = Object.assign(new Error("denied"), { code: "EACCES" });
|
|
await reportError(denied, { source: "worker", pool: "image" });
|
|
expect(h.captureException).toHaveBeenCalledTimes(2);
|
|
});
|
|
});
|