mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
ae6a4c8b7c
Removes Sentry tracing entirely (BullMQ idle polling burned 4.8M transactions in 2 days at the baked 0.1 rate), decouples PostHog sampling, and replaces the type-only error scrub with a vetted-field sanitizer plus SafeError/ToolInputError contracts. One classified capture path with per-signature throttles and a per-process ceiling makes storms impossible (NODE-1E was 4,541 events from one 30s loop). Browser errors move to a dedicated web Sentry project with their own source maps. Adds the SNAPOTTER_TELEMETRY runtime kill switch and silences test fleets. Crash fixes: remote 204/304 SSRF process kill (NODE-20), conversion-preset boot crash loop (NODE-21), Redis version preflight + unhandled subscribe rejection (NODE-1T), Sign PDF on plain-http origins (NODE-1K/1M), wavesurfer/pdf.js teardown rejections (NODE-1P/1N), bundle-import ZlibError to 400 (NODE-1Z), chart-maker input errors declassified (NODE-1H/1J), asset requests skip the session DB lookup (NODE-1D).
102 lines
3.6 KiB
TypeScript
102 lines
3.6 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
import {
|
|
__resetGateForTests,
|
|
__setReaderForTests,
|
|
analyticsEnabled,
|
|
bakedEnabled,
|
|
refreshAnalyticsGate,
|
|
telemetryEnvKilled,
|
|
} from "../../../apps/api/src/lib/analytics-gate.js";
|
|
|
|
const origEnv = process.env.NODE_ENV;
|
|
const origOverride = process.env.ANALYTICS_BAKED_OVERRIDE;
|
|
const origTelemetry = process.env.SNAPOTTER_TELEMETRY;
|
|
|
|
beforeEach(() => {
|
|
__resetGateForTests();
|
|
process.env.NODE_ENV = "test";
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "on"; // force bake on for these unit tests
|
|
delete process.env.SNAPOTTER_TELEMETRY; // ambient kill switch would poison the suite
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.env.NODE_ENV = origEnv;
|
|
if (origOverride === undefined) delete process.env.ANALYTICS_BAKED_OVERRIDE;
|
|
else process.env.ANALYTICS_BAKED_OVERRIDE = origOverride;
|
|
if (origTelemetry === undefined) delete process.env.SNAPOTTER_TELEMETRY;
|
|
else process.env.SNAPOTTER_TELEMETRY = origTelemetry;
|
|
__setReaderForTests(null);
|
|
});
|
|
|
|
describe("bakedEnabled override (non-production only)", () => {
|
|
it("honors ANALYTICS_BAKED_OVERRIDE=on outside production", () => {
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "on";
|
|
expect(bakedEnabled()).toBe(true);
|
|
});
|
|
it("honors ANALYTICS_BAKED_OVERRIDE=off outside production", () => {
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "off";
|
|
expect(bakedEnabled()).toBe(false);
|
|
});
|
|
it("ignores the override in production (falls back to committed bake=false)", () => {
|
|
process.env.NODE_ENV = "production";
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "on";
|
|
expect(bakedEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("effective enabled = baked AND toggle", () => {
|
|
it("absent toggle defaults to ON", async () => {
|
|
__setReaderForTests(async () => undefined);
|
|
await refreshAnalyticsGate();
|
|
expect(analyticsEnabled()).toBe(true);
|
|
});
|
|
it("toggle=false disables even when baked is on", async () => {
|
|
__setReaderForTests(async () => false);
|
|
await refreshAnalyticsGate();
|
|
expect(analyticsEnabled()).toBe(false);
|
|
});
|
|
it("baked off forces disabled regardless of toggle", async () => {
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "off";
|
|
__setReaderForTests(async () => true);
|
|
await refreshAnalyticsGate();
|
|
expect(analyticsEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("SNAPOTTER_TELEMETRY runtime kill switch", () => {
|
|
it("outranks ANALYTICS_BAKED_OVERRIDE=on outside production", () => {
|
|
process.env.ANALYTICS_BAKED_OVERRIDE = "on";
|
|
process.env.SNAPOTTER_TELEMETRY = "0";
|
|
expect(bakedEnabled()).toBe(false);
|
|
});
|
|
it("telemetryEnvKilled matches 0, false, off and nothing else", () => {
|
|
for (const v of ["0", "false", "off"]) {
|
|
process.env.SNAPOTTER_TELEMETRY = v;
|
|
expect(telemetryEnvKilled()).toBe(true);
|
|
}
|
|
delete process.env.SNAPOTTER_TELEMETRY;
|
|
expect(telemetryEnvKilled()).toBe(false);
|
|
process.env.SNAPOTTER_TELEMETRY = "1";
|
|
expect(telemetryEnvKilled()).toBe(false);
|
|
});
|
|
it("is honored in production builds", () => {
|
|
process.env.NODE_ENV = "production";
|
|
process.env.SNAPOTTER_TELEMETRY = "0";
|
|
expect(bakedEnabled()).toBe(false);
|
|
expect(telemetryEnvKilled()).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("fail closed", () => {
|
|
it("stays disabled across a transient read error once disabled was seen", async () => {
|
|
__setReaderForTests(async () => false);
|
|
await refreshAnalyticsGate();
|
|
expect(analyticsEnabled()).toBe(false);
|
|
__setReaderForTests(async () => {
|
|
throw new Error("db down");
|
|
});
|
|
await refreshAnalyticsGate();
|
|
expect(analyticsEnabled()).toBe(false);
|
|
});
|
|
});
|