mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
qpdf expands argument files before parsing options, so a bare positional password beginning with @ was resolved as a path and the file's contents became the encryption key: exit 0, and the user's own password no longer opened the PDF. Drive the encrypt through a job-JSON file so neither password reaches argv. The =-joined flag form needs qpdf 11.7+, and the released image carries 11.3.0 which rejects it; job JSON works on both (verified 11.3.0 and 12.1.0, R = 6 each).
133 lines
4.7 KiB
TypeScript
133 lines
4.7 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { qpdfAvailable } from "@snapotter/doc-engine";
|
|
import { eq } from "drizzle-orm";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { db, schema } from "../../../../apps/api/src/db/index.js";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
const PDF = readFixture(fixtures.document.pdf3);
|
|
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
async function runTool(settings: Record<string, unknown>) {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test-3page.pdf", contentType: "application/pdf", content: PDF },
|
|
{ name: "settings", content: JSON.stringify(settings) },
|
|
]);
|
|
return testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/pdf/protect-pdf",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
}
|
|
|
|
describe.skipIf(!qpdfAvailable())("protect-pdf (requires qpdf)", () => {
|
|
it("encrypts a PDF and returns a downloadable file", async () => {
|
|
const res = await runTool({ userPassword: "mypass" });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
|
|
const dl = await testApp.app.inject({
|
|
method: "GET",
|
|
url: envelope.downloadUrl,
|
|
});
|
|
expect(dl.statusCode).toBe(200);
|
|
// The output should start with %PDF-
|
|
expect(dl.rawPayload.subarray(0, 5).toString()).toBe("%PDF-");
|
|
}, 60_000);
|
|
|
|
it("persists redacted passwords in the jobs row (never the real password)", async () => {
|
|
const realPassword = "superSecret42";
|
|
const res = await runTool({ userPassword: realPassword, ownerPassword: "ownerPw99" });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
|
|
// Read the jobs row
|
|
const [row] = await db
|
|
.select({ settings: schema.jobs.settings })
|
|
.from(schema.jobs)
|
|
.where(eq(schema.jobs.id, envelope.jobId));
|
|
|
|
expect(row).toBeDefined();
|
|
const settings = row.settings as Record<string, unknown>;
|
|
expect(settings.userPassword).toBe("<redacted>");
|
|
expect(settings.ownerPassword).toBe("<redacted>");
|
|
|
|
// The raw password string must not appear anywhere in the row
|
|
const serialized = JSON.stringify(row.settings);
|
|
expect(serialized).not.toContain(realPassword);
|
|
expect(serialized).not.toContain("ownerPw99");
|
|
}, 60_000);
|
|
|
|
it("rejects empty userPassword with 400", async () => {
|
|
const res = await runTool({ userPassword: "" });
|
|
expect(res.statusCode).toBe(400);
|
|
}, 60_000);
|
|
|
|
// Round-trips a password whose first character is qpdf's argument-file sigil.
|
|
// Passed as a bare positional, qpdf resolves it as a path and encrypts under
|
|
// that file's contents instead, so the user's own password no longer opens the
|
|
// document. Unlocking with the literal string is what proves it stayed literal.
|
|
it("treats a password starting with the argument-file sigil as a literal", async () => {
|
|
const canaryPath = join(tmpdir(), `snapotter-qpdf-canary-${randomUUID()}.txt`);
|
|
await writeFile(canaryPath, "CANARY_FILE_CONTENTS\n");
|
|
|
|
try {
|
|
const literalPassword = `@${canaryPath}`;
|
|
const res = await runTool({ userPassword: literalPassword });
|
|
expect(res.statusCode).toBe(200);
|
|
|
|
const dl = await testApp.app.inject({
|
|
method: "GET",
|
|
url: JSON.parse(res.body).downloadUrl,
|
|
});
|
|
expect(dl.statusCode).toBe(200);
|
|
|
|
const unlockWith = async (password: string) => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{
|
|
name: "file",
|
|
filename: "locked.pdf",
|
|
contentType: "application/pdf",
|
|
content: dl.rawPayload,
|
|
},
|
|
{ name: "settings", content: JSON.stringify({ password }) },
|
|
]);
|
|
return testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/pdf/unlock-pdf",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
};
|
|
|
|
expect((await unlockWith(literalPassword)).statusCode).toBe(200);
|
|
// The canary's contents must never have become the encryption key.
|
|
expect((await unlockWith("CANARY_FILE_CONTENTS")).statusCode).not.toBe(200);
|
|
} finally {
|
|
await rm(canaryPath, { force: true });
|
|
}
|
|
}, 90_000);
|
|
});
|