mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
166 lines
5.6 KiB
TypeScript
166 lines
5.6 KiB
TypeScript
import { constants } from "node:fs";
|
|
import { access, mkdtemp, readFile, rm } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { delimiter, join, sep } from "node:path";
|
|
import { isToolInputError, type Modality } from "@snapotter/shared";
|
|
import { InputValidationError } from "../../apps/api/src/modality/contract.js";
|
|
import { inputHandlerFor } from "../../apps/api/src/modality/input-handler.js";
|
|
import { MediaInputHandler } from "../../apps/api/src/modality/media-input.js";
|
|
import type {
|
|
AnyToolRouteConfig,
|
|
ToolProcessInputV2,
|
|
} from "../../apps/api/src/routes/tool-factory.js";
|
|
import type { GeneratedFixture } from "./generated-fixtures.js";
|
|
|
|
type InputKind = NonNullable<AnyToolRouteConfig["inputKinds"]>[number];
|
|
|
|
const EXTENSIONS_BY_KIND: Record<InputKind, ReadonlySet<string>> = {
|
|
image: new Set([
|
|
".jpg",
|
|
".jpeg",
|
|
".png",
|
|
".webp",
|
|
".gif",
|
|
".bmp",
|
|
".tiff",
|
|
".tif",
|
|
".avif",
|
|
".heic",
|
|
".heif",
|
|
".svg",
|
|
]),
|
|
video: new Set([".mp4", ".mov", ".webm", ".mkv", ".avi", ".m4v", ".mpg", ".mpeg"]),
|
|
audio: new Set([".mp3", ".wav", ".flac", ".aac", ".m4a", ".ogg", ".opus"]),
|
|
subtitle: new Set([".srt", ".vtt", ".ass", ".ssa"]),
|
|
};
|
|
|
|
interface GeneratedInputConfig {
|
|
minInputs?: number;
|
|
inputKinds?: readonly InputKind[];
|
|
}
|
|
|
|
interface GeneratedPrerequisiteEnvironment {
|
|
cairePath?: string;
|
|
path?: string;
|
|
}
|
|
|
|
/** Only user/input validation failures are safe rejections in generated campaigns. */
|
|
export function isExpectedGeneratedRejection(error: unknown): boolean {
|
|
return error instanceof InputValidationError || isToolInputError(error);
|
|
}
|
|
|
|
/** Return a named source-lane prerequisite failure; artifact lanes must provide it. */
|
|
export async function findMissingGeneratedPrerequisite(
|
|
toolId: string,
|
|
environment: GeneratedPrerequisiteEnvironment = {
|
|
cairePath: process.env.CAIRE_PATH,
|
|
path: process.env.PATH,
|
|
},
|
|
): Promise<string | undefined> {
|
|
if (toolId !== "content-aware-resize") return undefined;
|
|
|
|
const command = environment.cairePath ?? "caire";
|
|
const candidates = command.includes(sep)
|
|
? [command]
|
|
: (environment.path ?? "")
|
|
.split(delimiter)
|
|
.filter(Boolean)
|
|
.map((directory) => join(directory, command));
|
|
for (const candidate of candidates) {
|
|
try {
|
|
await access(candidate, constants.X_OK);
|
|
return undefined;
|
|
} catch {
|
|
// Check the next PATH entry.
|
|
}
|
|
}
|
|
return "caire binary is unavailable in this source environment";
|
|
}
|
|
|
|
/**
|
|
* Build deterministic processV2 inputs from compatible fixture candidates.
|
|
* Mixed-input routes select by position; same-kind multi-input routes use a
|
|
* second distinct fixture when available and otherwise reuse the first.
|
|
*/
|
|
export async function buildGeneratedProcessInputs(
|
|
fixtures: readonly GeneratedFixture[],
|
|
config: GeneratedInputConfig,
|
|
modality?: Modality,
|
|
): Promise<ToolProcessInputV2[]> {
|
|
const requiredInputs = Math.max(config.minInputs ?? 1, config.inputKinds?.length ?? 1);
|
|
const selected: GeneratedFixture[] = [];
|
|
|
|
for (let index = 0; index < requiredInputs; index++) {
|
|
const kind = config.inputKinds?.[Math.min(index, config.inputKinds.length - 1)];
|
|
const compatible = kind
|
|
? fixtures.filter((fixture) => EXTENSIONS_BY_KIND[kind].has(fixture.ext))
|
|
: [...fixtures];
|
|
if (compatible.length === 0) {
|
|
throw new Error(
|
|
`No generated fixture is compatible with input ${index + 1}${kind ? ` (${kind})` : ""}`,
|
|
);
|
|
}
|
|
selected.push(compatible[index % compatible.length]);
|
|
}
|
|
|
|
const preparationDir = modality
|
|
? await mkdtemp(join(tmpdir(), "snapotter-generated-prepare-"))
|
|
: undefined;
|
|
try {
|
|
const inputs: ToolProcessInputV2[] = [];
|
|
for (let index = 0; index < selected.length; index++) {
|
|
const fixture = selected[index];
|
|
let buffer = await readFile(join(fixture.dir, fixture.filename));
|
|
let filename = fixture.filename;
|
|
if (modality && preparationDir) {
|
|
const kind = config.inputKinds?.[Math.min(index, config.inputKinds.length - 1)];
|
|
const handler = kind
|
|
? kind === "image"
|
|
? inputHandlerFor("image")
|
|
: new MediaInputHandler(kind)
|
|
: inputHandlerFor(modality);
|
|
const prepared = await handler.prepare(buffer, filename, { scratchDir: preparationDir });
|
|
buffer = prepared.buffer;
|
|
filename = prepared.filename;
|
|
}
|
|
inputs.push({
|
|
buffer,
|
|
filename,
|
|
ref: `generated/${index}-${filename}`,
|
|
});
|
|
}
|
|
return inputs;
|
|
} finally {
|
|
if (preparationDir) await rm(preparationDir, { recursive: true, force: true });
|
|
}
|
|
}
|
|
|
|
/** Execute a generated case through the same resolved processV2 contract as the worker. */
|
|
export async function runGeneratedTool(
|
|
config: AnyToolRouteConfig,
|
|
inputs: ToolProcessInputV2[],
|
|
settings: unknown,
|
|
signal: AbortSignal = new AbortController().signal,
|
|
): Promise<Buffer> {
|
|
if (!config.processV2) throw new Error(`No processV2 for ${config.toolId}`);
|
|
if (inputs.length === 0) throw new Error(`No generated inputs for ${config.toolId}`);
|
|
|
|
const scratchDir = await mkdtemp(join(tmpdir(), "snapotter-generated-"));
|
|
try {
|
|
const result = await config.processV2({
|
|
inputs,
|
|
settings,
|
|
scratchDir,
|
|
signal,
|
|
report: () => {},
|
|
});
|
|
if (result.buffer) return result.buffer;
|
|
// Await inside the try block so cleanup cannot remove the scratch tree
|
|
// before the asynchronous read has opened and consumed the output.
|
|
if (result.scratchPath) return await readFile(result.scratchPath);
|
|
throw new Error(`Tool ${config.toolId} returned neither buffer nor scratchPath`);
|
|
} finally {
|
|
await rm(scratchDir, { recursive: true, force: true });
|
|
}
|
|
}
|