mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
158 lines
4.4 KiB
TypeScript
158 lines
4.4 KiB
TypeScript
import type { Tool } from "@snapotter/shared";
|
|
|
|
const DEFAULT_FUZZ_RUNS = 25;
|
|
const DEFAULT_FUZZ_SEED = 20_260_724;
|
|
const MAX_FUZZ_RUNS = 10_000;
|
|
const MAX_FUZZ_SEED = 2_147_483_647;
|
|
const TARGET_STARTUP_BUFFER_MS = 60_000;
|
|
const MAX_DIAGNOSTIC_SETTINGS_LENGTH = 2_048;
|
|
|
|
export type FuzzCostClass = "standard" | "long" | "slow-codec";
|
|
|
|
export interface FuzzConfig {
|
|
runs: number;
|
|
seed: number;
|
|
seedSource: "default" | "FUZZ_SEED" | "FC_SEED";
|
|
}
|
|
|
|
export interface FuzzBudget {
|
|
costClass: FuzzCostClass;
|
|
caseTimeoutMs: number;
|
|
targetTimeoutMs: number;
|
|
}
|
|
|
|
interface FuzzTool {
|
|
id: string;
|
|
executionHint: Tool["executionHint"];
|
|
}
|
|
|
|
interface FuzzCaseMetadata {
|
|
toolId: string;
|
|
seed: number;
|
|
run: number;
|
|
settings: unknown;
|
|
timeoutMs: number;
|
|
}
|
|
|
|
const CASE_TIMEOUTS_MS: Record<FuzzCostClass, number> = {
|
|
standard: 8_000,
|
|
long: 12_000,
|
|
"slow-codec": 15_000,
|
|
};
|
|
|
|
export const FUZZ_COST_OVERRIDES = {
|
|
"webp-to-avif": "slow-codec",
|
|
"webp-to-gif": "slow-codec",
|
|
} as const satisfies Record<string, FuzzCostClass>;
|
|
|
|
function parseInteger(
|
|
name: string,
|
|
value: string,
|
|
{ min, max }: { min: number; max: number },
|
|
): number {
|
|
if (!/^-?\d+$/.test(value)) {
|
|
throw new Error(`${name} must be an integer`);
|
|
}
|
|
const parsed = Number(value);
|
|
if (!Number.isSafeInteger(parsed)) {
|
|
throw new Error(`${name} must be an integer`);
|
|
}
|
|
if (parsed < min || parsed > max) {
|
|
throw new Error(`${name} must be between ${min} and ${max}`);
|
|
}
|
|
return parsed;
|
|
}
|
|
|
|
export function parseFuzzConfig(
|
|
environment: Readonly<Record<string, string | undefined>>,
|
|
): FuzzConfig {
|
|
const runs =
|
|
environment.FUZZ_RUNS === undefined
|
|
? DEFAULT_FUZZ_RUNS
|
|
: parseInteger("FUZZ_RUNS", environment.FUZZ_RUNS, { min: 1, max: MAX_FUZZ_RUNS });
|
|
|
|
const canonicalSeed = environment.FUZZ_SEED;
|
|
const deprecatedSeed = environment.FC_SEED;
|
|
if (canonicalSeed !== undefined && deprecatedSeed !== undefined) {
|
|
const parsedCanonical = parseInteger("FUZZ_SEED", canonicalSeed, {
|
|
min: 0,
|
|
max: MAX_FUZZ_SEED,
|
|
});
|
|
const parsedDeprecated = parseInteger("FC_SEED", deprecatedSeed, {
|
|
min: 0,
|
|
max: MAX_FUZZ_SEED,
|
|
});
|
|
if (parsedCanonical !== parsedDeprecated) {
|
|
throw new Error("FUZZ_SEED and deprecated FC_SEED differ");
|
|
}
|
|
return { runs, seed: parsedCanonical, seedSource: "FUZZ_SEED" };
|
|
}
|
|
|
|
if (canonicalSeed !== undefined) {
|
|
return {
|
|
runs,
|
|
seed: parseInteger("FUZZ_SEED", canonicalSeed, { min: 0, max: MAX_FUZZ_SEED }),
|
|
seedSource: "FUZZ_SEED",
|
|
};
|
|
}
|
|
if (deprecatedSeed !== undefined) {
|
|
return {
|
|
runs,
|
|
seed: parseInteger("FC_SEED", deprecatedSeed, { min: 0, max: MAX_FUZZ_SEED }),
|
|
seedSource: "FC_SEED",
|
|
};
|
|
}
|
|
return { runs, seed: DEFAULT_FUZZ_SEED, seedSource: "default" };
|
|
}
|
|
|
|
export function fuzzBudgetFor(tool: FuzzTool, runs: number): FuzzBudget {
|
|
if (!Number.isInteger(runs) || runs < 1 || runs > MAX_FUZZ_RUNS) {
|
|
throw new Error(`fuzz runs must be an integer between 1 and ${MAX_FUZZ_RUNS}`);
|
|
}
|
|
const costClass =
|
|
FUZZ_COST_OVERRIDES[tool.id as keyof typeof FUZZ_COST_OVERRIDES] ??
|
|
(tool.executionHint === "long" ? "long" : "standard");
|
|
const caseTimeoutMs = CASE_TIMEOUTS_MS[costClass];
|
|
return {
|
|
costClass,
|
|
caseTimeoutMs,
|
|
targetTimeoutMs: TARGET_STARTUP_BUFFER_MS + (runs + 1) * caseTimeoutMs,
|
|
};
|
|
}
|
|
|
|
function formatSettings(settings: unknown): string {
|
|
let serialized: string;
|
|
try {
|
|
serialized = JSON.stringify(settings) ?? String(settings);
|
|
} catch {
|
|
serialized = "[unserializable settings]";
|
|
}
|
|
if (serialized.length <= MAX_DIAGNOSTIC_SETTINGS_LENGTH) return serialized;
|
|
return `${serialized.slice(0, MAX_DIAGNOSTIC_SETTINGS_LENGTH)}…`;
|
|
}
|
|
|
|
export async function runFuzzCaseWithWatchdog<T>(
|
|
metadata: FuzzCaseMetadata,
|
|
operation: (signal: AbortSignal) => Promise<T>,
|
|
): Promise<T> {
|
|
const controller = new AbortController();
|
|
let timer: ReturnType<typeof setTimeout> | undefined;
|
|
const timeout = new Promise<never>((_resolve, reject) => {
|
|
timer = setTimeout(() => {
|
|
controller.abort();
|
|
reject(
|
|
new Error(
|
|
`[fuzz-timeout] tool=${metadata.toolId} seed=${metadata.seed} run=${metadata.run} ` +
|
|
`timeoutMs=${metadata.timeoutMs} settings=${formatSettings(metadata.settings)}`,
|
|
),
|
|
);
|
|
}, metadata.timeoutMs);
|
|
});
|
|
|
|
try {
|
|
return await Promise.race([operation(controller.signal), timeout]);
|
|
} finally {
|
|
if (timer) clearTimeout(timer);
|
|
}
|
|
}
|