mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
182 lines
6.6 KiB
TypeScript
182 lines
6.6 KiB
TypeScript
import { createNewDocument, expect, test } from "./helpers";
|
|
|
|
test.describe("Editor Layers Panel", () => {
|
|
test.beforeEach(async ({ editorPage: page }) => {
|
|
await createNewDocument(page);
|
|
// Ensure layers tab is active
|
|
await page.locator("[data-testid='tab-layers']").click();
|
|
await page.waitForTimeout(300);
|
|
});
|
|
|
|
test("layers panel shows default Layer 1", async ({ editorPage: page }) => {
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
await expect(layersPanel).toBeVisible();
|
|
|
|
// Should have at least one layer with "Layer 1" text
|
|
const layerRows = layersPanel.locator("[data-layer-id]");
|
|
await expect(layerRows).toHaveCount(1);
|
|
await expect(layersPanel.getByText("Layer 1")).toBeVisible();
|
|
});
|
|
|
|
test("add layer button creates new layer", async ({ editorPage: page }) => {
|
|
const addBtn = page.locator("[data-testid='add-layer-btn']");
|
|
await expect(addBtn).toBeVisible();
|
|
|
|
await addBtn.click();
|
|
await page.waitForTimeout(300);
|
|
|
|
// Now there should be 2 layers
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
const layerRows = layersPanel.locator("[data-layer-id]");
|
|
await expect(layerRows).toHaveCount(2);
|
|
});
|
|
|
|
test("cannot delete last layer", async ({ editorPage: page }) => {
|
|
const deleteBtn = page.locator("[data-testid='delete-layer-btn']");
|
|
await expect(deleteBtn).toBeVisible();
|
|
|
|
// With only one layer, delete button should be disabled
|
|
await expect(deleteBtn).toBeDisabled();
|
|
});
|
|
|
|
test("delete button enabled with multiple layers", async ({ editorPage: page }) => {
|
|
// Add a second layer
|
|
await page.locator("[data-testid='add-layer-btn']").click();
|
|
await page.waitForTimeout(300);
|
|
|
|
const deleteBtn = page.locator("[data-testid='delete-layer-btn']");
|
|
await expect(deleteBtn).toBeEnabled();
|
|
});
|
|
|
|
test("eye icon toggles visibility", async ({ editorPage: page }) => {
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
|
|
|
// Initially visible (Eye icon, aria-label "Hide layer")
|
|
const hideBtn = layerRow.locator("button[aria-label='Hide layer']");
|
|
await expect(hideBtn).toBeVisible();
|
|
|
|
// Click to hide
|
|
await hideBtn.click();
|
|
await page.waitForTimeout(300);
|
|
|
|
// Now should show "Show layer" button
|
|
const showBtn = layerRow.locator("button[aria-label='Show layer']");
|
|
await expect(showBtn).toBeVisible();
|
|
|
|
// Click again to show
|
|
await showBtn.click();
|
|
await page.waitForTimeout(300);
|
|
|
|
await expect(layerRow.locator("button[aria-label='Hide layer']")).toBeVisible();
|
|
});
|
|
|
|
test("lock icon toggles lock state", async ({ editorPage: page }) => {
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
|
|
|
// Initially unlocked
|
|
const lockBtn = layerRow.locator("button[aria-label='Lock layer']");
|
|
await expect(lockBtn).toBeVisible();
|
|
|
|
await lockBtn.click();
|
|
await page.waitForTimeout(300);
|
|
|
|
// Now should show "Unlock layer"
|
|
const unlockBtn = layerRow.locator("button[aria-label='Unlock layer']");
|
|
await expect(unlockBtn).toBeVisible();
|
|
});
|
|
|
|
test("blend mode dropdown shows modes", async ({ editorPage: page }) => {
|
|
const blendSelect = page.locator("[data-testid='blend-mode-select']");
|
|
await expect(blendSelect).toBeVisible();
|
|
|
|
// Check that it has the expected blend mode options
|
|
const options = blendSelect.locator("option");
|
|
const texts = await options.allTextContents();
|
|
|
|
expect(texts).toContain("Normal");
|
|
expect(texts).toContain("Multiply");
|
|
expect(texts).toContain("Screen");
|
|
expect(texts).toContain("Overlay");
|
|
expect(texts).toContain("Darken");
|
|
expect(texts).toContain("Lighten");
|
|
});
|
|
|
|
test("opacity slider works", async ({ editorPage: page }) => {
|
|
const slider = page.locator("[data-testid='layer-opacity-slider']");
|
|
await expect(slider).toBeVisible();
|
|
|
|
// Default opacity should be 100
|
|
await expect(slider).toHaveValue("100");
|
|
|
|
// Change opacity
|
|
await slider.fill("50");
|
|
await page.waitForTimeout(300);
|
|
|
|
await expect(slider).toHaveValue("50");
|
|
});
|
|
|
|
test("double-click layer name enters rename mode", async ({ editorPage: page }) => {
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
|
|
// Double-click the layer name button
|
|
const nameBtn = layersPanel
|
|
.locator("[data-layer-id]")
|
|
.first()
|
|
.locator("button")
|
|
.filter({ hasText: "Layer 1" });
|
|
await nameBtn.dblclick();
|
|
await page.waitForTimeout(300);
|
|
|
|
// An input for renaming should appear
|
|
const renameInput = layersPanel.locator("input[type='text'][class*='bg-muted']");
|
|
await expect(renameInput).toBeVisible();
|
|
});
|
|
|
|
test("layer row highlights active layer", async ({ editorPage: page }) => {
|
|
const layersPanel = page.locator("[data-testid='layers-panel']");
|
|
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
|
|
|
await expect(layerRow).toHaveAttribute("aria-current", "true");
|
|
});
|
|
|
|
test("Enter selects an inactive layer from its name button", async ({ editorPage: page }) => {
|
|
await page.getByTestId("add-layer-btn").click();
|
|
const layerOne = page.getByTestId(/^layer-name-/).filter({ hasText: "Layer 1" });
|
|
await expect(layerOne).toHaveAttribute("aria-pressed", "false");
|
|
|
|
await layerOne.focus();
|
|
await page.keyboard.press("Enter");
|
|
|
|
await expect(layerOne).toHaveAttribute("aria-pressed", "true");
|
|
});
|
|
|
|
test("Space selects an inactive layer from its name button", async ({ editorPage: page }) => {
|
|
await page.getByTestId("add-layer-btn").click();
|
|
const layerOne = page.getByTestId(/^layer-name-/).filter({ hasText: "Layer 1" });
|
|
await expect(layerOne).toHaveAttribute("aria-pressed", "false");
|
|
|
|
await layerOne.focus();
|
|
await page.keyboard.press("Space");
|
|
|
|
await expect(layerOne).toHaveAttribute("aria-pressed", "true");
|
|
});
|
|
|
|
test("keyboard-accessible controls reorder the active layer", async ({ editorPage: page }) => {
|
|
await page.getByTestId("add-layer-btn").click();
|
|
const rows = page.locator("[data-layer-id]");
|
|
await expect(rows).toHaveText(["Layer 2", "Layer 1"]);
|
|
|
|
const moveDown = page.getByRole("button", { name: "Move down: Layer 2" });
|
|
await moveDown.focus();
|
|
await page.keyboard.press("Enter");
|
|
await expect(rows).toHaveText(["Layer 1", "Layer 2"]);
|
|
|
|
const moveUp = page.getByRole("button", { name: "Move up: Layer 2" });
|
|
await moveUp.focus();
|
|
await page.keyboard.press("Space");
|
|
await expect(rows).toHaveText(["Layer 2", "Layer 1"]);
|
|
});
|
|
});
|