mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtter
1727a7a73e
Group 245 flat integration tests and 25 loose unit tests into
discoverable subdirectories per spec section 6:
integration/tools/{image,video,audio,document,data}/ (156 files)
integration/platform/ (64 files)
integration/generated/ (14 files)
integration/security/ (10 files)
unit/security/ (8 files, new subdir)
unit/api/ (7 files moved in)
unit/web/ (3 files moved in)
unit/shared/ (6 files moved in)
unit/image-engine/ (1 file moved in)
All moves via git mv (history preserved). Relative imports repaired
for both depth levels (platform/generated/security = +1, tools/ = +2):
static from-imports, dynamic import() calls, vi.mock() paths,
import.meta.dirname joins, and __dirname joins.
Vitest discovery unchanged (no test.include in config, recursive glob
matches subdirs, shard-by-hash unaffected). test-server.ts and
tool-route-drift.test.ts stay at integration root. fixtures/ untouched.
Parity gate: 13189 passing test names before = 13189 after (0 dropped).
66 lines
2.5 KiB
TypeScript
66 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { friendlyError } from "../../../apps/api/src/lib/errors.js";
|
|
|
|
const GENERIC = "Processing failed. The file may be in an unsupported or corrupted format.";
|
|
|
|
describe("friendlyError", () => {
|
|
it("collapses raw ffmpeg stderr dumps to a safe sentence", () => {
|
|
const dump =
|
|
"ffmpeg exited 234: Input #0, gif ... Pixel format 'gbrap' is not widely supported. Conversion failed!";
|
|
expect(friendlyError(dump)).toBe(GENERIC);
|
|
});
|
|
|
|
it("collapses raw ffprobe stderr dumps", () => {
|
|
expect(friendlyError("ffprobe exited 1: moov atom not found")).toBe(GENERIC);
|
|
});
|
|
|
|
it("collapses python tracebacks", () => {
|
|
expect(friendlyError("Traceback (most recent call last):\n File x\nValueError: boom")).toBe(
|
|
GENERIC,
|
|
);
|
|
});
|
|
|
|
it("collapses very long (>280 char) messages", () => {
|
|
expect(friendlyError("x".repeat(400))).toBe(GENERIC);
|
|
});
|
|
|
|
it("collapses multi-line dumps (>3 lines)", () => {
|
|
expect(friendlyError("l1\nl2\nl3\nl4\nl5")).toBe(GENERIC);
|
|
});
|
|
|
|
it("preserves intentional, user-facing validation messages", () => {
|
|
for (const msg of [
|
|
"This video has no audio track to normalize",
|
|
"Reverse is limited to clips up to 5 minutes",
|
|
"Crop rectangle 9999x9999+0+0 exceeds video size 640x360",
|
|
"No subtitle track found in this video",
|
|
]) {
|
|
expect(friendlyError(msg)).toBe(msg);
|
|
}
|
|
});
|
|
|
|
it("does NOT collapse clean messages that merely contain tool-ish words (false-positive guard)", () => {
|
|
// The old regex matched "conversion failed" / "pixel format" and would have
|
|
// wrongly collapsed these legitimate messages.
|
|
expect(friendlyError("SVG conversion failed")).toBe("SVG conversion failed");
|
|
expect(friendlyError("PDF conversion failed")).toBe("PDF conversion failed");
|
|
expect(friendlyError("Unsupported pixel format in source")).toBe(
|
|
"Unsupported pixel format in source",
|
|
);
|
|
});
|
|
|
|
it("scrubs internal filesystem paths", () => {
|
|
expect(friendlyError("decode failed at /data/ai/models/whisper")).toBe(
|
|
"decode failed at [internal]",
|
|
);
|
|
expect(friendlyError("wrote /tmp/workspace/out.mp4")).toBe("wrote [internal]");
|
|
});
|
|
|
|
it("is idempotent (safe to apply at every error surface)", () => {
|
|
const dump = "ffmpeg exited 1: boom";
|
|
expect(friendlyError(friendlyError(dump))).toBe(friendlyError(dump));
|
|
const ok = "Region exceeds image bounds";
|
|
expect(friendlyError(friendlyError(ok))).toBe(ok);
|
|
});
|
|
});
|