mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
* feat(api): parse DATA_DIR from env for 1.x import auto-detection Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * test(migrator): build 1.17.2 fixtures by replaying legacy migrations Discovered the legacy migrations seed a Default team (0005) and builtin roles (0007), so the replayed fixture carries them. Seed uses a distinct custom team. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * fix(migrator): self-adjusting column copy, jobs.status map, drop sessions, advisory lock The importer now inserts only the intersection of source and live target columns, so the three analytics_* columns 2.x dropped no longer break the first users INSERT (and future dropped columns are handled generically). jobs.status is mapped onto the 2.x enum (error->failed). Sessions are no longer migrated. A pg_advisory_xact_lock serializes concurrent replicas. Includes login-after-migrate and library assertions. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * test(migrator): CI drift guard fails when a required column is unfillable from 1.17.2 Introspects every NOT-NULL-no-default column of each migrated table in the current schema and asserts the engine can fill it from a real 1.17.2 source. Turns a future breaking schema change into a PR-time failure instead of a production import break. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * feat(migrator): orchestrator with detection, boot states, marker, blob count sqlite-import.ts owns source resolution (explicit path, 'off' sentinel, DATA_DIR probe), the four boot states (import/leftover/locked/none), the persisted sqlite_import marker, and a read-only library-blob count. runBootImport wires them together and catches TargetNonEmptyError as a benign multi-replica skip. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * feat(api): route boot through the 1.x import orchestrator; hide marker from non-admins index.ts now calls runBootImport (which owns detection + the four boot states) instead of the inline SQLITE_MIGRATE_PATH block. The sqlite_import marker is added to SENSITIVE_KEYS (but not REDACTED_KEYS) so admins see the counts for the banner while non-admins don't see the key at all. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * feat(migrator): add analyzeSqlite + dry-run/verify CLI analyzeSqlite is a read-only pre-flight (no live Postgres): per-table row counts, library-blob presence, and out-of-enum job statuses. The migrate:sqlite CLI now lives in the orchestrator and supports --dry-run/--verify (prints the analysis and exits without writing) alongside the existing import and --force. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * docs: add 1.x to 2.0 upgrade guide; fix volume-name casing New apps/docs upgrade guide covering auto-detect, the SQLITE_MIGRATE_PATH override + off opt-out, the dry-run, what carries over, locked-state recovery, and non-destructive rollback. Leads with 'back up the WHOLE /data volume, not just snapotter.db' because 1.x WAL mode leaves data in snapotter.db-wal (surfaced by the real-image upgrade test). Standardizes README/DOCKERHUB compose volume names on the canonical SnapOtter-data casing so they match the repo compose and don't orphan an upgrader's volume. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * feat(web): admin 1.x migration banner + 21-locale strings A one-time admin banner reads the sqlite_import marker from /v1/settings and shows the import result (user + saved-file counts) on success, or a warning when a 1.x database was found but not imported. Dismissal persists to a sqlite_import.dismissedAt settings key. shouldShowMigrationBanner/parseMigrationMarker sit in feedback.ts with the other shouldShow helpers; strings added to en.ts and all 20 other locales. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w * style(landing): biome-format Hero.astro trustBadges array Pre-existing formatting drift on main (its Lint check was skipped on the merge that introduced it); this PR's full Lint run surfaced it. Formatting-only, applied via the repo's own biome formatter to unblock the required Lint check. Claude-Session: https://claude.ai/code/session_01721WHAUGxnVk22qEeTub7w
60 lines
2.5 KiB
TypeScript
60 lines
2.5 KiB
TypeScript
import { mkdtempSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import Database from "better-sqlite3";
|
|
import { sql } from "drizzle-orm";
|
|
import { beforeAll, describe, expect, it } from "vitest";
|
|
import { db } from "../../../apps/api/src/db/index.js";
|
|
import { runMigrations } from "../../../apps/api/src/db/migrate.js";
|
|
import {
|
|
columnsEngineCanFill,
|
|
MIGRATED_TABLES,
|
|
} from "../../../apps/api/src/db/migrate-from-sqlite.js";
|
|
import { buildLegacySqlite } from "../../helpers/legacy-sqlite-fixture.js";
|
|
|
|
describe("migrator schema drift guard", () => {
|
|
let sourceColumns: Record<string, string[]>;
|
|
|
|
beforeAll(async () => {
|
|
await runMigrations(); // bring the test DB to the current schema
|
|
const dir = mkdtempSync(join(tmpdir(), "drift-"));
|
|
const path = join(dir, "legacy.db");
|
|
buildLegacySqlite(path);
|
|
const s = new Database(path, { readonly: true });
|
|
sourceColumns = {};
|
|
for (const table of MIGRATED_TABLES) {
|
|
const info = s.prepare(`PRAGMA table_info(${table})`).all() as Array<{ name: string }>;
|
|
sourceColumns[table] = info.map((c) => c.name);
|
|
}
|
|
s.close();
|
|
});
|
|
|
|
it("every required target column is fillable from a real 1.17.2 source", async () => {
|
|
const unfillable: string[] = [];
|
|
for (const table of MIGRATED_TABLES) {
|
|
const required = await db.execute(
|
|
sql`SELECT column_name FROM information_schema.columns
|
|
WHERE table_schema = 'public' AND table_name = ${table}
|
|
AND is_nullable = 'NO' AND column_default IS NULL`,
|
|
);
|
|
const canFill = columnsEngineCanFill(table, sourceColumns[table] ?? []);
|
|
for (const row of required.rows) {
|
|
const col = row.column_name as string;
|
|
if (!canFill.has(col)) unfillable.push(`${table}.${col}`);
|
|
}
|
|
}
|
|
// If this fails, a schema change added a required column the 1.x importer
|
|
// cannot populate. Give it a default, make it nullable, or add a computed
|
|
// default / rename mapping in migrate-from-sqlite.ts.
|
|
expect(unfillable).toEqual([]);
|
|
});
|
|
|
|
it("the guard flags a column the engine cannot fill (self-check)", () => {
|
|
const canFill = columnsEngineCanFill("users", ["id", "username"]);
|
|
expect(canFill.has("username")).toBe(true);
|
|
// A hypothetical future required column absent from the 1.17.2 source is not
|
|
// fillable, so the drift check above would report it and fail CI.
|
|
expect(canFill.has("some_future_required_col")).toBe(false);
|
|
});
|
|
});
|