mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
56 lines
2.1 KiB
TypeScript
56 lines
2.1 KiB
TypeScript
import { execFileSync } from "node:child_process";
|
|
import { ffmpegAvailable, probeMedia } from "@snapotter/media-engine";
|
|
import sharp from "sharp";
|
|
import { describe, expect, it } from "vitest";
|
|
import { fixtures } from "../../fixtures/index.js";
|
|
|
|
const qpdf = process.env.QPDF_PATH || "qpdf";
|
|
|
|
describe("real fixtures decode through their real tools", () => {
|
|
// JPEG/PNG/WEBP only -- formats Sharp decodes unconditionally. HEIC/HEIF heroes
|
|
// (portrait.heic, motorcycle.heif) are exercised by the real tool routes in the
|
|
// Phase 2 depth tests, where the factory's HEIC decode path is in play.
|
|
it.each([
|
|
fixtures.image.portrait.jpg,
|
|
fixtures.image.redEye,
|
|
fixtures.image.ocr.clean,
|
|
fixtures.image.ocr.japanese,
|
|
fixtures.image.multiFace,
|
|
])("Sharp decodes %s with sane dimensions", async (path) => {
|
|
const meta = await sharp(path).metadata();
|
|
expect((meta.width ?? 0) * (meta.height ?? 0)).toBeGreaterThan(64 * 64);
|
|
});
|
|
|
|
// Probe via media-engine, which resolves the bundled static ffmpeg/ffprobe.
|
|
// System ffprobe is NOT on PATH in CI (only the static binary is), so a bare
|
|
// `ffprobe` spawn would ENOENT. Gate on ffmpeg presence so a machine with no
|
|
// ffmpeg at all skips cleanly.
|
|
describe.skipIf(!ffmpegAvailable())("media probes", () => {
|
|
it.each([
|
|
fixtures.video.hero.mp4,
|
|
fixtures.video.hero.mov,
|
|
fixtures.video.hero.webm,
|
|
fixtures.video.hero.mkv,
|
|
fixtures.video.hero.avi,
|
|
fixtures.audio.speech.wav,
|
|
fixtures.audio.speech.flac,
|
|
fixtures.audio.speech.ogg,
|
|
fixtures.audio.speech.m4a,
|
|
fixtures.audio.speech.aac,
|
|
fixtures.audio.speech.opus,
|
|
fixtures.audio.tagged,
|
|
])("media probe reads a positive duration from %s", async (path) => {
|
|
const info = await probeMedia(path);
|
|
expect(info.durationS).toBeGreaterThan(0);
|
|
});
|
|
});
|
|
|
|
it.each([fixtures.document.pdfMulti, fixtures.document.pdfScanned])(
|
|
"qpdf reports pages for %s",
|
|
(path) => {
|
|
const out = execFileSync(qpdf, ["--show-npages", path], { encoding: "utf8" });
|
|
expect(Number.parseInt(out.trim(), 10)).toBeGreaterThan(0);
|
|
},
|
|
);
|
|
});
|