mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
67 lines
2.2 KiB
Python
67 lines
2.2 KiB
Python
"""What Real-ESRGAN tells the user when it cannot run (AI-20260726-002).
|
|
|
|
Observed on ubuntu-gpu-amd64 with `upscale-enhance` installed and working
|
|
weights on disk: scipy was carrying 1.12.0 and 1.17.1 at once, so the import
|
|
chain raised
|
|
|
|
cannot import name '_promote' from 'scipy.spatial.transform._rotation'
|
|
|
|
and the tool answered "Install the upscale-enhance feature", which the user had
|
|
already done. The advice has to follow the shape of the failure, not the fact
|
|
that one occurred.
|
|
"""
|
|
|
|
import importlib.util
|
|
import os
|
|
|
|
|
|
def load_upscale():
|
|
script_path = os.path.join(os.path.dirname(__file__), "..", "upscale.py")
|
|
spec = importlib.util.spec_from_file_location("upscale_message_under_test", script_path)
|
|
module = importlib.util.module_from_spec(spec)
|
|
assert spec.loader is not None
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
def test_a_broken_dependency_does_not_ask_for_an_install_that_already_happened():
|
|
upscale = load_upscale()
|
|
failure = ImportError(
|
|
"cannot import name '_promote' from 'scipy.spatial.transform._rotation'"
|
|
)
|
|
|
|
message = upscale.realesrgan_failure_message(failure)
|
|
|
|
assert "_promote" in message
|
|
assert "Install the upscale-enhance feature" not in message
|
|
assert "Reinstall" in message
|
|
assert "model=lanczos" in message
|
|
|
|
|
|
def test_a_missing_module_still_asks_for_the_install():
|
|
upscale = load_upscale()
|
|
|
|
message = upscale.realesrgan_failure_message(ModuleNotFoundError("No module named 'realesrgan'"))
|
|
|
|
assert "Install the upscale-enhance feature" in message
|
|
|
|
|
|
def test_missing_weights_still_ask_for_the_install():
|
|
"""The bundle carries the .pth files, so absent weights mean absent bundle."""
|
|
upscale = load_upscale()
|
|
|
|
message = upscale.realesrgan_failure_message(
|
|
FileNotFoundError("RealESRGAN model not found: /data/ai/models/RealESRGAN_x4plus.pth")
|
|
)
|
|
|
|
assert "Install the upscale-enhance feature" in message
|
|
|
|
|
|
def test_a_runtime_failure_points_at_a_repair_rather_than_an_install():
|
|
upscale = load_upscale()
|
|
|
|
message = upscale.realesrgan_failure_message(RuntimeError("CUDA error: no kernel image"))
|
|
|
|
assert "Install the upscale-enhance feature" not in message
|
|
assert "Reset AI Environment" in message
|