mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
60 lines
2.2 KiB
TypeScript
60 lines
2.2 KiB
TypeScript
// @vitest-environment node
|
|
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { SUPPORTED_LOCALES } from "@snapotter/shared";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
/**
|
|
* The landing home page is the highest-value SEO page in each language, and all
|
|
* 20 localized copies shipped the English <title> and <meta description>
|
|
* because index.astro held them as string literals.
|
|
*
|
|
* t() falls back to English, so adding the keys to en.json alone changes
|
|
* nothing. A per-locale check is the only thing that can tell the difference,
|
|
* and it has to reject an English value rather than just a present one.
|
|
*/
|
|
|
|
const ROOT = path.resolve(__dirname, "../../..");
|
|
const I18N_DIR = path.join(ROOT, "apps/landing/src/i18n");
|
|
const KEYS = ["home.metaTitle", "home.metaDescription"] as const;
|
|
|
|
function catalog(locale: string): Record<string, string> {
|
|
return JSON.parse(fs.readFileSync(path.join(I18N_DIR, `${locale}.json`), "utf-8"));
|
|
}
|
|
|
|
const en = catalog("en");
|
|
const locales = SUPPORTED_LOCALES.map((l) => l.code);
|
|
|
|
describe("landing home page metadata", () => {
|
|
it("covers every supported locale", () => {
|
|
expect(locales.length).toBe(21);
|
|
});
|
|
|
|
it("resolves the title and description from the catalog, not from a literal", () => {
|
|
const src = fs.readFileSync(
|
|
path.join(ROOT, "apps/landing/src/pages/[...locale]/index.astro"),
|
|
"utf-8",
|
|
);
|
|
for (const key of KEYS) {
|
|
expect(src).toContain(`t(locale, "${key}")`);
|
|
}
|
|
// The English strings living in the page again would silently un-localize it.
|
|
expect(src).not.toContain(en["home.metaTitle"]);
|
|
});
|
|
|
|
it.each(KEYS)("en.json defines %s", (key) => {
|
|
expect(en[key]).toBeTruthy();
|
|
});
|
|
|
|
it.each(locales.filter((l) => l !== "en"))("%s translates both keys", (locale) => {
|
|
const strings = catalog(locale);
|
|
for (const key of KEYS) {
|
|
expect(strings[key], `${locale} is missing ${key}`).toBeTruthy();
|
|
expect(strings[key], `${locale} still carries the English ${key}`).not.toBe(en[key]);
|
|
}
|
|
// A title that gets cut off in a search result is barely better than a
|
|
// missing one. Chinese and Japanese run short, so this is a ceiling only.
|
|
expect(strings["home.metaTitle"].length).toBeLessThanOrEqual(70);
|
|
});
|
|
});
|