mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
278 lines
8.6 KiB
TypeScript
278 lines
8.6 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
vi.mock("../../../packages/ai/src/bridge.js", async (importOriginal) => ({
|
|
...(await importOriginal<typeof import("../../../packages/ai/src/bridge.js")>()),
|
|
runPythonWithProgress: vi.fn(),
|
|
parseStdoutJson: vi.fn(),
|
|
}));
|
|
|
|
import { parseStdoutJson, runPythonWithProgress } from "../../../packages/ai/src/bridge.js";
|
|
import { transcribeAudio } from "../../../packages/ai/src/transcription.js";
|
|
|
|
const FAKE_AUDIO = "/tmp/test-audio/input.wav";
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
vi.mocked(runPythonWithProgress).mockResolvedValue({
|
|
stdout:
|
|
'{"success":true,"language":"en","segments":[{"start":0.0,"end":1.5,"text":"Hello"}],"text":"Hello"}',
|
|
stderr: "",
|
|
});
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [{ start: 0.0, end: 1.5, text: "Hello" }],
|
|
text: "Hello",
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe("transcribeAudio", () => {
|
|
describe("request serialization", () => {
|
|
it("calls transcribe.py with input path and options JSON", async () => {
|
|
await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
|
|
expect(runPythonWithProgress).toHaveBeenCalledWith(
|
|
"transcribe.py",
|
|
[FAKE_AUDIO, JSON.stringify({ language: "auto", task: "transcribe" })],
|
|
expect.objectContaining({ timeout: 30 * 60_000 }),
|
|
);
|
|
});
|
|
|
|
it("serializes a specific language", async () => {
|
|
await transcribeAudio(FAKE_AUDIO, { language: "de" });
|
|
|
|
const args = vi.mocked(runPythonWithProgress).mock.calls[0][1];
|
|
expect(JSON.parse(args[1])).toEqual({ language: "de", task: "transcribe" });
|
|
});
|
|
|
|
it("always includes task: transcribe", async () => {
|
|
await transcribeAudio(FAKE_AUDIO, { language: "ja" });
|
|
|
|
const args = vi.mocked(runPythonWithProgress).mock.calls[0][1];
|
|
const parsed = JSON.parse(args[1]);
|
|
expect(parsed.task).toBe("transcribe");
|
|
});
|
|
|
|
it("uses 30 minute timeout", async () => {
|
|
await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
|
|
const options = vi.mocked(runPythonWithProgress).mock.calls[0][2];
|
|
expect(options.timeout).toBe(30 * 60_000);
|
|
});
|
|
});
|
|
|
|
describe("segment key mapping", () => {
|
|
it("maps python start/end to startS/endS", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [
|
|
{ start: 0.0, end: 1.5, text: "Hello" },
|
|
{ start: 2.0, end: 4.123, text: "World" },
|
|
],
|
|
text: "Hello World",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
|
|
expect(result.segments).toEqual([
|
|
{ startS: 0.0, endS: 1.5, text: "Hello" },
|
|
{ startS: 2.0, endS: 4.123, text: "World" },
|
|
]);
|
|
});
|
|
|
|
it("trims segment text", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [{ start: 0, end: 1, text: " padded text " }],
|
|
text: "padded text",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments[0].text).toBe("padded text");
|
|
});
|
|
|
|
it("defaults missing start/end to 0", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [{ text: "no timestamps" }],
|
|
text: "no timestamps",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments[0]).toEqual({ startS: 0, endS: 0, text: "no timestamps" });
|
|
});
|
|
|
|
it("defaults missing text to empty string", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [{ start: 0, end: 1 }],
|
|
text: "",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments[0].text).toBe("");
|
|
});
|
|
});
|
|
|
|
describe("defensive parsing", () => {
|
|
it("returns empty segments when segments field is missing", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
text: "Hello",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments).toEqual([]);
|
|
});
|
|
|
|
it("returns empty segments when segments is null", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: null,
|
|
text: "Hello",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments).toEqual([]);
|
|
});
|
|
|
|
it("returns empty segments when segments is not an array", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: "not-an-array",
|
|
text: "Hello",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.segments).toEqual([]);
|
|
});
|
|
|
|
it("defaults language to en when missing", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
segments: [],
|
|
text: "",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.language).toBe("en");
|
|
});
|
|
|
|
it("defaults text to empty string when missing", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "en",
|
|
segments: [],
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.text).toBe("");
|
|
});
|
|
});
|
|
|
|
describe("response parsing", () => {
|
|
it("returns language, text, and segments", async () => {
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
|
|
expect(result).toEqual({
|
|
language: "en",
|
|
text: "Hello",
|
|
segments: [{ startS: 0.0, endS: 1.5, text: "Hello" }],
|
|
});
|
|
});
|
|
|
|
it("returns detected language", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
success: true,
|
|
language: "fr",
|
|
segments: [],
|
|
text: "Bonjour",
|
|
});
|
|
|
|
const result = await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
expect(result.language).toBe("fr");
|
|
});
|
|
});
|
|
|
|
describe("error handling", () => {
|
|
it("throws when Python returns an error field", async () => {
|
|
vi.mocked(parseStdoutJson).mockReturnValue({
|
|
error: "Model not found",
|
|
});
|
|
|
|
await expect(transcribeAudio(FAKE_AUDIO, { language: "auto" })).rejects.toThrow(
|
|
"Model not found",
|
|
);
|
|
});
|
|
|
|
it("propagates bridge timeout", async () => {
|
|
vi.mocked(runPythonWithProgress).mockRejectedValue(new Error("Python script timed out"));
|
|
|
|
await expect(transcribeAudio(FAKE_AUDIO, { language: "auto" })).rejects.toThrow("timed out");
|
|
});
|
|
|
|
it("propagates OOM errors from bridge", async () => {
|
|
vi.mocked(runPythonWithProgress).mockRejectedValue(
|
|
new Error("Process killed (out of memory)"),
|
|
);
|
|
|
|
await expect(transcribeAudio(FAKE_AUDIO, { language: "auto" })).rejects.toThrow(
|
|
"out of memory",
|
|
);
|
|
});
|
|
|
|
it("propagates parseStdoutJson errors", async () => {
|
|
vi.mocked(parseStdoutJson).mockImplementation(() => {
|
|
throw new Error("No JSON response from Python script");
|
|
});
|
|
|
|
await expect(transcribeAudio(FAKE_AUDIO, { language: "auto" })).rejects.toThrow(
|
|
"No JSON response from Python script",
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("onProgress forwarding", () => {
|
|
it("passes onProgress to bridge", async () => {
|
|
const onProgress = vi.fn();
|
|
await transcribeAudio(FAKE_AUDIO, { language: "auto" }, onProgress);
|
|
|
|
expect(runPythonWithProgress).toHaveBeenCalledWith(
|
|
"transcribe.py",
|
|
expect.any(Array),
|
|
expect.objectContaining({ onProgress }),
|
|
);
|
|
});
|
|
|
|
it("omits onProgress when not provided", async () => {
|
|
await transcribeAudio(FAKE_AUDIO, { language: "auto" });
|
|
|
|
const options = vi.mocked(runPythonWithProgress).mock.calls[0][2];
|
|
expect(options.onProgress).toBeUndefined();
|
|
});
|
|
|
|
it("forwards the caller AbortSignal to the Python bridge", async () => {
|
|
const controller = new AbortController();
|
|
|
|
await transcribeAudio(FAKE_AUDIO, { language: "auto", signal: controller.signal });
|
|
|
|
expect(runPythonWithProgress).toHaveBeenCalledWith(
|
|
"transcribe.py",
|
|
expect.any(Array),
|
|
expect.objectContaining({ signal: controller.signal }),
|
|
);
|
|
});
|
|
});
|
|
});
|