mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
The scheduled Nightly had been red for over a week across nearly every job. This root-causes and fixes each one. All were pre-existing: missing CI provisioning, specs that drifted as the app grew, a job too heavy for its timeout, and a fuzz that was never configured for file-upload endpoints. None came from the recent security merge. - Coverage + Docker Container E2E: install tesseract and its language packs so the built-in Fast OCR tests stop throwing spawn ENOENT; gate two repo-file and release-workflow tests that cannot run inside the slimmed container image. - E2E (Full, Serial, Cross-Browser, Device Matrix): refresh specs that drifted behind the app (tool renames, the now admin-only Tools tab, dropped About copy, locator collisions scoped to the right region). One real product fix rode along: /config/auth was refetched six times per tool-page load, so cache it behind a single shared fetch, dropping the tool page from 13 to 8 API calls. - Extended Matrix + Fuzz: shard the integration suite four ways so the full format x tool matrix plus property fuzz fits its budget instead of overrunning the 90-minute ceiling every night. - Schemathesis: exclude the tools with bespoke handlers that process synchronously in-request (they hang the fuzz on adversarial input) and suppress Hypothesis's data-generation health checks, which fire because file-upload endpoints reject the fuzzer's random bytes. not_a_server_error still runs on every generated case (5000+ per run). - Stabilize two long-tail flakes: raise the avif matrix per-test cap from 240s to 600s, and assert toHaveCount(0) on the deleted user row so a transient success toast no longer trips a strict-mode violation. Verified end to end: the full Nightly workflow is green on this branch (all 14 jobs), and PR CI is green.
170 lines
6.3 KiB
TypeScript
170 lines
6.3 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { apiToolPath, TOOLS } from "@snapotter/shared";
|
|
import sharp from "sharp";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { getRegisteredToolIds, getToolConfig } from "../../../apps/api/src/routes/tool-factory.js";
|
|
import { fixtureDir } from "../../fixtures/index.js";
|
|
import {
|
|
defaultSettingsFor,
|
|
TOOL_SETTINGS_OVERRIDES,
|
|
} from "../../helpers/tool-default-settings.js";
|
|
import { cancelAcceptedJobAndWait } from "../settle-job.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../test-server.js";
|
|
|
|
/**
|
|
* Registry-generated tool x format matrix.
|
|
*
|
|
* Every registered tool is exercised against every input format fixture with
|
|
* its minimal valid settings. The invariant is the factory's error contract:
|
|
* success (200/202), clean rejection (400/413/415/422), or AI-not-installed
|
|
* (501). A 500 or an undecodable "successful" output is a bug.
|
|
*
|
|
* PR runs use the core web formats; FULL_MATRIX=1 (nightly) unlocks all
|
|
* fixtures in tests/fixtures/image/formats/.
|
|
*/
|
|
|
|
const CORE_FORMATS = [
|
|
"sample.png",
|
|
"sample.jpg",
|
|
"sample.webp",
|
|
"sample.gif",
|
|
"sample.svg",
|
|
"sample.heic",
|
|
];
|
|
|
|
const fixtureFiles = process.env.FULL_MATRIX
|
|
? readdirSync(fixtureDir.formats).filter((f) => !f.startsWith("."))
|
|
: CORE_FORMATS;
|
|
|
|
const ALLOWED_STATUSES = new Set([200, 202, 400, 413, 415, 422, 501]);
|
|
|
|
/**
|
|
* Raster content types this libvips/Sharp build is guaranteed to decode. Used
|
|
* to decide whether a 200 image response should be pixel-verified. Anything
|
|
* else (PDF, JSON, ZIP, SVG, or a niche raster like BMP/PSD streamed back
|
|
* untouched) carries an honest content-type we don't attempt to decode.
|
|
*/
|
|
const SHARP_DECODABLE_TYPES = new Set([
|
|
"image/jpeg",
|
|
"image/png",
|
|
"image/webp",
|
|
"image/gif",
|
|
"image/tiff",
|
|
"image/avif",
|
|
]);
|
|
|
|
describe("tool x format matrix (generated)", () => {
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
it("settings overrides only reference registered tools", () => {
|
|
const registered = new Set(getRegisteredToolIds());
|
|
for (const toolId of Object.keys(TOOL_SETTINGS_OVERRIDES)) {
|
|
expect(registered.has(toolId), `override for unknown tool "${toolId}"`).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("default settings are valid for every registered tool", () => {
|
|
const invalid: string[] = [];
|
|
for (const toolId of getRegisteredToolIds()) {
|
|
const config = getToolConfig(toolId);
|
|
if (!config) continue;
|
|
const result = config.settingsSchema.safeParse(defaultSettingsFor(toolId));
|
|
if (!result.success) {
|
|
invalid.push(
|
|
`${toolId}: ${result.error.issues.map((i) => `${i.path.join(".")} ${i.message}`).join("; ")}`,
|
|
);
|
|
}
|
|
}
|
|
expect(
|
|
invalid,
|
|
`tools needing TOOL_SETTINGS_OVERRIDES entries:\n${invalid.join("\n")}`,
|
|
).toEqual([]);
|
|
});
|
|
|
|
for (const tool of TOOLS) {
|
|
const toolId = tool.id;
|
|
it(`${toolId} handles every input format cleanly`, async () => {
|
|
for (const fixture of fixtureFiles) {
|
|
const content = readFileSync(join(fixtureDir.formats, fixture));
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: fixture, contentType: "application/octet-stream", content },
|
|
{ name: "settings", content: JSON.stringify(defaultSettingsFor(toolId)) },
|
|
]);
|
|
const res = await testApp.app.inject({
|
|
method: "POST",
|
|
url: apiToolPath(toolId),
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
|
|
// Custom-route tools can 404 on the standard path; covered elsewhere.
|
|
if (res.statusCode === 404) return;
|
|
|
|
expect(
|
|
ALLOWED_STATUSES.has(res.statusCode),
|
|
`${toolId} x ${fixture}: status ${res.statusCode}: ${res.body.slice(0, 300)}`,
|
|
).toBe(true);
|
|
|
|
if (res.statusCode === 200) {
|
|
const resType = (res.headers["content-type"]?.toString() ?? "").split(";")[0];
|
|
if (resType !== "application/json") {
|
|
// Tools like bulk-rename/favicon/split stream a ZIP directly.
|
|
if (resType === "application/zip") {
|
|
expect(
|
|
res.rawPayload.subarray(0, 2).toString("latin1"),
|
|
`${toolId} x ${fixture}: ZIP response is not a ZIP`,
|
|
).toBe("PK");
|
|
}
|
|
continue;
|
|
}
|
|
const payload = JSON.parse(res.body) as { downloadUrl?: string };
|
|
if (!payload.downloadUrl) continue;
|
|
const dl = await testApp.app.inject({
|
|
method: "GET",
|
|
url: payload.downloadUrl,
|
|
headers: { authorization: `Bearer ${adminToken}` },
|
|
});
|
|
expect(dl.statusCode, `${toolId} x ${fixture}: download failed`).toBe(200);
|
|
const outType = (dl.headers["content-type"]?.toString() ?? "").split(";")[0];
|
|
// Allowlist of raster types this libvips build is guaranteed to
|
|
// decode. An allowlist (vs the old denylist) is robust to tools that
|
|
// legitimately stream back niche formats untouched (e.g. edit-metadata
|
|
// writing tags in place on a BMP/PSD): those carry an honest
|
|
// content-type we simply don't pixel-verify, rather than being
|
|
// misread as a corrupt JPEG.
|
|
const sharpDecodable = SHARP_DECODABLE_TYPES.has(outType);
|
|
if (sharpDecodable) {
|
|
// The processed output must actually decode; a corrupt "success" is a bug.
|
|
const meta = await sharp(dl.rawPayload).metadata();
|
|
expect(meta.width, `${toolId} x ${fixture}: output not decodable`).toBeGreaterThan(0);
|
|
}
|
|
}
|
|
|
|
if (res.statusCode === 202 && (toolId === "ocr" || toolId === "ocr-pdf")) {
|
|
const payload = JSON.parse(res.body) as { jobId?: string };
|
|
expect(payload.jobId).toBeDefined();
|
|
await cancelAcceptedJobAndWait(payload.jobId as string, "ai");
|
|
}
|
|
}
|
|
// The nightly avif converters run many slow encodes per test; a busy runner
|
|
// intermittently overran the old 240s cap, so allow the job's full budget.
|
|
}, 600_000);
|
|
}
|
|
});
|