mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
115 lines
4.4 KiB
YAML
115 lines
4.4 KiB
YAML
###############################################################################
|
|
# Test infrastructure - run with:
|
|
# docker compose -f docker/docker-compose.test.yml up --build --abort-on-container-exit
|
|
###############################################################################
|
|
name: snapotter-test
|
|
services:
|
|
# ── Unit + Integration tests ─────────────────────────────────────────────
|
|
test-unit:
|
|
build:
|
|
context: ..
|
|
dockerfile: docker/Dockerfile.test
|
|
container_name: SnapOtter-test-unit
|
|
# Functional gate: run the suite without --coverage. The lean test image
|
|
# skips binary-gated tools (AI models need on-demand bundles, etc.), so it
|
|
# cannot meet the host-calibrated coverage thresholds; coverage stays
|
|
# enforced on host CI where every tool is present.
|
|
command: ["pnpm", "vitest", "run", "--reporter=verbose"]
|
|
environment:
|
|
- NODE_ENV=test
|
|
- AUTH_ENABLED=true
|
|
- DEFAULT_USERNAME=admin
|
|
- DEFAULT_PASSWORD=admin
|
|
- DATABASE_URL=postgres://snapotter:snapotter@postgres:5432/snapotter_test
|
|
# Tells tests/global-setup.ts to use these servers instead of spawning
|
|
# testcontainers (no docker daemon inside the test container).
|
|
- TEST_DATABASE_URL=postgres://snapotter:snapotter@postgres:5432/snapotter_test
|
|
- TEST_REDIS_URL=redis://redis:6379
|
|
- REDIS_URL=redis://redis:6379
|
|
- WORKSPACE_PATH=/tmp/test-workspace
|
|
- MAX_MEGAPIXELS=100
|
|
- RATE_LIMIT_PER_MIN=1000
|
|
# The macOS Docker VM runs Sharp/FFmpeg ~2-3x slower than the host and
|
|
# oversubscribes CPU across parallel vitest forks, so heavy ops (e.g. a
|
|
# 12MP stress-image enhance) blow past the 30s test sync window and fall
|
|
# back to a 202 that sync-asserting tests reject. Give the sync window
|
|
# generous headroom (honored by tests/setup/per-fork-env.ts) and keep the
|
|
# framework test/hook timeouts above it so a slow-but-correct job returns
|
|
# 200 instead of tripping a vitest timeout. Host/CI keep the 30s defaults.
|
|
- SYNC_WAIT_MS=120000
|
|
- VITEST_TEST_TIMEOUT=180000
|
|
- VITEST_HOOK_TIMEOUT=120000
|
|
tmpfs:
|
|
- /tmp/test-workspace
|
|
- /tmp
|
|
depends_on:
|
|
postgres:
|
|
condition: service_healthy
|
|
redis:
|
|
condition: service_healthy
|
|
|
|
# ── E2E tests (Playwright against full app) ─────────────────────────────
|
|
test-e2e:
|
|
build:
|
|
context: ..
|
|
dockerfile: docker/Dockerfile.test
|
|
container_name: SnapOtter-test-e2e
|
|
# Visual project is excluded: linux baselines are managed by the
|
|
# update-visual-baselines workflow, not generated inside the container.
|
|
command:
|
|
[
|
|
"sh",
|
|
"-c",
|
|
"npx playwright install --with-deps chromium && pnpm playwright test --project=chromium && pnpm playwright test --project=chromium-serial --workers=1",
|
|
]
|
|
environment:
|
|
- NODE_ENV=test
|
|
- AUTH_ENABLED=true
|
|
- DEFAULT_USERNAME=admin
|
|
- DEFAULT_PASSWORD=admin
|
|
- DATABASE_URL=postgres://snapotter:snapotter@postgres:5432/snapotter_test
|
|
- REDIS_URL=redis://redis:6379
|
|
- WORKSPACE_PATH=/tmp/test-workspace
|
|
- MAX_MEGAPIXELS=100
|
|
- RATE_LIMIT_PER_MIN=1000
|
|
- CI=true
|
|
tmpfs:
|
|
- /tmp/test-workspace
|
|
- /tmp
|
|
depends_on:
|
|
test-unit:
|
|
condition: service_completed_successfully
|
|
postgres:
|
|
condition: service_healthy
|
|
redis:
|
|
condition: service_healthy
|
|
|
|
postgres:
|
|
image: postgres:17-alpine@sha256:742f40ea20b9ff2ff31db5458d127452988a2164df9e17441e191f3b72252193
|
|
container_name: SnapOtter-test-postgres
|
|
environment:
|
|
POSTGRES_USER: snapotter
|
|
POSTGRES_PASSWORD: snapotter
|
|
POSTGRES_DB: snapotter_test
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "pg_isready -U snapotter"]
|
|
interval: 10s
|
|
timeout: 5s
|
|
retries: 12
|
|
start_period: 15s
|
|
tmpfs:
|
|
- /var/lib/postgresql/data
|
|
|
|
redis:
|
|
image: redis:8-alpine@sha256:9d317178eceac8454a2284a9e6df2466b93c745529947f0cd42a0fa9609d7005
|
|
container_name: SnapOtter-test-redis
|
|
command: ["redis-server", "--maxmemory-policy", "noeviction", "--appendonly", "no"]
|
|
healthcheck:
|
|
test: ["CMD", "redis-cli", "ping"]
|
|
interval: 10s
|
|
timeout: 5s
|
|
retries: 12
|
|
start_period: 10s
|
|
tmpfs:
|
|
- /data
|