Files
SnapOtter/apps/web/src/components/tools/image-to-pdf-settings.tsx
T
Siddharth Kumar SahandJulian Nadeau d0c69d6a46 fix(web): skip empty Authorization header for forward-auth proxy compatibility
Centralize duplicated getToken() + Bearer header logic into a single
formatHeaders() helper in lib/api.ts. When no token exists, the
Authorization header is omitted entirely instead of sending an empty
Bearer token, which breaks forward-auth proxies like Authelia behind
Caddy.

Changes:
- Add formatHeaders() with try-catch around localStorage access
- Replace 20+ duplicated getToken() definitions across tool components
- Migrate all call sites including file-details, settings, change-password
- Update tests to verify header omission on empty token

Based on the fix proposed by @jules2689 in #6, with improvements:
file placement (lib/api.ts vs components), localStorage error handling,
simplified truthiness check, and complete call-site coverage.

Co-Authored-By: Julian Nadeau <julian@jnadeau.ca>
2026-04-05 18:41:06 +08:00

251 lines
7.8 KiB
TypeScript

import { Download, Loader2 } from "lucide-react";
import { useEffect, useMemo, useState } from "react";
import { formatHeaders } from "@/lib/api";
import { useFileStore } from "@/stores/file-store";
const PAGE_SIZES: Record<string, [number, number]> = {
A4: [595.28, 841.89],
Letter: [612, 792],
A3: [841.89, 1190.55],
A5: [419.53, 595.28],
};
const PREVIEW_HEIGHT = 220;
function PdfPagePreview({
pageSize,
orientation,
margin,
file,
}: {
pageSize: string;
orientation: "portrait" | "landscape";
margin: number;
file: File | null;
}) {
const [imgSize, setImgSize] = useState<{ w: number; h: number } | null>(null);
const imgUrl = useMemo(() => (file ? URL.createObjectURL(file) : null), [file]);
useEffect(() => {
return () => {
if (imgUrl) URL.revokeObjectURL(imgUrl);
};
}, [imgUrl]);
useEffect(() => {
if (!imgUrl) {
setImgSize(null);
return;
}
const img = new Image();
img.onload = () => setImgSize({ w: img.naturalWidth, h: img.naturalHeight });
img.src = imgUrl;
}, [imgUrl]);
let [pageW, pageH] = PAGE_SIZES[pageSize] ?? PAGE_SIZES.A4;
if (orientation === "landscape") [pageW, pageH] = [pageH, pageW];
const scale = PREVIEW_HEIGHT / pageH;
const previewW = pageW * scale;
const previewH = PREVIEW_HEIGHT;
const marginScaled = margin * scale;
const contentW = previewW - marginScaled * 2;
const contentH = previewH - marginScaled * 2;
let imgStyle: React.CSSProperties | null = null;
if (imgSize && imgUrl && contentW > 0 && contentH > 0) {
const imgScale = Math.min(contentW / imgSize.w, contentH / imgSize.h, 1);
const scaledW = imgSize.w * imgScale;
const scaledH = imgSize.h * imgScale;
imgStyle = {
width: scaledW,
height: scaledH,
position: "absolute" as const,
left: marginScaled + (contentW - scaledW) / 2,
top: marginScaled + (contentH - scaledH) / 2,
objectFit: "contain" as const,
};
}
return (
<div>
<p className="text-xs text-muted-foreground mb-2">Preview</p>
<div className="flex justify-center">
<div
className="relative bg-white border border-border"
style={{
width: previewW,
height: previewH,
boxShadow: "2px 3px 8px rgba(0,0,0,0.10)",
transition: "width 0.2s ease, height 0.2s ease",
}}
>
{/* Margin area — dashed inner border */}
{margin > 0 && (
<div
className="absolute border border-dashed border-blue-300/60"
style={{
left: marginScaled,
top: marginScaled,
width: contentW,
height: contentH,
transition: "all 0.2s ease",
}}
/>
)}
{/* Image thumbnail */}
{imgStyle && imgUrl && (
<img src={imgUrl} alt="Preview" style={{ ...imgStyle, transition: "all 0.2s ease" }} />
)}
{/* Empty state placeholder */}
{!imgUrl && (
<div className="absolute inset-0 flex items-center justify-center">
<span className="text-[10px] text-muted-foreground/40">No image</span>
</div>
)}
</div>
</div>
</div>
);
}
export function ImageToPdfSettings() {
const { files, selectedIndex, processing, error, setProcessing, setError } = useFileStore();
const [pageSize, setPageSize] = useState<"A4" | "Letter" | "A3" | "A5">("A4");
const [orientation, setOrientation] = useState<"portrait" | "landscape">("portrait");
const [margin, setMargin] = useState(20);
const [downloadUrl, setDownloadUrl] = useState<string | null>(null);
const handleProcess = async () => {
if (files.length === 0) return;
setProcessing(true);
setError(null);
setDownloadUrl(null);
try {
const formData = new FormData();
for (const file of files) {
formData.append("file", file);
}
formData.append("settings", JSON.stringify({ pageSize, orientation, margin }));
const res = await fetch("/api/v1/tools/image-to-pdf", {
method: "POST",
headers: formatHeaders(),
body: formData,
});
if (!res.ok) {
const body = await res.json().catch(() => ({}));
throw new Error(body.error || `Failed: ${res.status}`);
}
const result = await res.json();
setDownloadUrl(result.downloadUrl);
} catch (err) {
setError(err instanceof Error ? err.message : "PDF creation failed");
} finally {
setProcessing(false);
}
};
const hasFiles = files.length > 0;
return (
<div className="space-y-4">
<p className="text-xs text-muted-foreground">
{files.length} image{files.length !== 1 ? "s" : ""} will be combined into a PDF, one image
per page.
</p>
<div>
<label htmlFor="image-to-pdf-page-size" className="text-xs text-muted-foreground">
Page Size
</label>
<select
id="image-to-pdf-page-size"
value={pageSize}
onChange={(e) => setPageSize(e.target.value as typeof pageSize)}
className="w-full mt-0.5 px-2 py-1.5 rounded border border-border bg-background text-sm text-foreground"
>
<option value="A4">A4</option>
<option value="Letter">Letter</option>
<option value="A3">A3</option>
<option value="A5">A5</option>
</select>
</div>
<div>
<p className="text-xs text-muted-foreground">Orientation</p>
<div className="flex gap-1 mt-1">
<button
type="button"
onClick={() => setOrientation("portrait")}
className={`flex-1 text-xs py-1.5 rounded ${orientation === "portrait" ? "bg-primary text-primary-foreground" : "bg-muted text-muted-foreground"}`}
>
Portrait
</button>
<button
type="button"
onClick={() => setOrientation("landscape")}
className={`flex-1 text-xs py-1.5 rounded ${orientation === "landscape" ? "bg-primary text-primary-foreground" : "bg-muted text-muted-foreground"}`}
>
Landscape
</button>
</div>
</div>
<div>
<div className="flex justify-between items-center">
<label htmlFor="image-to-pdf-margin" className="text-xs text-muted-foreground">
Margin
</label>
<span className="text-xs font-mono text-foreground">{margin}pt</span>
</div>
<input
id="image-to-pdf-margin"
type="range"
min={0}
max={100}
value={margin}
onChange={(e) => setMargin(Number(e.target.value))}
className="w-full mt-1"
/>
</div>
<PdfPagePreview
pageSize={pageSize}
orientation={orientation}
margin={margin}
file={files.length > 0 ? (files[selectedIndex] ?? files[0]) : null}
/>
{error && <p className="text-xs text-red-500">{error}</p>}
<button
type="button"
data-testid="image-to-pdf-submit"
onClick={handleProcess}
disabled={!hasFiles || processing}
className="w-full py-2.5 rounded-lg bg-primary text-primary-foreground font-medium disabled:opacity-50 disabled:cursor-not-allowed flex items-center justify-center gap-2"
>
{processing && <Loader2 className="h-4 w-4 animate-spin" />}
{processing ? "Creating PDF..." : `Create PDF (${files.length} pages)`}
</button>
{downloadUrl && (
<a
href={downloadUrl}
download
data-testid="image-to-pdf-download"
className="w-full py-2.5 rounded-lg border border-primary text-primary font-medium flex items-center justify-center gap-2 hover:bg-primary/5"
>
<Download className="h-4 w-4" />
Download PDF
</a>
)}
</div>
);
}