mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
85 lines
3.7 KiB
TypeScript
85 lines
3.7 KiB
TypeScript
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { test as setup } from "@playwright/test";
|
|
|
|
const authFile = process.env.PLAYWRIGHT_AUTH_FILE;
|
|
if (!authFile) {
|
|
throw new Error("PLAYWRIGHT_AUTH_FILE was not initialized by playwright.config.ts");
|
|
}
|
|
|
|
setup("authenticate", async ({ page }) => {
|
|
// Ensure directory exists
|
|
const dir = path.dirname(authFile);
|
|
if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
|
|
|
|
await page.goto("/login");
|
|
await page.getByLabel("Username").fill("admin");
|
|
await page.getByLabel("Password").fill("admin");
|
|
await page.getByRole("button", { name: /login/i }).click();
|
|
|
|
// Wait for login to complete (the token lands in localStorage)
|
|
await page.waitForFunction(() => localStorage.getItem("snapotter-token"), null, {
|
|
timeout: 15_000,
|
|
});
|
|
|
|
// After login the app redirects to "/" on its own. Wait for that redirect to
|
|
// settle before forcing navigation, otherwise page.goto races the in-flight
|
|
// client-side redirect and aborts ("interrupted by another navigation").
|
|
await page.waitForURL((url) => url.pathname === "/", { timeout: 30_000 }).catch(() => {});
|
|
await page.goto("/", { waitUntil: "domcontentloaded" });
|
|
await page.waitForLoadState("load");
|
|
|
|
// Fail fast on a misconfigured e2e service. A correctly configured API
|
|
// (SKIP_MUST_CHANGE_PASSWORD=true, fresh per-run DB) lands the admin on "/".
|
|
const landedPath = new URL(page.url()).pathname;
|
|
if (landedPath !== "/") {
|
|
throw new Error(
|
|
`Auth setup landed on "${landedPath}" instead of "/" using web endpoint ` +
|
|
`${process.env.PLAYWRIGHT_WEB_URL ?? "<unknown>"} and API endpoint ` +
|
|
`${process.env.API_URL ?? "<unknown>"}. The isolated service is misconfigured.`,
|
|
);
|
|
}
|
|
|
|
// Prove the browser's /api proxy reaches THIS run's API rather than some other
|
|
// checkout's server that happens to answer on a shared port. A session token
|
|
// exists only in the run-owned database, so replaying the token the browser
|
|
// just obtained against the resolved API endpoint is an identity check: it
|
|
// passes only when both paths terminate at the same instance. Reaching "an
|
|
// API" would still satisfy a health probe, which is how an earlier sweep
|
|
// silently mutated an unrelated instance's settings, sessions and jobs.
|
|
const apiUrl = process.env.API_URL;
|
|
if (!apiUrl) {
|
|
throw new Error("API_URL was not initialized by playwright.config.ts");
|
|
}
|
|
const proxiedToken = await page.evaluate(() => localStorage.getItem("snapotter-token"));
|
|
if (!proxiedToken) {
|
|
throw new Error("Login through the web endpoint produced no session token");
|
|
}
|
|
|
|
const identity = await page.request.get(`${apiUrl}/api/auth/session`, {
|
|
headers: { authorization: `Bearer ${proxiedToken}` },
|
|
});
|
|
if (!identity.ok()) {
|
|
throw new Error(
|
|
`The session minted through ${process.env.PLAYWRIGHT_WEB_URL ?? "<unknown>"} is unknown to ` +
|
|
`the run-owned API at ${apiUrl} (status ${identity.status()}). That web endpoint is ` +
|
|
"proxying /api to a different instance.",
|
|
);
|
|
}
|
|
|
|
// Negative control: without it the check above would also pass against an API
|
|
// running with authentication disabled, which accepts any bearer value.
|
|
const forged = await page.request.get(`${apiUrl}/api/auth/session`, {
|
|
headers: { authorization: "Bearer not-a-real-session-token" },
|
|
});
|
|
if (forged.status() !== 401) {
|
|
throw new Error(
|
|
`The run-owned API at ${apiUrl} accepted a forged session token (status ${forged.status()}), ` +
|
|
"so the identity check above proves nothing. Expected 401.",
|
|
);
|
|
}
|
|
|
|
// Save storage state (includes localStorage with the token)
|
|
await page.context().storageState({ path: authFile });
|
|
});
|