mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
22 lines
1.1 KiB
Plaintext
22 lines
1.1 KiB
Plaintext
# Trivy suppressions for the release and bundle scans.
|
|
#
|
|
# This file is empty on purpose. Every entry it used to hold (21 IDs covering
|
|
# pnpm 9.x and its bundled glob/minimatch/picomatch/tar, plus npm's vendored
|
|
# sigstore) suppressed something that is not in any shipped artifact: the
|
|
# production image purges pnpm and npm before the final layer, so raw and
|
|
# policy-filtered scans of both architectures return identical counts. Two of
|
|
# the rationales were also wrong on their own terms. A suppression list that
|
|
# suppresses nothing still costs review attention and hides the next real one.
|
|
#
|
|
# Before adding an ID here, check that it fires against a shipped artifact:
|
|
#
|
|
# trivy image --ignorefile /dev/null <ref>
|
|
#
|
|
# If it does, the entry needs three things in a comment directly above it: who
|
|
# owns getting it fixed, what unblocks the fix, and the date to re-check.
|
|
#
|
|
# Suppression is for findings that are genuinely absent from what we ship. For
|
|
# findings that ARE present and have no upstream fix, do not suppress them. Add
|
|
# the ID to .trivy-unfixed-allow instead, so the release scan keeps reporting
|
|
# it and a new one still fails the build.
|