mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
33dfcecd6a
Triaged the nightly failures (all pre-existing, unrelated to the analytics
work) and fixed the ones with clear root causes:
- video-speed: a 1s tiny.mp4 sped up 2x rounds to ~0.75s, flaking the +/-25%
duration assertion under heavy CI load. Use the 8s hero.mp4 (still 44.1kHz)
so rounding is negligible. Verified locally.
- Extended Matrix + Coverage timeouts: full-matrix / coverage-instrumented runs
starve the heavy media tests under 4 forks at the 30s default. Make maxForks
env-overridable (VITEST_MAX_FORKS) and run those jobs with 2 forks + a 300s
timeout so format-matrix conversions and qr-generate stop timing out.
- Device Matrix visual baselines: the update-visual-baselines workflow could
not start the app ('failed to create database') because it never provisioned
Postgres/Redis. Add the same services block the e2e jobs use.
- Docker E2E: a container pnpm install network blip exits 254. Add fetch
retries + a longer network timeout (frozen-lockfile already passes locally).
- Cross-browser: the home page is the tool catalog now (no dropzone), and the
tool routes moved to /<section>/<toolId>. Point the upload test at a real
tool page and fix the stale single-segment routes (/resize -> /image/resize,
etc.).
The flaky/timeout and cross-browser fixes can only be confirmed by the nightly
(they are load- and browser-specific); a fresh nightly run will verify.
107 lines
3.9 KiB
TypeScript
107 lines
3.9 KiB
TypeScript
import { mkdtempSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { ffmpegAvailable, probeMedia } from "@snapotter/media-engine";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
// An 8s clip (44.1kHz audio): long enough that the 2x-speed duration check is
|
|
// robust to ffmpeg's frame/packet rounding. The 1s tiny.mp4 rounded to ~0.75s
|
|
// for a 2x speed-up, which flaked the +/-25% assertion under heavy CI load.
|
|
const MP4 = readFixture(fixtures.video.hero.mp4);
|
|
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
let sourceDurationS: number;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
|
|
// Probe source duration and verify sampleRate for comparison
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "speed-src-"));
|
|
const srcFile = join(tmpDir, "tiny.mp4");
|
|
writeFileSync(srcFile, MP4);
|
|
const info = await probeMedia(srcFile);
|
|
sourceDurationS = info.durationS ?? 1;
|
|
const audioStream = info.streams.find((s) => s.type === "audio");
|
|
if (audioStream) {
|
|
// Verify sampleRate is populated correctly from ffprobe
|
|
expect(audioStream.sampleRate).toBe(44100);
|
|
}
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
async function runTool(settings: Record<string, unknown>) {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "tiny.mp4", contentType: "video/mp4", content: MP4 },
|
|
{ name: "settings", content: JSON.stringify(settings) },
|
|
]);
|
|
return testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/video/video-speed",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
}
|
|
|
|
describe.skipIf(!ffmpegAvailable())("video-speed (requires ffmpeg)", () => {
|
|
it("speeds up by factor 2 and halves duration", async () => {
|
|
const res = await runTool({ factor: 2 });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
|
|
const dl = await testApp.app.inject({ method: "GET", url: envelope.downloadUrl });
|
|
expect(dl.statusCode).toBe(200);
|
|
expect(dl.rawPayload.length).toBeGreaterThan(100);
|
|
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "speed-test-"));
|
|
const probeFile = join(tmpDir, "speed.mp4");
|
|
writeFileSync(probeFile, dl.rawPayload);
|
|
const info = await probeMedia(probeFile);
|
|
expect(info.durationS).not.toBeNull();
|
|
|
|
const expected = sourceDurationS / 2;
|
|
const tolerance = expected * 0.25;
|
|
expect(info.durationS as number).toBeGreaterThan(expected - tolerance);
|
|
expect(info.durationS as number).toBeLessThan(expected + tolerance);
|
|
}, 60_000);
|
|
|
|
it("speeds up by factor 2 with keepPitch=false and halves duration", async () => {
|
|
const res = await runTool({ factor: 2, keepPitch: false });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
|
|
const dl = await testApp.app.inject({ method: "GET", url: envelope.downloadUrl });
|
|
expect(dl.statusCode).toBe(200);
|
|
expect(dl.rawPayload.length).toBeGreaterThan(100);
|
|
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "speed-nopitch-"));
|
|
const probeFile = join(tmpDir, "speed-nopitch.mp4");
|
|
writeFileSync(probeFile, dl.rawPayload);
|
|
const info = await probeMedia(probeFile);
|
|
expect(info.durationS).not.toBeNull();
|
|
|
|
const expected = sourceDurationS / 2;
|
|
const tolerance = expected * 0.25;
|
|
expect(info.durationS as number).toBeGreaterThan(expected - tolerance);
|
|
expect(info.durationS as number).toBeLessThan(expected + tolerance);
|
|
}, 60_000);
|
|
|
|
it("rejects factor out of range with 400", async () => {
|
|
const res = await runTool({ factor: 8 });
|
|
expect(res.statusCode).toBe(400);
|
|
});
|
|
});
|