mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
88 lines
3.2 KiB
TypeScript
88 lines
3.2 KiB
TypeScript
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { ffmpegAvailable, probeMedia } from "@snapotter/media-engine";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
const MP3 = readFixture(fixtures.audio.tiny("mp3"));
|
|
|
|
// Default durationS in the ringtone-maker settings schema (also its max), so the
|
|
// happy-path call with `{}` caps the ringtone at this many seconds.
|
|
const MAX_DURATION_S = 30;
|
|
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
async function runTool(settings: Record<string, unknown>) {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "tiny.mp3", contentType: "audio/mpeg", content: MP3 },
|
|
{ name: "settings", content: JSON.stringify(settings) },
|
|
]);
|
|
return testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/audio/ringtone-maker",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
}
|
|
|
|
describe.skipIf(!ffmpegAvailable())("ringtone-maker (requires ffmpeg)", () => {
|
|
it("creates m4r ringtone with defaults and returns 200", async () => {
|
|
const res = await runTool({});
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
|
|
const dl = await testApp.app.inject({ method: "GET", url: envelope.downloadUrl });
|
|
expect(dl.statusCode).toBe(200);
|
|
expect(dl.rawPayload.length).toBeGreaterThan(200);
|
|
|
|
// Semantic oracle: the ringtone must be AAC audio and duration-capped. A bad
|
|
// encode (wrong codec, or no `-t` cap so a long input passes through) still
|
|
// returns valid magic bytes, so probe the real container instead.
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "ringtone-test-"));
|
|
try {
|
|
const outPath = join(tmpDir, "ringtone.m4r");
|
|
writeFileSync(outPath, dl.rawPayload);
|
|
const info = await probeMedia(outPath);
|
|
const audio = info.streams.find((s) => s.type === "audio");
|
|
expect(audio).toBeDefined();
|
|
expect(audio?.codec).toBe("aac");
|
|
// Ringtones are duration-capped at the configured maximum length.
|
|
expect(info.durationS).not.toBeNull();
|
|
expect(info.durationS ?? Number.POSITIVE_INFINITY).toBeLessThanOrEqual(MAX_DURATION_S);
|
|
} finally {
|
|
rmSync(tmpDir, { recursive: true, force: true });
|
|
}
|
|
}, 60_000);
|
|
|
|
it("rejects startS beyond audio duration (422)", async () => {
|
|
const res = await runTool({ startS: 5 });
|
|
expect(res.statusCode).toBe(422);
|
|
expect(res.body).toMatch(/beyond the end/i);
|
|
}, 60_000);
|
|
|
|
it("normalizes sub-microsecond offsets instead of emitting exponential ffmpeg syntax", async () => {
|
|
const res = await runTool({ startS: Number.MIN_VALUE, durationS: 1 });
|
|
expect(res.statusCode).toBe(200);
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
}, 60_000);
|
|
});
|