Files
SnapOtter/tests/unit/ai/bridge-python-path.test.ts
T
SnapOtterandGitHub d10d0f544f fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
2026-07-27 15:37:30 +08:00

114 lines
3.6 KiB
TypeScript

import type { ChildProcess } from "node:child_process";
import { spawn } from "node:child_process";
import { EventEmitter } from "node:events";
import { existsSync } from "node:fs";
import { Writable } from "node:stream";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
vi.mock("node:child_process", () => ({
spawn: vi.fn(),
}));
vi.mock("node:fs", async (importOriginal) => {
const actual = await importOriginal<typeof import("node:fs")>();
return {
...actual,
existsSync: vi.fn(),
};
});
const ORIGINAL_PLATFORM = Object.getOwnPropertyDescriptor(process, "platform");
const ORIGINAL_VENV_PATH = process.env.PYTHON_VENV_PATH;
function setPlatform(platform: NodeJS.Platform): void {
Object.defineProperty(process, "platform", { configurable: true, value: platform });
}
function createMockProcess(): {
process: ChildProcess;
stderr: EventEmitter;
} {
const stdin = new Writable({
write(_chunk, _encoding, callback) {
callback();
},
});
const stdout = new EventEmitter();
const stderr = new EventEmitter();
const process = new EventEmitter() as unknown as ChildProcess;
Object.assign(process, {
stdin,
stdout,
stderr,
pid: 12345,
killed: false,
kill: vi.fn(() => true),
});
return { process, stderr };
}
async function dispatcherExecutable(): Promise<string> {
const child = createMockProcess();
vi.mocked(spawn).mockReturnValue(child.process);
const { PythonDispatcher } = await import("../../../packages/ai/src/bridge.js");
const dispatcher = new PythonDispatcher({ profile: "docs" });
const initialized = dispatcher.init(500);
child.stderr.emit("data", Buffer.from('{"ready":true,"gpu":false}\n'));
await expect(initialized).resolves.toEqual({ ready: true, gpu: false });
const executable = vi.mocked(spawn).mock.calls[0]?.[0];
dispatcher.shutdown();
expect(typeof executable).toBe("string");
return executable as string;
}
describe("bridge Python interpreter selection", () => {
beforeEach(() => {
vi.resetModules();
vi.mocked(spawn).mockReset();
vi.mocked(existsSync).mockReset();
delete process.env.PYTHON_VENV_PATH;
});
afterEach(() => {
if (ORIGINAL_PLATFORM) Object.defineProperty(process, "platform", ORIGINAL_PLATFORM);
if (ORIGINAL_VENV_PATH === undefined) delete process.env.PYTHON_VENV_PATH;
else process.env.PYTHON_VENV_PATH = ORIGINAL_VENV_PATH;
});
it("selects an existing Unix venv interpreter", async () => {
setPlatform("linux");
process.env.PYTHON_VENV_PATH = "/custom/venv";
vi.mocked(existsSync).mockImplementation((path) => path === "/custom/venv/bin/python3");
await expect(dispatcherExecutable()).resolves.toBe("/custom/venv/bin/python3");
});
it("selects python3 directly when the Unix venv interpreter is missing", async () => {
setPlatform("linux");
process.env.PYTHON_VENV_PATH = "/missing/venv";
vi.mocked(existsSync).mockReturnValue(false);
await expect(dispatcherExecutable()).resolves.toBe("python3");
});
it("selects an existing Windows venv interpreter", async () => {
setPlatform("win32");
process.env.PYTHON_VENV_PATH = "C:\\custom\\venv";
vi.mocked(existsSync).mockImplementation(
(path) => path === "C:\\custom\\venv\\Scripts\\python.exe",
);
await expect(dispatcherExecutable()).resolves.toBe("C:\\custom\\venv\\Scripts\\python.exe");
});
it("selects python directly when the Windows venv interpreter is missing", async () => {
setPlatform("win32");
process.env.PYTHON_VENV_PATH = "C:\\missing\\venv";
vi.mocked(existsSync).mockReturnValue(false);
await expect(dispatcherExecutable()).resolves.toBe("python");
});
});