mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
14f6c09805
resolveOutputFormat handed every route a default quality of 95, and Sharp reads quality on PNG as palette quantisation, so every PNG through the factory-route family came back dithered and often bigger. quality is now optional and stays undefined for PNG unless a caller passes an explicit override; smart-crop's user-chosen quality still quantises on request. Two branches bypassed the resolver and carried their own copy of the bug, both fixed: image-pad hardcoded quality 95 for transparent padding, replace-color hardcoded quality 100 when forcing PNG for transparency. pixelate drops the local special case #709 added for the same bug. Four new integration oracles on >256-colour inputs, each watched failing against the old code. Fixes #710
58 lines
2.3 KiB
TypeScript
58 lines
2.3 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { resolveOutputFormat } from "../../../apps/api/src/lib/output-format.js";
|
|
import { fixtures, readFixture } from "../../fixtures/index.js";
|
|
|
|
const JPG = readFixture(fixtures.image.base.jpg100);
|
|
const PNG = readFixture(fixtures.image.base.png200);
|
|
const WEBP = readFixture(fixtures.image.base.webp50);
|
|
|
|
describe("resolveOutputFormat", () => {
|
|
it("detects JPEG input and returns jpeg config", async () => {
|
|
const result = await resolveOutputFormat(JPG, "photo.jpg");
|
|
expect(result.format).toBe("jpeg");
|
|
expect(result.extension).toBe("jpg");
|
|
expect(result.contentType).toBe("image/jpeg");
|
|
expect(result.quality).toBe(95);
|
|
});
|
|
|
|
it("detects PNG input and returns png config with no quality", async () => {
|
|
const result = await resolveOutputFormat(PNG, "image.png");
|
|
expect(result.format).toBe("png");
|
|
expect(result.extension).toBe("png");
|
|
expect(result.contentType).toBe("image/png");
|
|
// Sharp reads `quality` on PNG as "quantise to a palette", so a default
|
|
// quality silently dithered every PNG that passed through (issue #710).
|
|
// Only an explicit override may request that.
|
|
expect(result.quality).toBeUndefined();
|
|
});
|
|
|
|
it("detects WebP input and returns webp config", async () => {
|
|
const result = await resolveOutputFormat(WEBP, "image.webp");
|
|
expect(result.format).toBe("webp");
|
|
expect(result.extension).toBe("webp");
|
|
expect(result.contentType).toBe("image/webp");
|
|
expect(result.quality).toBe(95);
|
|
});
|
|
|
|
it("falls back to PNG for unknown format", async () => {
|
|
const garbage = Buffer.from("not an image at all");
|
|
const result = await resolveOutputFormat(garbage, "mystery.bin");
|
|
expect(result.format).toBe("png");
|
|
expect(result.extension).toBe("png");
|
|
expect(result.contentType).toBe("image/png");
|
|
// The fallback produces PNG too, so it gets the same lossless treatment.
|
|
expect(result.quality).toBeUndefined();
|
|
});
|
|
|
|
it("respects quality override for lossy formats", async () => {
|
|
const result = await resolveOutputFormat(JPG, "photo.jpg", 50);
|
|
expect(result.quality).toBe(50);
|
|
});
|
|
|
|
it("accepts quality override for PNG without error", async () => {
|
|
const result = await resolveOutputFormat(PNG, "image.png", 50);
|
|
expect(result.format).toBe("png");
|
|
expect(result.quality).toBe(50);
|
|
});
|
|
});
|