mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
6e3a14ec6b
* fix: remove all automatic third-party egress (OSM tiles, Scalar fonts, editor Google Fonts, AI model download fallbacks) Phone-home audit follow-up. The product no longer makes any automatic third-party request; user-initiated click-outs stay, and production now fails closed on missing AI models. 1. GPS leak via OSM tiles: the strip-metadata panel auto-loaded tile.openstreetmap.org tiles encoding the photo's GPS position. The Leaflet mini-map is gone; coordinates render as text plus an explicit View on map link (openstreetmap.org, opens on click only). Removed tile.openstreetmap.org from the CSP img-src, dropped the leaflet dependency, added the viewOnMap i18n key to all 21 locales. 2. Scalar docs fonts: /api/docs loaded Inter and JetBrains Mono from fonts.scalar.com. Scalar now renders with withDefaultFonts: false and both --scalar-font and --scalar-font-code pinned to system stacks; fonts.scalar.com removed from the docs CSP font-src. Verified by injecting GET /api/docs/: config carries withDefaultFonts false and the served page has no fonts.scalar.com reference. 3. Editor Google Fonts: the editor font picker built fonts.googleapis.com stylesheet URLs for 25 web fonts the served CSP already blocked. The remote loading path is deleted; the picker now offers system fonts only, with a SELF_HOSTED_FONTS seam (FontFace API, same origin) for bundling fonts later. Unknown families saved in old documents fall back to the browser default. 4. Python sidecar fails closed on model downloads: new packages/ai/python/offline_guard.py gates every runtime download fallback (inpaint, outpaint, restore, noise_removal, detect_faces, enhance_faces, face_landmarks, red_eye_removal, remove_bg, ocr, transcribe, upscale) behind SNAPOTTER_ALLOW_MODEL_DOWNLOAD=1 with an actionable error. Bundled models keep working untouched. 5. OCR and transcription library-internal downloads: unbundled PaddleOCR language and detection fallbacks now raise the guard error naming the language instead of resolving models over the network; faster-whisper gets local_files_only when downloads are off. 6. GFPGAN and CodeFormer cwd-relative weights: facexlib and codeformer-pip resolve helper weights relative to the process cwd and fetch them from GitHub when absent. They are now symlinked from the installed bundle files under MODELS_PATH/gfpgan/facelib before the libraries load, failing closed when unresolvable. Defense in depth: HF_HUB_OFFLINE=1 and TRANSFORMERS_OFFLINE=1 are set in the runtime image and in the sidecar spawn env; install_feature.py lifts them for user-initiated bundle installs and restores them afterwards (it can run in-process inside the dispatcher). SNAPOTTER_ALLOW_MODEL_DOWNLOAD is documented in .env.example, default off. Validation: typecheck 9/9 workspaces, Biome clean on touched files, 5178 unit tests pass, py_compile on all touched scripts, guard behavior exercised in both dispatcher exec and per-request import modes, zero remaining runtime references to the three hosts. Docker build and live AI inference need post-merge verification on the GPU host. Claude-Session: https://claude.ai/code/session_01XGB4pGvTvb7sUX4JN745U7 * fix: allow AI model downloads by default, make strict offline mode opt-in Product call: ease of use first. The download gating from the previous commit inverts its default: runtime model fetches (public model weights only, never user data) are allowed out of the box so AI tools self-heal, and SNAPOTTER_ALLOW_MODEL_DOWNLOAD=0 becomes the explicit strict offline mode for airgapped deployments, where every fallback raises the actionable error instead of fetching. Changes: offline_guard blocks only on an explicit 0/false; the unconditional HF_HUB_OFFLINE/TRANSFORMERS_OFFLINE image ENV is removed and bridge.ts sets those flags for the sidecar only in strict mode; .env.example documents the new default; install_feature's lift/restore stays. All bundled-path preferences, pre-existence checks, and symlink pre-placement remain, so installed bundles never trigger a download. The OSM, Scalar font, and editor font fixes are unchanged. Validation rerun: typecheck 9/9, Biome clean on touched files, 5178 unit tests pass, py_compile on touched scripts, guard behavior verified for unset/1 (allowed) and 0/false (blocked with the new message). Claude-Session: https://claude.ai/code/session_01XGB4pGvTvb7sUX4JN745U7
77 lines
3.0 KiB
TypeScript
77 lines
3.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { buildCsp } from "../../../apps/api/src/lib/csp.js";
|
|
|
|
function parseDirective(csp: string, directive: string): string[] {
|
|
const match = csp.match(new RegExp(`${directive}\\s+([^;]+)`));
|
|
return match ? match[1].trim().split(/\s+/) : [];
|
|
}
|
|
|
|
describe("buildCsp", () => {
|
|
describe("connect-src allows analytics domains", () => {
|
|
it.each([true, false])("includes PostHog ingest (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "connect-src");
|
|
expect(sources).toContain("https://us.i.posthog.com");
|
|
});
|
|
|
|
it.each([true, false])("includes PostHog assets (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "connect-src");
|
|
expect(sources).toContain("https://us-assets.i.posthog.com");
|
|
});
|
|
|
|
it.each([true, false])("includes Sentry ingest (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "connect-src");
|
|
expect(sources).toContain("https://*.ingest.us.sentry.io");
|
|
});
|
|
|
|
it.each([true, false])("keeps self (isDocs=%s)", (isDocs) => {
|
|
expect(parseDirective(buildCsp(isDocs), "connect-src")).toContain("'self'");
|
|
});
|
|
});
|
|
|
|
describe("script-src allows PostHog config loader", () => {
|
|
it.each([true, false])("includes PostHog assets origin (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "script-src");
|
|
expect(sources).toContain("https://us-assets.i.posthog.com");
|
|
});
|
|
|
|
it("docs pages allow unsafe-inline for Scalar", () => {
|
|
expect(parseDirective(buildCsp(true), "script-src")).toContain("'unsafe-inline'");
|
|
});
|
|
|
|
it("app pages do not allow unsafe-inline", () => {
|
|
expect(parseDirective(buildCsp(false), "script-src")).not.toContain("'unsafe-inline'");
|
|
});
|
|
});
|
|
|
|
describe("font-src is self-hosted only", () => {
|
|
it.each([true, false])("does not include the Scalar fonts origin (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "font-src");
|
|
expect(sources).not.toContain("https://fonts.scalar.com");
|
|
});
|
|
|
|
it.each([true, false])("keeps self and data: (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "font-src");
|
|
expect(sources).toContain("'self'");
|
|
expect(sources).toContain("data:");
|
|
});
|
|
});
|
|
|
|
it("includes frame-ancestors none for app pages but not docs", () => {
|
|
expect(buildCsp(false)).toContain("frame-ancestors 'none'");
|
|
expect(buildCsp(true)).not.toContain("frame-ancestors");
|
|
});
|
|
|
|
it.each([true, false])("does not allow OpenStreetMap tiles in img-src (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "img-src");
|
|
expect(sources).not.toContain("https://tile.openstreetmap.org");
|
|
});
|
|
|
|
it.each([
|
|
true,
|
|
false,
|
|
])("connect-src allows data: URIs for client-side blob operations (isDocs=%s)", (isDocs) => {
|
|
const sources = parseDirective(buildCsp(isDocs), "connect-src");
|
|
expect(sources).toContain("data:");
|
|
});
|
|
});
|