mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
286 lines
9.0 KiB
TypeScript
286 lines
9.0 KiB
TypeScript
/**
|
|
* Integration tests for the background-replace tool (/api/v1/tools/image/background-replace).
|
|
*
|
|
* This tool reuses the rembg bundle (background-removal). Missing-bundle
|
|
* contracts run only when that capability is absent; installed happy paths run
|
|
* when it is detected or REQUIRE_AI_FEATURES makes absence a release failure.
|
|
*
|
|
* The compositeOnColor helper has dedicated unit coverage in
|
|
* tests/unit/api/background-composite.test.ts.
|
|
*/
|
|
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { isToolInstalled } from "../../../../apps/api/src/lib/feature-status.js";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import { installedAiCapabilityGate } from "../../../helpers/installed-ai-capability-gate.js";
|
|
import {
|
|
expectConfiguredBackground,
|
|
expectForegroundPreserved,
|
|
expectObservablePixelChange,
|
|
} from "../../../helpers/installed-ai-output-oracles.js";
|
|
import { waitForDownloadedJobArtifact } from "../../settle-job.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
const PNG = readFixture(fixtures.image.base.png200);
|
|
const PORTRAIT = readFixture(fixtures.image.portrait.jpg);
|
|
const REQUIRE_AI_FEATURES = process.env.REQUIRE_AI_FEATURES === "1";
|
|
const AI_CAPABILITY = installedAiCapabilityGate(
|
|
"background-replace",
|
|
REQUIRE_AI_FEATURES,
|
|
isToolInstalled,
|
|
);
|
|
|
|
let testApp: TestApp;
|
|
let app: TestApp["app"];
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
app = testApp.app;
|
|
adminToken = await loginAsAdmin(app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
describe("background-replace", () => {
|
|
// -- Missing-capability contract --
|
|
|
|
it.skipIf(!AI_CAPABILITY.runUnavailableContract)(
|
|
"returns 501 FEATURE_NOT_INSTALLED when bundle is absent",
|
|
async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG },
|
|
{ name: "settings", content: JSON.stringify({}) },
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(501);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.code).toBe("FEATURE_NOT_INSTALLED");
|
|
expect(json.feature).toBe("background-removal");
|
|
expect(json.featureName).toBe("Background Removal");
|
|
expect(json.estimatedSize).toBeDefined();
|
|
},
|
|
);
|
|
|
|
// -- Auth gate --
|
|
|
|
it("rejects unauthenticated requests (401)", async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG },
|
|
{ name: "settings", content: JSON.stringify({}) },
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: { "content-type": contentType },
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(401);
|
|
});
|
|
|
|
// -- Validation: 501 fires before settings parse, so bad hex also 501s --
|
|
|
|
it.skipIf(!AI_CAPABILITY.runUnavailableContract)(
|
|
"returns 501 even with invalid color hex (gate fires first)",
|
|
async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG },
|
|
{ name: "settings", content: JSON.stringify({ color: "not-a-hex" }) },
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
// 501 because the bundle gate fires before settings validation
|
|
expect(res.statusCode).toBe(501);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.code).toBe("FEATURE_NOT_INSTALLED");
|
|
},
|
|
);
|
|
|
|
it.skipIf(!AI_CAPABILITY.runUnavailableContract)(
|
|
"returns 501 with gradient settings (gate fires first)",
|
|
async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG },
|
|
{
|
|
name: "settings",
|
|
content: JSON.stringify({
|
|
backgroundType: "gradient",
|
|
gradientColor1: "#ff0000",
|
|
gradientColor2: "#0000ff",
|
|
gradientAngle: 90,
|
|
}),
|
|
},
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(501);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.code).toBe("FEATURE_NOT_INSTALLED");
|
|
},
|
|
);
|
|
|
|
it.skipIf(!AI_CAPABILITY.runUnavailableContract)(
|
|
"returns 501 with feather and webp format (gate fires first)",
|
|
async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG },
|
|
{
|
|
name: "settings",
|
|
content: JSON.stringify({
|
|
backgroundType: "color",
|
|
color: "#00ff00",
|
|
feather: 5,
|
|
format: "webp",
|
|
}),
|
|
},
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(501);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.code).toBe("FEATURE_NOT_INSTALLED");
|
|
},
|
|
);
|
|
|
|
// -- Installed/required capability contract --
|
|
|
|
describe.skipIf(!AI_CAPABILITY.runInstalledContract)(
|
|
"with background-removal bundle installed",
|
|
() => {
|
|
it("replaces background with color (202 + async)", async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{
|
|
name: "file",
|
|
filename: "portrait-color.jpg",
|
|
contentType: "image/jpeg",
|
|
content: PORTRAIT,
|
|
},
|
|
{ name: "settings", content: JSON.stringify({ color: "#ff0000" }) },
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(202);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.jobId).toBeDefined();
|
|
expect(json.async).toBe(true);
|
|
const artifact = await waitForDownloadedJobArtifact(
|
|
app,
|
|
adminToken,
|
|
"background-replace",
|
|
json.jobId as string,
|
|
240_000,
|
|
);
|
|
expect(artifact.filename).toBe("portrait-color_bg.png");
|
|
expect(artifact.contentType).toBe("image/png");
|
|
await expectObservablePixelChange(PORTRAIT, artifact.buffer);
|
|
await expectConfiguredBackground(artifact.buffer, "solid-red");
|
|
await expectForegroundPreserved(PORTRAIT, artifact.buffer);
|
|
}, 300_000);
|
|
|
|
it("replaces background with gradient (202 + async)", async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{
|
|
name: "file",
|
|
filename: "portrait-color.jpg",
|
|
contentType: "image/jpeg",
|
|
content: PORTRAIT,
|
|
},
|
|
{
|
|
name: "settings",
|
|
content: JSON.stringify({
|
|
backgroundType: "gradient",
|
|
gradientColor1: "#ff0000",
|
|
gradientColor2: "#0000ff",
|
|
gradientAngle: 45,
|
|
feather: 3,
|
|
format: "webp",
|
|
}),
|
|
},
|
|
]);
|
|
|
|
const res = await app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/image/background-replace",
|
|
headers: {
|
|
authorization: `Bearer ${adminToken}`,
|
|
"content-type": contentType,
|
|
},
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(202);
|
|
const json = JSON.parse(res.body);
|
|
expect(json.jobId).toBeDefined();
|
|
expect(json.async).toBe(true);
|
|
const artifact = await waitForDownloadedJobArtifact(
|
|
app,
|
|
adminToken,
|
|
"background-replace",
|
|
json.jobId as string,
|
|
240_000,
|
|
);
|
|
expect(artifact.filename).toBe("portrait-color_bg.webp");
|
|
expect(artifact.contentType).toBe("image/webp");
|
|
await expectObservablePixelChange(PORTRAIT, artifact.buffer);
|
|
await expectConfiguredBackground(artifact.buffer, "red-blue-gradient");
|
|
await expectForegroundPreserved(PORTRAIT, artifact.buffer);
|
|
}, 300_000);
|
|
},
|
|
);
|
|
});
|