mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
126 lines
4.6 KiB
TypeScript
126 lines
4.6 KiB
TypeScript
import { mkdtempSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { ffmpegAvailable, probeMedia } from "@snapotter/media-engine";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import { fixtures, readFixture } from "../../../fixtures/index.js";
|
|
import {
|
|
buildTestApp,
|
|
createMultipartPayload,
|
|
loginAsAdmin,
|
|
type TestApp,
|
|
} from "../../test-server.js";
|
|
|
|
const MP4 = readFixture(fixtures.video.tiny("mp4"));
|
|
|
|
let testApp: TestApp;
|
|
let adminToken: string;
|
|
|
|
beforeAll(async () => {
|
|
testApp = await buildTestApp();
|
|
adminToken = await loginAsAdmin(testApp.app);
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await testApp.cleanup();
|
|
}, 10_000);
|
|
|
|
/**
|
|
* Handles both the 200 sync-window path and the 202+poll path.
|
|
* merge-videos has executionHint "long", so expect 202 in most runs.
|
|
*/
|
|
async function resolveResult(res: Awaited<ReturnType<typeof testApp.app.inject>>): Promise<{
|
|
path: "sync" | "poll";
|
|
downloadPayload: Buffer;
|
|
}> {
|
|
if (res.statusCode === 200) {
|
|
const envelope = JSON.parse(res.body);
|
|
expect(envelope.downloadUrl).toBeDefined();
|
|
const dl = await testApp.app.inject({ method: "GET", url: envelope.downloadUrl });
|
|
expect(dl.statusCode).toBe(200);
|
|
return { path: "sync", downloadPayload: dl.rawPayload };
|
|
}
|
|
|
|
expect(res.statusCode).toBe(202);
|
|
const { jobId } = JSON.parse(res.body);
|
|
expect(jobId).toBeDefined();
|
|
|
|
const { db, schema } = await import("../../../../apps/api/src/db/index.js");
|
|
const { eq } = await import("drizzle-orm");
|
|
let row: { status: string; outputRefs: unknown } | undefined;
|
|
for (let i = 0; i < 120; i++) {
|
|
[row] = await db.select().from(schema.jobs).where(eq(schema.jobs.id, jobId));
|
|
if (row && ["completed", "failed", "canceled"].includes(row.status)) break;
|
|
await new Promise((r) => setTimeout(r, 500));
|
|
}
|
|
expect(row?.status).toBe("completed");
|
|
if (!Array.isArray(row?.outputRefs) || typeof row.outputRefs[0] !== "string") {
|
|
throw new Error("Completed merge-videos job has no output reference");
|
|
}
|
|
const outName = row.outputRefs[0].split("/").pop() as string;
|
|
const dl = await testApp.app.inject({
|
|
method: "GET",
|
|
url: `/api/v1/download/${jobId}/${encodeURIComponent(outName)}`,
|
|
});
|
|
expect(dl.statusCode).toBe(200);
|
|
return { path: "poll", downloadPayload: dl.rawPayload };
|
|
}
|
|
|
|
describe.skipIf(!ffmpegAvailable())("merge-videos (requires ffmpeg)", () => {
|
|
it("merges two copies of tiny.mp4 into a single video", async () => {
|
|
// Send TWO file parts named "file" (the multi-input path)
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "a.mp4", contentType: "video/mp4", content: MP4 },
|
|
{ name: "file", filename: "b.mp4", contentType: "video/mp4", content: MP4 },
|
|
{ name: "settings", content: JSON.stringify({}) },
|
|
]);
|
|
const res = await testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/video/merge-videos",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
|
|
const { path, downloadPayload } = await resolveResult(res);
|
|
expect(downloadPayload.length).toBeGreaterThan(100);
|
|
|
|
// Probe the merged output: duration should be roughly 2x the source
|
|
const tmpDir = mkdtempSync(join(tmpdir(), "merge-test-"));
|
|
const probeFile = join(tmpDir, "merged.mp4");
|
|
writeFileSync(probeFile, downloadPayload);
|
|
const info = await probeMedia(probeFile);
|
|
|
|
// Probe the source for comparison
|
|
const srcFile = join(tmpDir, "src.mp4");
|
|
writeFileSync(srcFile, MP4);
|
|
const srcInfo = await probeMedia(srcFile);
|
|
const srcDuration = srcInfo.durationS ?? 0;
|
|
|
|
expect(info.durationS).not.toBeNull();
|
|
const merged = info.durationS as number;
|
|
// Within 30% tolerance of 2x source
|
|
expect(merged).toBeGreaterThan(srcDuration * 2 * 0.7);
|
|
expect(merged).toBeLessThan(srcDuration * 2 * 1.3);
|
|
|
|
// Record which path was taken for the report
|
|
// eslint-disable-next-line no-console
|
|
console.log(`merge-videos happy path: ${path}`);
|
|
}, 120_000);
|
|
|
|
it("rejects a single file", async () => {
|
|
const { body, contentType } = createMultipartPayload([
|
|
{ name: "file", filename: "only.mp4", contentType: "video/mp4", content: MP4 },
|
|
{ name: "settings", content: JSON.stringify({}) },
|
|
]);
|
|
const res = await testApp.app.inject({
|
|
method: "POST",
|
|
url: "/api/v1/tools/video/merge-videos",
|
|
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
|
|
body,
|
|
});
|
|
|
|
expect(res.statusCode).toBe(400);
|
|
expect(JSON.parse(res.body).error).toMatch(/at least 2 files/i);
|
|
}, 60_000);
|
|
});
|