mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
173 lines
5.4 KiB
TypeScript
173 lines
5.4 KiB
TypeScript
import { EventEmitter } from "node:events";
|
|
import { describe, expect, test } from "vitest";
|
|
import { runPlaywrightApiLifecycle } from "../playwright-api-lifecycle.mjs";
|
|
import {
|
|
resolvePlaywrightBackingState,
|
|
teardownPlaywrightBackingState,
|
|
} from "../playwright-backing-state.mjs";
|
|
|
|
const POSTGRES_BASE_URL = "postgres://snapotter:snapotter@127.0.0.1:5432/snapotter";
|
|
const REDIS_URL = "redis://127.0.0.1:6379/0";
|
|
|
|
function deferred<T>() {
|
|
let resolve!: (value: T) => void;
|
|
const promise = new Promise<T>((settle) => {
|
|
resolve = settle;
|
|
});
|
|
return { promise, resolve };
|
|
}
|
|
|
|
async function waitFor(predicate: () => boolean) {
|
|
for (let attempt = 0; attempt < 50; attempt += 1) {
|
|
if (predicate()) return;
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
}
|
|
throw new Error("condition was not reached");
|
|
}
|
|
|
|
function harness(runId: string) {
|
|
const state = resolvePlaywrightBackingState({
|
|
postgresBaseUrl: POSTGRES_BASE_URL,
|
|
redisUrl: REDIS_URL,
|
|
runId,
|
|
scope: "main",
|
|
});
|
|
const sibling = resolvePlaywrightBackingState({
|
|
postgresBaseUrl: POSTGRES_BASE_URL,
|
|
redisUrl: REDIS_URL,
|
|
runId: `${runId}_sibling`,
|
|
scope: "main",
|
|
});
|
|
const databases = new Set(["snapotter"]);
|
|
const redisKeys = new Set(["unrelated:key"]);
|
|
const events: string[] = [];
|
|
const childExit = deferred<{ code: number | null; signal: NodeJS.Signals | null }>();
|
|
const signals = new EventEmitter();
|
|
|
|
return {
|
|
childExit,
|
|
databases,
|
|
events,
|
|
redisKeys,
|
|
sibling,
|
|
signals,
|
|
state,
|
|
options: {
|
|
async createDatabase() {
|
|
databases.add(state.databaseName);
|
|
databases.add(sibling.databaseName);
|
|
redisKeys.add(`${state.bullmqPrefix}:terminal:owned-job`);
|
|
redisKeys.add(`bull:${state.bullmqPrefix}-media:owned-job`);
|
|
redisKeys.add(`${sibling.bullmqPrefix}:terminal:sibling-job`);
|
|
redisKeys.add(`foreign:${state.bullmqPrefix}:embedded-substring`);
|
|
events.push("created");
|
|
},
|
|
signalSource: signals,
|
|
startApi() {
|
|
events.push("started");
|
|
return {
|
|
completion: childExit.promise.then((result) => {
|
|
events.push("child-exit");
|
|
return result;
|
|
}),
|
|
stop(signal: NodeJS.Signals) {
|
|
events.push(`stop:${signal}`);
|
|
childExit.resolve({ code: null, signal });
|
|
},
|
|
};
|
|
},
|
|
async teardown() {
|
|
await teardownPlaywrightBackingState(state, {
|
|
async deleteRedisKeys(_ownedState, ownsKey) {
|
|
let deleted = 0;
|
|
for (const key of [...redisKeys]) {
|
|
if (!ownsKey(key)) continue;
|
|
redisKeys.delete(key);
|
|
deleted += 1;
|
|
}
|
|
return deleted;
|
|
},
|
|
async dropDatabase(ownedState) {
|
|
databases.delete(ownedState.databaseName);
|
|
},
|
|
});
|
|
events.push("teardown");
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
function expectOnlyForeignStateRemains(context: ReturnType<typeof harness>) {
|
|
expect(context.databases).toEqual(new Set(["snapotter", context.sibling.databaseName]));
|
|
expect(context.redisKeys).toEqual(
|
|
new Set([
|
|
"unrelated:key",
|
|
`${context.sibling.bullmqPrefix}:terminal:sibling-job`,
|
|
`foreign:${context.state.bullmqPrefix}:embedded-substring`,
|
|
]),
|
|
);
|
|
}
|
|
|
|
describe("Playwright API backing-state lifecycle", () => {
|
|
test("tears down exact run-owned state after a successful API exit", async () => {
|
|
const context = harness("lifecycle_success");
|
|
const running = runPlaywrightApiLifecycle(context.options);
|
|
|
|
await waitFor(() => context.events.includes("started"));
|
|
expect(context.databases).toContain(context.state.databaseName);
|
|
context.childExit.resolve({ code: 0, signal: null });
|
|
|
|
await expect(running).resolves.toBe(0);
|
|
expect(context.events).toEqual(["created", "started", "child-exit", "teardown"]);
|
|
expectOnlyForeignStateRemains(context);
|
|
});
|
|
|
|
test("tears down exact run-owned state after a failing API exit", async () => {
|
|
const context = harness("lifecycle_failure");
|
|
const running = runPlaywrightApiLifecycle(context.options);
|
|
|
|
await waitFor(() => context.events.includes("started"));
|
|
context.childExit.resolve({ code: 7, signal: null });
|
|
|
|
await expect(running).resolves.toBe(7);
|
|
expect(context.events.at(-1)).toBe("teardown");
|
|
expectOnlyForeignStateRemains(context);
|
|
});
|
|
|
|
test("stops the API before exact teardown when Playwright interrupts the wrapper", async () => {
|
|
const context = harness("lifecycle_interrupted");
|
|
const running = runPlaywrightApiLifecycle(context.options);
|
|
|
|
await waitFor(() => context.events.includes("started"));
|
|
context.signals.emit("SIGTERM");
|
|
|
|
await expect(running).resolves.toBe(143);
|
|
expect(context.events).toEqual([
|
|
"created",
|
|
"started",
|
|
"stop:SIGTERM",
|
|
"child-exit",
|
|
"teardown",
|
|
]);
|
|
expectOnlyForeignStateRemains(context);
|
|
});
|
|
|
|
test("attempts exact teardown when API startup throws", async () => {
|
|
const context = harness("lifecycle_startup_failure");
|
|
const startupError = new Error("spawn failed");
|
|
|
|
await expect(
|
|
runPlaywrightApiLifecycle({
|
|
...context.options,
|
|
startApi() {
|
|
context.events.push("start-failed");
|
|
throw startupError;
|
|
},
|
|
}),
|
|
).rejects.toBe(startupError);
|
|
|
|
expect(context.events).toEqual(["created", "start-failed", "teardown"]);
|
|
expectOnlyForeignStateRemains(context);
|
|
});
|
|
});
|