mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
Defers the onboarding usage survey to the instance's first successful processing (the worker writes a one-time onboarding.firstProcessedAt marker and the overlay gates on it), so it reaches engaged users instead of first-landing visitors. Replaces the two questions telemetry already answers (modality preference from tool_used, install method from instance_started) with what it can't infer: prior tool, self-host motivation, and discovery source. Adds feedback_prompt_shown and feedback_prompt_dismissed on all five feedback surfaces (usage survey, per-job prompt, admin install card, global nav dialog, search-miss) so skip and completion rates are measurable, not just submissions. New survey strings translated into all 20 non-English locales.
275 lines
10 KiB
TypeScript
275 lines
10 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import "@testing-library/jest-dom/vitest";
|
|
import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const submitFeedback = vi.hoisted(() => vi.fn().mockResolvedValue({ ok: true, accepted: true }));
|
|
const trackFeedbackPromptShown = vi.hoisted(() => vi.fn());
|
|
const trackFeedbackPromptDismissed = vi.hoisted(() => vi.fn());
|
|
const apiGet = vi.hoisted(() => vi.fn());
|
|
const apiPut = vi.hoisted(() => vi.fn().mockResolvedValue({}));
|
|
const useAuth = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/lib/feedback", async (importOriginal) => {
|
|
const actual: Record<string, unknown> = await importOriginal();
|
|
return { ...actual, submitFeedback, trackFeedbackPromptShown, trackFeedbackPromptDismissed };
|
|
});
|
|
|
|
vi.mock("@/lib/api", async (importOriginal) => {
|
|
const actual: Record<string, unknown> = await importOriginal();
|
|
return { ...actual, apiGet, apiPut };
|
|
});
|
|
|
|
vi.mock("@/hooks/use-auth", () => ({ useAuth }));
|
|
|
|
vi.mock("@/stores/analytics-store", () => ({
|
|
useAnalyticsStore: (
|
|
selector: (state: { config: { enabled: boolean }; configLoaded: boolean }) => unknown,
|
|
) => selector({ config: { enabled: true }, configLoaded: true }),
|
|
}));
|
|
|
|
import { UsageSurveyOverlay } from "@/components/onboarding/usage-survey-overlay";
|
|
|
|
// The worker writes this marker on the instance's first successful processing.
|
|
// The survey is only eligible once it exists; without it the overlay stays hidden.
|
|
const PROCESSED = { "onboarding.firstProcessedAt": "2026-01-01T00:00:00Z" };
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
submitFeedback.mockClear();
|
|
trackFeedbackPromptShown.mockClear();
|
|
trackFeedbackPromptDismissed.mockClear();
|
|
apiGet.mockClear();
|
|
apiPut.mockClear();
|
|
useAuth.mockReset();
|
|
});
|
|
|
|
function renderOverlay(initialPath = "/") {
|
|
return render(
|
|
<MemoryRouter initialEntries={[initialPath]}>
|
|
<UsageSurveyOverlay />
|
|
</MemoryRouter>,
|
|
);
|
|
}
|
|
|
|
describe("UsageSurveyOverlay", () => {
|
|
it("renders nothing for a non-admin", () => {
|
|
useAuth.mockReturnValue({ role: "user", mustChangePassword: false });
|
|
|
|
renderOverlay();
|
|
|
|
expect(apiGet).not.toHaveBeenCalled();
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
});
|
|
|
|
it("stays hidden until the instance's first processing has completed", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: {} });
|
|
|
|
renderOverlay();
|
|
|
|
await waitFor(() => expect(apiGet).toHaveBeenCalled());
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
expect(trackFeedbackPromptShown).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders nothing once already answered or dismissed", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({
|
|
settings: { ...PROCESSED, "onboarding.usageSurvey.dismissedAt": "2026-01-01T00:00:00Z" },
|
|
});
|
|
|
|
renderOverlay();
|
|
|
|
await waitFor(() => expect(apiGet).toHaveBeenCalled());
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
});
|
|
|
|
it("shows the telemetry-blind questions after processing and emits a shown event", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay();
|
|
|
|
expect(await screen.findByText("How are you using SnapOtter?")).toBeDefined();
|
|
expect(screen.getByText("What were you using before?")).toBeDefined();
|
|
expect(screen.getByText("Why self-host it?")).toBeDefined();
|
|
expect(screen.getByRole("radio", { name: /Just me/ })).toBeDefined();
|
|
expect(screen.getByRole("button", { name: "Continue" })).toBeDisabled();
|
|
await waitFor(() => expect(trackFeedbackPromptShown).toHaveBeenCalledWith("onboarding"));
|
|
});
|
|
|
|
it("submits only the usage type when nothing else is picked", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
fireEvent.click(screen.getByRole("radio", { name: /Small team/ }));
|
|
fireEvent.click(screen.getByRole("button", { name: "Continue" }));
|
|
|
|
await waitFor(() => {
|
|
expect(submitFeedback).toHaveBeenCalledWith({
|
|
source: "onboarding",
|
|
surveyId: "onboarding-usage-v1",
|
|
promptVariant: "onboarding-overlay-v1",
|
|
usageType: "team_internal",
|
|
});
|
|
});
|
|
expect(apiPut).toHaveBeenCalledWith("/v1/settings", {
|
|
"onboarding.usageSurvey.answeredAt": expect.any(String),
|
|
});
|
|
});
|
|
|
|
it("includes prior tool, motivation, and discovery source when the admin selects them", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
fireEvent.click(screen.getByRole("radio", { name: /Just me/ }));
|
|
fireEvent.click(screen.getByRole("radio", { name: /Command line/ }));
|
|
fireEvent.click(screen.getByRole("radio", { name: /Privacy and data control/ }));
|
|
fireEvent.change(screen.getByLabelText(/How did you hear about us/), {
|
|
target: { value: "github" },
|
|
});
|
|
fireEvent.click(screen.getByRole("button", { name: "Continue" }));
|
|
|
|
await waitFor(() => {
|
|
expect(submitFeedback).toHaveBeenCalledWith({
|
|
source: "onboarding",
|
|
surveyId: "onboarding-usage-v1",
|
|
promptVariant: "onboarding-overlay-v1",
|
|
usageType: "personal",
|
|
priorTool: "command_line",
|
|
selfHostMotivation: "privacy_control",
|
|
discoverySource: "github",
|
|
});
|
|
});
|
|
});
|
|
|
|
it("dismissing writes the dismiss key, emits a dismissed event, and does not submit", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Don't ask again" }));
|
|
|
|
await waitFor(() => {
|
|
expect(apiPut).toHaveBeenCalledWith("/v1/settings", {
|
|
"onboarding.usageSurvey.dismissedAt": expect.any(String),
|
|
});
|
|
});
|
|
expect(trackFeedbackPromptDismissed).toHaveBeenCalledWith("onboarding", "dont_ask_again");
|
|
expect(submitFeedback).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not resubmit feedback if only the settings write failed on the first attempt", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
apiPut.mockRejectedValueOnce(new Error("network error")).mockResolvedValueOnce({});
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
fireEvent.click(screen.getByRole("radio", { name: /Just me/ }));
|
|
fireEvent.click(screen.getByRole("button", { name: "Continue" }));
|
|
|
|
await waitFor(() => expect(apiPut).toHaveBeenCalledTimes(1));
|
|
expect(submitFeedback).toHaveBeenCalledTimes(1);
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Continue" }));
|
|
|
|
await waitFor(() => expect(apiPut).toHaveBeenCalledTimes(2));
|
|
expect(submitFeedback).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("stays visible and re-enables Continue if the feedback submission itself fails", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
submitFeedback.mockRejectedValueOnce(new Error("network error"));
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
fireEvent.click(screen.getByRole("radio", { name: /Just me/ }));
|
|
fireEvent.click(screen.getByRole("button", { name: "Continue" }));
|
|
|
|
await waitFor(() => expect(submitFeedback).toHaveBeenCalledTimes(1));
|
|
await waitFor(() =>
|
|
expect(screen.getByRole("button", { name: "Continue" })).not.toBeDisabled(),
|
|
);
|
|
|
|
expect(screen.getByText("How are you using SnapOtter?")).toBeDefined();
|
|
expect(apiPut).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("ignores a second dismiss click while the first write is in flight", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
let resolveApiPut: (() => void) | undefined;
|
|
apiPut.mockImplementationOnce(
|
|
() =>
|
|
new Promise((resolve) => {
|
|
resolveApiPut = () => resolve({});
|
|
}),
|
|
);
|
|
|
|
renderOverlay();
|
|
await screen.findByText("How are you using SnapOtter?");
|
|
|
|
const dismissButton = screen.getByRole("button", { name: "Don't ask again" });
|
|
fireEvent.click(dismissButton);
|
|
fireEvent.click(dismissButton);
|
|
fireEvent.click(dismissButton);
|
|
|
|
resolveApiPut?.();
|
|
|
|
await waitFor(() => {
|
|
expect(apiPut).toHaveBeenCalledWith("/v1/settings", {
|
|
"onboarding.usageSurvey.dismissedAt": expect.any(String),
|
|
});
|
|
});
|
|
expect(apiPut).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("renders nothing when the admin must still change their password", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: true });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay();
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
expect(apiGet).not.toHaveBeenCalled();
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
});
|
|
|
|
it("renders nothing on the change-password route even if mustChangePassword is stale-false", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay("/change-password");
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
expect(apiGet).not.toHaveBeenCalled();
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
});
|
|
|
|
it("renders nothing on the privacy policy route", async () => {
|
|
useAuth.mockReturnValue({ role: "admin", mustChangePassword: false });
|
|
apiGet.mockResolvedValue({ settings: PROCESSED });
|
|
|
|
renderOverlay("/privacy");
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
expect(apiGet).not.toHaveBeenCalled();
|
|
expect(screen.queryByText("How are you using SnapOtter?")).toBeNull();
|
|
});
|
|
});
|