mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
259 lines
12 KiB
TypeScript
259 lines
12 KiB
TypeScript
import { readdirSync } from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { defineConfig } from "vitest/config";
|
|
import { BaseSequencer } from "vitest/node";
|
|
import { partitionByCost } from "./tests/helpers/shard-partition.js";
|
|
|
|
// Resolve api-workspace packages that pnpm only exposes under apps/api/node_modules.
|
|
const apiNodeModules = path.resolve(__dirname, "apps/api/node_modules");
|
|
|
|
// Resolve web-workspace packages that pnpm only exposes under apps/web/node_modules.
|
|
const webNodeModules = path.resolve(__dirname, "apps/web/node_modules");
|
|
|
|
// Resolve landing-workspace packages.
|
|
const landingNodeModules = path.resolve(__dirname, "apps/landing/node_modules");
|
|
|
|
// @opentelemetry/core is a transitive dep (via sdk-node) not hoisted by pnpm.
|
|
// Find it in the pnpm store so tests can import W3CTraceContextPropagator.
|
|
function findPnpmPackage(scope: string, name: string): string {
|
|
const pnpmDir = path.resolve(__dirname, "node_modules/.pnpm");
|
|
const prefix = `${scope}+${name}@`;
|
|
const entries = readdirSync(pnpmDir)
|
|
.filter((e) => e.startsWith(prefix))
|
|
.sort();
|
|
if (entries.length === 0) {
|
|
throw new Error(`${scope}/${name} not found in pnpm store`);
|
|
}
|
|
return path.join(pnpmDir, entries[entries.length - 1], "node_modules", scope, name);
|
|
}
|
|
|
|
/**
|
|
* Shards by measured cost instead of by SHA1 of the file path.
|
|
*
|
|
* The stock BaseSequencer slices an equal number of FILES per shard, which took
|
|
* no account of the fact that four generated matrix specs carry most of the
|
|
* suite's runtime. See tests/helpers/shard-partition.ts for the measurements.
|
|
*
|
|
* `sort` is inherited untouched, and vitest only calls `shard` when --shard is
|
|
* passed, so unsharded runs (local, nightly full matrix) behave exactly as before.
|
|
*/
|
|
class CostAwareSequencer extends BaseSequencer {
|
|
async shard(specs: Parameters<BaseSequencer["shard"]>[0]) {
|
|
const shardConfig = this.ctx.config.shard;
|
|
if (!shardConfig) return specs;
|
|
|
|
const { index, count } = shardConfig;
|
|
const byModuleId = new Map(specs.map((spec) => [spec.moduleId, spec]));
|
|
const bin = partitionByCost([...byModuleId.keys()], count)[index - 1] ?? [];
|
|
|
|
return bin.map((moduleId) => byModuleId.get(moduleId)).filter((spec) => spec !== undefined);
|
|
}
|
|
}
|
|
|
|
export default defineConfig({
|
|
esbuild: {
|
|
jsx: "automatic",
|
|
},
|
|
test: {
|
|
globals: true,
|
|
// Env-overridable so the resource-constrained docker test image (where Sharp
|
|
// and FFmpeg run ~2-3x slower under the macOS Docker VM) can grant slow
|
|
// sync-wait jobs more headroom. Host/CI keep the 30s default.
|
|
testTimeout: Number(process.env.VITEST_TEST_TIMEOUT) || 30_000,
|
|
hookTimeout: Number(process.env.VITEST_HOOK_TIMEOUT) || 30_000,
|
|
pool: "forks",
|
|
poolOptions: {
|
|
forks: {
|
|
// Parallel forks; each fork gets an isolated DB + workspace via
|
|
// tests/setup/per-fork-env.ts. CI runners have 4 vCPUs. Env-overridable
|
|
// (VITEST_MAX_FORKS) so the heavy nightly jobs (FULL_MATRIX, coverage)
|
|
// can drop to fewer forks and give each slow media test more CPU, which
|
|
// keeps format-matrix conversions from starving and timing out.
|
|
maxForks:
|
|
Number(process.env.VITEST_MAX_FORKS) ||
|
|
(process.env.CI ? 4 : Math.max(2, Math.floor(os.availableParallelism() / 2))),
|
|
},
|
|
},
|
|
sequence: {
|
|
sequencer: CostAwareSequencer,
|
|
},
|
|
globalSetup: ["tests/global-setup.ts"],
|
|
setupFiles: ["tests/setup/per-fork-env.ts"],
|
|
exclude: [
|
|
"tests/e2e/**",
|
|
"tests/e2e-demo/**",
|
|
"tests/e2e-docs/**",
|
|
"tests/e2e-editor/**",
|
|
"tests/e2e-landing/**",
|
|
"tests/e2e-docker/**",
|
|
"tests/e2e-analytics/**",
|
|
"tests/e2e-noauth/**",
|
|
// tests/qa/* are Playwright QA-sweep specs (and .mts harnesses), not
|
|
// vitest tests; they import @playwright/test and break a bare `vitest run`.
|
|
"tests/qa/**",
|
|
"**/node_modules/**",
|
|
"**/dist/**",
|
|
"**/.{idea,git,cache,output,temp}/**",
|
|
".worktrees/**",
|
|
".claude/**",
|
|
// Stryker copies the whole project into .stryker-tmp*/sandbox-XXXX while a
|
|
// mutation run is in flight, and leaves it behind entirely if that run
|
|
// crashes. Without this, a concurrent `vitest run` discovers the copies and
|
|
// reports "Cannot find module" failures from a directory that is gitignored
|
|
// build scratch. Those phantom failures are indistinguishable from real
|
|
// ones at a glance, which is exactly the wrong thing to hand a release
|
|
// verdict. The configs also set cleanTempDir: "always" so the scratch does
|
|
// not survive a crash in the first place.
|
|
".stryker-tmp*/**",
|
|
"**/.stryker-tmp*/**",
|
|
],
|
|
env: {
|
|
AUTH_ENABLED: "true",
|
|
DEFAULT_USERNAME: "admin",
|
|
DEFAULT_PASSWORD: "Adminpass1",
|
|
// DATABASE_URL and WORKSPACE_PATH are set per-fork in tests/setup/per-fork-env.ts
|
|
MAX_UPLOAD_SIZE_MB: "10",
|
|
MAX_BATCH_SIZE: "10",
|
|
RATE_LIMIT_PER_MIN: "10000",
|
|
MAX_USERS: "0",
|
|
MAX_MEGAPIXELS: "100",
|
|
CONCURRENT_JOBS: "3",
|
|
FILE_MAX_AGE_HOURS: "1",
|
|
CLEANUP_INTERVAL_MINUTES: "60",
|
|
MAX_PIPELINE_STEPS: "0",
|
|
},
|
|
coverage: {
|
|
provider: "v8",
|
|
reporter: ["text", "html", "lcov"],
|
|
// Vitest defaults this to false, which silently throws away the entire
|
|
// report (text table, lcov, html) and the threshold check below the
|
|
// moment any test fails. The run then reads as "tests failed" when the
|
|
// ratchet in fact never ran, so a coverage regression can hide behind an
|
|
// unrelated failure. Always emit; the exit code still comes from the
|
|
// tests.
|
|
reportOnFailure: true,
|
|
// Ratchet: measured 2026-06-10 at lines 77.7 / branches 83.7 /
|
|
// functions 86.5 over unit+integration. Raise when coverage rises;
|
|
// never lower without a written reason.
|
|
// 2026-06-24: re-baselined branches 81 -> 80 and functions 84 -> 83.
|
|
// The 2.0 surface growth (240 tools) plus the analytics-system removal
|
|
// (#336 deleted tested code) settled the all-tests-passing measurement at
|
|
// branches 80.97 / functions 83.36, just under the old ratchet. Per-tool
|
|
// integration tests still cover the critical paths.
|
|
thresholds: {
|
|
lines: 75,
|
|
branches: 80,
|
|
functions: 83,
|
|
statements: 75,
|
|
},
|
|
include: [
|
|
"packages/image-engine/src/**",
|
|
"apps/api/src/**",
|
|
"apps/web/src/stores/**",
|
|
"apps/web/src/lib/**",
|
|
],
|
|
exclude: [
|
|
"**/*.d.ts",
|
|
"**/node_modules/**",
|
|
"**/dist/**",
|
|
"apps/api/src/db/migrate.ts",
|
|
"apps/api/src/index.ts",
|
|
],
|
|
},
|
|
},
|
|
resolve: {
|
|
alias: {
|
|
"@landing": path.resolve(__dirname, "apps/landing/src"),
|
|
// Landing page components that don't exist in web but are imported via @/
|
|
"@/components/fade-in": path.resolve(__dirname, "apps/landing/src/components/fade-in"),
|
|
"@/components/footer": path.resolve(__dirname, "apps/landing/src/components/footer"),
|
|
"@/components/json-ld": path.resolve(__dirname, "apps/landing/src/components/json-ld"),
|
|
"@/components/navbar": path.resolve(__dirname, "apps/landing/src/components/navbar"),
|
|
"@": path.resolve(__dirname, "apps/web/src"),
|
|
"framer-motion": path.join(landingNodeModules, "framer-motion"),
|
|
"pdfjs-dist": path.join(webNodeModules, "pdfjs-dist"),
|
|
"@snapotter/ai": path.resolve(__dirname, "packages/ai/src/index.ts"),
|
|
"@snapotter/enterprise": path.resolve(__dirname, "packages/enterprise/src/index.ts"),
|
|
"@snapotter/image-engine": path.resolve(__dirname, "packages/image-engine/src/index.ts"),
|
|
"@snapotter/media-engine": path.resolve(__dirname, "packages/media-engine/src/index.ts"),
|
|
"@snapotter/doc-engine": path.resolve(__dirname, "packages/doc-engine/src/index.ts"),
|
|
"@snapotter/shared/i18n": path.resolve(__dirname, "packages/shared/src/i18n"),
|
|
"@snapotter/shared/search": path.resolve(__dirname, "packages/shared/src/search"),
|
|
"@snapotter/shared": path.resolve(__dirname, "packages/shared/src/index.ts"),
|
|
fastify: path.join(apiNodeModules, "fastify"),
|
|
"@fastify/cookie": path.join(apiNodeModules, "@fastify/cookie"),
|
|
"@fastify/cors": path.join(apiNodeModules, "@fastify/cors"),
|
|
"@fastify/multipart": path.join(apiNodeModules, "@fastify/multipart"),
|
|
"@fastify/rate-limit": path.join(apiNodeModules, "@fastify/rate-limit"),
|
|
"@fastify/static": path.join(apiNodeModules, "@fastify/static"),
|
|
"@fastify/swagger": path.join(apiNodeModules, "@fastify/swagger"),
|
|
"@fastify/swagger-ui": path.join(apiNodeModules, "@fastify/swagger-ui"),
|
|
"better-sqlite3": path.join(apiNodeModules, "better-sqlite3"),
|
|
pg: path.join(apiNodeModules, "pg"),
|
|
"drizzle-orm": path.join(apiNodeModules, "drizzle-orm"),
|
|
archiver: path.join(apiNodeModules, "archiver"),
|
|
"p-queue": path.join(apiNodeModules, "p-queue"),
|
|
dotenv: path.join(apiNodeModules, "dotenv"),
|
|
potrace: path.join(apiNodeModules, "potrace"),
|
|
qrcode: path.join(apiNodeModules, "qrcode"),
|
|
jsqr: path.join(apiNodeModules, "jsqr"),
|
|
pdfkit: path.join(apiNodeModules, "pdfkit"),
|
|
pino: path.join(apiNodeModules, "pino"),
|
|
sharp: path.join(apiNodeModules, "sharp"),
|
|
ioredis: path.join(apiNodeModules, "ioredis"),
|
|
bullmq: path.join(apiNodeModules, "bullmq"),
|
|
otpauth: path.join(apiNodeModules, "otpauth"),
|
|
"openid-client": path.join(apiNodeModules, "openid-client"),
|
|
"@node-saml/node-saml": path.join(apiNodeModules, "@node-saml/node-saml"),
|
|
"opentype.js": path.join(apiNodeModules, "opentype.js"),
|
|
"posthog-node": path.join(apiNodeModules, "posthog-node"),
|
|
"@sentry/node": path.join(apiNodeModules, "@sentry/node"),
|
|
"@aws-sdk/client-s3": path.join(
|
|
path.resolve(__dirname, "packages/enterprise/node_modules"),
|
|
"@aws-sdk/client-s3",
|
|
),
|
|
react: path.join(webNodeModules, "react"),
|
|
"react-dom": path.join(webNodeModules, "react-dom"),
|
|
"react-router": path.join(webNodeModules, "react-router"),
|
|
zustand: path.join(webNodeModules, "zustand"),
|
|
"fuse.js": path.join(webNodeModules, "fuse.js"),
|
|
"posthog-js": path.join(webNodeModules, "posthog-js"),
|
|
"@sentry/react": path.join(webNodeModules, "@sentry/react"),
|
|
"@opentelemetry/api": path.join(apiNodeModules, "@opentelemetry/api"),
|
|
"@opentelemetry/core": findPnpmPackage("@opentelemetry", "core"),
|
|
"@opentelemetry/sdk-node": path.join(apiNodeModules, "@opentelemetry/sdk-node"),
|
|
"@opentelemetry/sdk-trace-base": path.join(apiNodeModules, "@opentelemetry/sdk-trace-base"),
|
|
"@opentelemetry/exporter-trace-otlp-http": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/exporter-trace-otlp-http",
|
|
),
|
|
"@opentelemetry/resources": path.join(apiNodeModules, "@opentelemetry/resources"),
|
|
"@opentelemetry/semantic-conventions": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/semantic-conventions",
|
|
),
|
|
"@opentelemetry/instrumentation-http": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/instrumentation-http",
|
|
),
|
|
"@opentelemetry/instrumentation-fastify": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/instrumentation-fastify",
|
|
),
|
|
"@opentelemetry/instrumentation-pg": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/instrumentation-pg",
|
|
),
|
|
"@opentelemetry/instrumentation-ioredis": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/instrumentation-ioredis",
|
|
),
|
|
"@opentelemetry/instrumentation-aws-sdk": path.join(
|
|
apiNodeModules,
|
|
"@opentelemetry/instrumentation-aws-sdk",
|
|
),
|
|
},
|
|
},
|
|
});
|