mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
96 lines
3.1 KiB
TypeScript
96 lines
3.1 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import { MemoryRouter } from "react-router";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { MobileBottomNav } from "@/components/layout/mobile-bottom-nav";
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
function renderNav(onSettingsClick?: () => void) {
|
|
return render(
|
|
<MemoryRouter>
|
|
<MobileBottomNav onSettingsClick={onSettingsClick} />
|
|
</MemoryRouter>,
|
|
);
|
|
}
|
|
|
|
describe("MobileBottomNav", () => {
|
|
it("renders all navigation items", () => {
|
|
renderNav(() => {});
|
|
|
|
// Navigation links (i18n keys render their English values)
|
|
expect(screen.getByText("Tools")).toBeDefined();
|
|
expect(screen.getByText("Automate")).toBeDefined();
|
|
expect(screen.getByText("Editor")).toBeDefined();
|
|
expect(screen.getByText("Files")).toBeDefined();
|
|
expect(screen.getByText("Settings")).toBeDefined();
|
|
});
|
|
|
|
it("renders as a nav element with fixed positioning", () => {
|
|
renderNav(() => {});
|
|
|
|
const nav = document.querySelector("nav");
|
|
expect(nav).not.toBeNull();
|
|
expect(nav!.className).toContain("fixed");
|
|
expect(nav!.className).toContain("bottom-0");
|
|
});
|
|
|
|
it("navigation links have correct href targets", () => {
|
|
renderNav(() => {});
|
|
|
|
const links = document.querySelectorAll("a");
|
|
const hrefs = Array.from(links).map((a) => a.getAttribute("href"));
|
|
|
|
expect(hrefs).toContain("/");
|
|
expect(hrefs).toContain("/automate");
|
|
expect(hrefs).toContain("/editor");
|
|
expect(hrefs).toContain("/files");
|
|
});
|
|
|
|
it("settings button calls onSettingsClick when clicked", () => {
|
|
const onClick = vi.fn();
|
|
renderNav(onClick);
|
|
|
|
const settingsBtn = screen.getByTestId("open-settings");
|
|
fireEvent.click(settingsBtn);
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("settings button is hidden when onSettingsClick is not provided", () => {
|
|
renderNav();
|
|
|
|
// Without onSettingsClick, the settings button should not render
|
|
expect(screen.queryByText("Settings")).toBeNull();
|
|
});
|
|
|
|
it("renders an svg icon for each navigation item", () => {
|
|
renderNav(() => {});
|
|
|
|
// All five items (Tools, Automate, Editor, Files, Settings) render inline
|
|
// SVG icons. The Editor icon used to be a CSS-masked <span> that rendered
|
|
// as nothing when its mask asset failed to load; it is now an inline SVG
|
|
// like the rest, so it always draws.
|
|
const svgs = document.querySelectorAll("nav svg");
|
|
expect(svgs.length).toBe(5);
|
|
|
|
const editorLink = Array.from(document.querySelectorAll("a")).find(
|
|
(a) => a.getAttribute("href") === "/editor",
|
|
);
|
|
expect(editorLink?.querySelector("svg")).not.toBeNull();
|
|
});
|
|
|
|
it("nav has backdrop blur and border-top styling", () => {
|
|
renderNav(() => {});
|
|
|
|
const nav = document.querySelector("nav") as HTMLElement;
|
|
expect(nav).not.toBeNull();
|
|
// The component applies bg-background/95 backdrop-blur-sm border-t
|
|
expect(nav.className).toContain("backdrop-blur");
|
|
expect(nav.className).toContain("border-t");
|
|
expect(nav.className).toContain("z-30");
|
|
});
|
|
});
|