Files
SnapOtterandGitHub d10d0f544f fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
2026-07-27 15:37:30 +08:00

500 lines
20 KiB
YAML

name: CI
# Path filtering happens at the JOB level (see the `changes` job), not here.
# Workflow-level paths-ignore never creates the check runs at all, which
# deadlocks required status checks on docs-only PRs (contexts stay "expected"
# forever). Job-level skips complete with conclusion "skipped", which
# satisfies branch protection.
on:
workflow_dispatch:
push:
branches: [main]
pull_request:
branches: [main]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
permissions:
contents: read
# Testcontainers' ryuk reaper is redundant here (tests/global-setup.ts explicitly
# stops its containers and CI runners are ephemeral), and its image pull from Docker
# Hub is a recurring flake source (HTTP 500 on registry-1.docker.io). Disable it so a
# registry hiccup pulling ryuk cannot fail the suite.
env:
TESTCONTAINERS_RYUK_DISABLED: "true"
jobs:
# Detects whether anything outside the docs/landing/branding surfaces
# changed. Downstream jobs skip when code is untouched; a skipped job still
# reports a conclusion, so required status checks stay mergeable.
# Fails open: any uncertainty (unknown base, force push, dispatch) runs
# the full pipeline.
changes:
name: Changes
runs-on: ubuntu-latest
outputs:
code: ${{ steps.filter.outputs.code }}
landing: ${{ steps.filter.outputs.landing }}
docs: ${{ steps.filter.outputs.docs }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- id: filter
name: Diff against the base commit
env:
EVENT_NAME: ${{ github.event_name }}
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
PUSH_BEFORE_SHA: ${{ github.event.before }}
run: |
if [ "$EVENT_NAME" = "pull_request" ]; then
base="$PR_BASE_SHA"
else
base="$PUSH_BEFORE_SHA"
fi
# `code`: anything outside the docs/landing surfaces changed (gates the
# main pipeline). `landing` and `docs`: that surface's own files changed
# (gates its e2e job). All three fail open to true when the base is
# unknown.
code=true
landing=true
docs=true
if [ -n "$base" ] && [ "$base" != "0000000000000000000000000000000000000000" ]; then
if git fetch --no-tags --depth=1 origin "$base" && git cat-file -e "$base" 2>/dev/null; then
changed=$(git diff --name-only "$base" HEAD)
echo "Changed files:"
printf '%s\n' "$changed"
code=false
for f in $changed; do
case "$f" in
README.md|CONTRIBUTING.md|branding/*|apps/docs/*|apps/landing/*|docs/*) ;;
*) code=true; break ;;
esac
done
landing=false
for f in $changed; do
case "$f" in
apps/landing/*|tests/e2e-landing/*|playwright.landing.config.ts|packages/shared/*) landing=true; break ;;
esac
done
docs=false
for f in $changed; do
case "$f" in
apps/docs/*|tests/e2e-docs/*|playwright.docs.config.ts) docs=true; break ;;
esac
done
else
echo "Base commit unavailable; running the full pipeline"
fi
else
echo "No usable base (dispatch, force push, or new branch); running the full pipeline"
fi
echo "code=$code" >> "$GITHUB_OUTPUT"
echo "landing=$landing" >> "$GITHUB_OUTPUT"
echo "docs=$docs" >> "$GITHUB_OUTPUT"
lint:
name: Lint
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.code == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- run: pnpm lint
- name: License boundary check (D15)
run: pnpm check:license-boundary
- name: Production Node dependency license and notices check
run: pnpm check:production-node-licenses
typecheck:
name: Typecheck
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.code == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- run: pnpm typecheck
test-unit:
name: Unit Tests
runs-on: ubuntu-latest
timeout-minutes: 8
needs: changes
if: needs.changes.outputs.code == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Install system dependencies (HEIC + ExifTool + ImageMagick + exotic format tools)
run: |
sudo apt-get update -qq
sudo apt-get install -y --no-install-recommends libheif-examples libheif-plugin-x265 libheif-plugin-libde265 libimage-exiftool-perl libraw-bin imagemagick ghostscript libjxl-tools libopenjp2-tools
if apt-cache show libmagickcore-6.q16-7-extra >/dev/null 2>&1; then
sudo apt-get install -y --no-install-recommends libmagickcore-6.q16-7-extra
elif apt-cache show libmagickcore-6.q16-6-extra >/dev/null 2>&1; then
sudo apt-get install -y --no-install-recommends libmagickcore-6.q16-6-extra
else
echo "No supported ImageMagick EXR coder package found" >&2
exit 1
fi
convert -list format | grep -Eq '^[[:space:]]*EXR([*[:space:]]|$)'
- uses: ./.github/actions/setup
- name: Pre-pull testcontainer images (retry transient Docker Hub errors)
run: |
for img in postgres:17-alpine redis:8-alpine; do
ok=
for attempt in 1 2 3 4 5; do
if docker pull "$img"; then ok=1; break; fi
echo "::warning::docker pull $img failed (attempt $attempt/5); retrying in $((attempt * 5))s"
sleep "$((attempt * 5))"
done
[ -n "$ok" ] || { echo "::error::could not pull $img after 5 attempts"; exit 1; }
done
- run: pnpm vitest run tests/unit/ --reporter=verbose
test-integration:
name: Integration (${{ matrix.shard }}/4)
runs-on: ubuntu-latest
timeout-minutes: 30
needs: changes
if: needs.changes.outputs.code == 'true'
strategy:
fail-fast: false
matrix:
shard: [1, 2, 3, 4]
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Install system dependencies (image formats + docs + Fast OCR)
run: |
sudo apt-get update -qq
sudo apt-get install -y --no-install-recommends \
libheif-examples libheif-plugin-x265 libheif-plugin-libde265 \
libimage-exiftool-perl libraw-bin imagemagick ghostscript \
libjxl-tools libopenjp2-tools \
qpdf libreoffice-calc libreoffice-impress libreoffice-writer \
tesseract-ocr tesseract-ocr-eng tesseract-ocr-deu \
tesseract-ocr-fra tesseract-ocr-spa \
tesseract-ocr-chi-sim tesseract-ocr-jpn
if apt-cache show libmagickcore-6.q16-7-extra >/dev/null 2>&1; then
sudo apt-get install -y --no-install-recommends libmagickcore-6.q16-7-extra
elif apt-cache show libmagickcore-6.q16-6-extra >/dev/null 2>&1; then
sudo apt-get install -y --no-install-recommends libmagickcore-6.q16-6-extra
else
echo "No supported ImageMagick EXR coder package found" >&2
exit 1
fi
convert -list format | grep -Eq '^[[:space:]]*EXR([*[:space:]]|$)'
sudo rm -f /usr/share/tesseract-ocr/5/tessdata/osd.traineddata
test ! -e /usr/share/tesseract-ocr/5/tessdata/osd.traineddata
expected=(chi_sim deu eng fra jpn spa)
mapfile -t actual < <(tesseract --list-langs 2>/dev/null | tail -n +2 | LC_ALL=C sort)
[[ "${actual[*]}" == "${expected[*]}" ]] || {
echo "::error::Fast OCR language payload changed: ${actual[*]}"
exit 1
}
- name: Install Pandoc 3.10 (sandboxed DOCX/EPUB)
run: |
curl -fsSL https://github.com/jgm/pandoc/releases/download/3.10/pandoc-3.10-1-amd64.deb -o /tmp/pandoc.deb
sudo apt-get install -y --no-install-recommends /tmp/pandoc.deb
pandoc --version
- name: Install pdfcpu (doc-engine PDF layout binary; matches docker/Dockerfile v0.13.0)
run: |
curl -fsSL https://github.com/pdfcpu/pdfcpu/releases/download/v0.13.0/pdfcpu_0.13.0_Linux_x86_64.tar.xz -o /tmp/pdfcpu.tar.xz
tar -xJf /tmp/pdfcpu.tar.xz -C /tmp
sudo install "$(find /tmp -type f -name pdfcpu | head -1)" /usr/local/bin/pdfcpu
pdfcpu version
- name: Allow ImageMagick to read EPS/PS via Ghostscript delegate
run: |
POLICY_FILE=$(find /etc/ImageMagick* -name policy.xml 2>/dev/null | head -1)
if [ -n "$POLICY_FILE" ]; then
sudo sed -i 's/<policy domain="coder" rights="none" pattern="EPS"/<policy domain="coder" rights="read" pattern="EPS"/' "$POLICY_FILE"
sudo sed -i 's/<policy domain="coder" rights="none" pattern="PS"/<policy domain="coder" rights="read" pattern="PS"/' "$POLICY_FILE"
fi
- uses: ./.github/actions/setup
- name: Pre-pull testcontainer images (retry transient Docker Hub errors)
run: |
for img in postgres:17-alpine redis:8-alpine; do
ok=
for attempt in 1 2 3 4 5; do
if docker pull "$img"; then ok=1; break; fi
echo "::warning::docker pull $img failed (attempt $attempt/5); retrying in $((attempt * 5))s"
sleep "$((attempt * 5))"
done
[ -n "$ok" ] || { echo "::error::could not pull $img after 5 attempts"; exit 1; }
done
- run: pnpm vitest run tests/integration/ --reporter=verbose --shard=${{ matrix.shard }}/4
test-e2e-smoke:
name: E2E Smoke (Chromium)
runs-on: ubuntu-latest
timeout-minutes: 15
needs: changes
if: needs.changes.outputs.code == 'true'
services:
postgres:
image: postgres:17-alpine
env:
POSTGRES_USER: snapotter
POSTGRES_PASSWORD: snapotter
POSTGRES_DB: snapotter
ports:
- 5432:5432
options: >-
--health-cmd "pg_isready -U snapotter"
--health-interval 5s
--health-timeout 3s
--health-retries 10
redis:
image: redis:8-alpine
ports:
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 5s
--health-timeout 3s
--health-retries 10
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- name: Get Playwright version
id: pw-version
run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> "$GITHUB_OUTPUT"
- name: Cache Playwright browsers
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ steps.pw-version.outputs.version }}
- name: Install Playwright Chromium
run: pnpm playwright install --with-deps chromium
- name: Run smoke specs
# tools-all.spec.ts is the full 240-tool per-tool render matrix (~250 tests)
# -- a comprehensive check, not a PR-gate smoke test. It runs in the nightly
# e2e-full bucket, which executes the whole suite sharded. Keep this gate to
# genuinely fast sanity specs so it finishes well inside the timeout.
run: pnpm playwright test tests/e2e/smoke.spec.ts tests/e2e/navigation.spec.ts tests/e2e/home-page.spec.ts --project=chromium
env:
PW_WORKERS: "2"
- name: Upload report on failure
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: failure()
with:
name: e2e-smoke-report
path: playwright-report/
retention-days: 7
test-e2e-mobile-smoke:
name: E2E Mobile Smoke (Chromium)
runs-on: ubuntu-latest
timeout-minutes: 15
needs: changes
if: needs.changes.outputs.code == 'true'
services:
postgres:
image: postgres:17-alpine
env:
POSTGRES_USER: snapotter
POSTGRES_PASSWORD: snapotter
POSTGRES_DB: snapotter
ports:
- 5432:5432
options: >-
--health-cmd "pg_isready -U snapotter"
--health-interval 5s
--health-timeout 3s
--health-retries 10
redis:
image: redis:8-alpine
ports:
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 5s
--health-timeout 3s
--health-retries 10
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- name: Get Playwright version
id: pw-version
run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> "$GITHUB_OUTPUT"
- name: Cache Playwright browsers
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ steps.pw-version.outputs.version }}
- name: Install Playwright Chromium
run: pnpm playwright install --with-deps chromium
- name: Run mobile device specs (Pixel 7)
run: pnpm playwright test --project=mobile-chromium --grep @mobile --grep-invert @visual
env:
PW_WORKERS: "2"
- name: Upload report on failure
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: failure()
with:
name: e2e-mobile-smoke-report
path: playwright-report/
retention-days: 7
test-e2e-landing:
name: E2E Landing (Chromium)
runs-on: ubuntu-latest
timeout-minutes: 15
needs: changes
if: needs.changes.outputs.landing == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- name: Get Playwright version
id: pw-version
run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> "$GITHUB_OUTPUT"
- name: Cache Playwright browsers
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ steps.pw-version.outputs.version }}
- name: Install Playwright Chromium
run: pnpm playwright install --with-deps chromium
- name: Run landing e2e suite
# The landing is a static Astro site with no database, so this needs no
# Postgres/Redis services. The suite's webServer starts `astro dev` on 4350.
run: pnpm test:e2e:landing
env:
# Authenticated GitHub API so the dev server's build-time star-count fetch
# isn't rate-limited on shared runner IPs. It falls back to a constant on
# failure either way, so this only keeps the run quiet, not correct.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload report on failure
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: failure()
with:
name: e2e-landing-report
path: playwright-report/
retention-days: 7
test-e2e-docs:
name: E2E Docs (Chromium)
runs-on: ubuntu-latest
# vitepress build renders ~3,800 pages and then runs Pagefind over them,
# which the config allows up to 10 minutes for on a loaded machine.
timeout-minutes: 30
needs: changes
if: needs.changes.outputs.docs == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- name: Get Playwright version
id: pw-version
run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> "$GITHUB_OUTPUT"
- name: Cache Playwright browsers
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ steps.pw-version.outputs.version }}
- name: Install Playwright Chromium
run: pnpm playwright install --with-deps chromium
- name: Run docs e2e suite
# Static VitePress site with no database, so no Postgres/Redis services.
# The suite's webServer builds the site and serves the preview itself.
# This job is path-filtered like the landing one, so a docs-only PR gets
# a real check instead of the nothing it used to get, and a code-only PR
# still reports a conclusion via the skip.
run: pnpm test:e2e:docs
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload report on failure
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: failure()
with:
name: e2e-docs-report
path: playwright-report/
retention-days: 7
pip-audit:
name: Python Dependency Audit
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.code == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.11"
- run: pip install "pip-audit==2.10.0"
- name: Run pip-audit (ignoring CVEs blocked by dependency constraints)
# Three entries, each one live against the current lock. 19 others were
# dropped after a re-audit showed the pins had moved past them: five
# Pillow (all fixed at or below 12.2.0, lock pins 12.3.0), twelve torch
# (all last_affected at or below 2.10.0, resolves to 2.13.0), joblib
# (not in the closure), markdown (last_affected 3.8, resolves 3.10.2).
# PYSEC-2025-194 was a duplicate of CVE-2025-3000, which is itself now
# dead. Re-check the three below whenever requirements.txt moves.
#
# CVE-2024-27763: basicsr, no fixed release exists in any channel.
# CVE-2026-40086 + GHSA-55v6-g8pm-pw4c: rembg 2.0.69. The fix is
# rembg 2.0.75, held back by the numpy 1.26.4 pin (see the rationale
# in packages/ai/python/requirements.txt).
run: >-
pip-audit -r packages/ai/python/requirements.txt
--ignore-vuln CVE-2024-27763
--ignore-vuln CVE-2026-40086
--ignore-vuln GHSA-55v6-g8pm-pw4c
- name: Audit exact OCR runtime dependency locks
run: |
for requirements in \
docker/ocr-runtime-requirements-amd64.txt \
docker/ocr-runtime-requirements-arm64.txt; do
pip-audit -r "${requirements}" --no-deps --disable-pip --aliases
done
build:
name: Build
runs-on: ubuntu-latest
# Only `changes` is a real dependency (its output gates the `if` below).
# Gating on the test jobs used to save a runner minute on red PRs, but it
# put a 55s job behind the slowest integration shard and added that time to
# every green run. Build and the test jobs are independent required checks,
# so a green Build still can't merge past a red shard.
needs: [changes]
if: needs.changes.outputs.code == 'true'
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: ./.github/actions/setup
- run: pnpm build
# docker:
# name: Docker Build Test
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: docker/setup-buildx-action@v3
# - name: Log in to GHCR (for registry cache)
# uses: docker/login-action@v3
# with:
# registry: ghcr.io
# username: ${{ github.repository_owner }}
# password: ${{ secrets.GHCR_TOKEN }}
# - uses: docker/build-push-action@v6
# with:
# context: .
# file: docker/Dockerfile
# push: false
# tags: snapotter:ci
# build-args: SKIP_MODEL_DOWNLOADS=true
# cache-from: type=registry,ref=ghcr.io/snapotter-hq/snapotter:cache-linux-amd64
# cache-to: type=registry,ref=ghcr.io/snapotter-hq/snapotter:cache-ci,mode=max