mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
SnapOtterandGitHub
d10d0f544f
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
112 lines
4.5 KiB
TypeScript
112 lines
4.5 KiB
TypeScript
// tests/e2e-landing/worker.spec.ts
|
|
import { expect, test } from "@playwright/test";
|
|
// @ts-expect-error plain ESM asset, no types
|
|
import worker from "../../apps/landing/public/_worker.js";
|
|
|
|
/**
|
|
* `astro preview` serves dist as flat files. It does not run `_worker.js`, so the
|
|
* two behaviours only Cloudflare Pages provides (the /api/status probe and the
|
|
* www to apex redirect) are invisible to every other spec in this directory: the
|
|
* status indicator specs mock /api/status precisely because the real route is
|
|
* absent under the harness.
|
|
*
|
|
* Driving the module directly is the coverage that gap needs. It is the same file
|
|
* the edge loads, with `env.ASSETS` and global fetch stubbed, so a regression in
|
|
* the worker fails here instead of first failing in production.
|
|
*/
|
|
|
|
type Handler = { fetch(request: Request, env: unknown): Promise<Response> };
|
|
const handler = worker as Handler;
|
|
|
|
const ASSET_BODY = "<html>asset</html>";
|
|
const env = {
|
|
ASSETS: {
|
|
fetch: async () =>
|
|
new Response(ASSET_BODY, { status: 200, headers: { "Content-Type": "text/html" } }),
|
|
},
|
|
};
|
|
|
|
/** Swap global fetch for the duration of one call so probes are deterministic. */
|
|
async function withFetch<T>(impl: typeof fetch, fn: () => Promise<T>): Promise<T> {
|
|
const original = globalThis.fetch;
|
|
globalThis.fetch = impl;
|
|
try {
|
|
return await fn();
|
|
} finally {
|
|
globalThis.fetch = original;
|
|
}
|
|
}
|
|
|
|
const upstream = (status: number) => async () => new Response(null, { status });
|
|
|
|
test.describe("landing Cloudflare worker", () => {
|
|
test("www redirects to the apex host, preserving the path", async () => {
|
|
const res = await handler.fetch(
|
|
new Request("https://www.snapotter.com/tools/image/resize/"),
|
|
env,
|
|
);
|
|
expect(res.status).toBe(301);
|
|
expect(res.headers.get("location")).toBe("https://snapotter.com/tools/image/resize/");
|
|
});
|
|
|
|
test("/api/status reports operational when both siblings answer", async () => {
|
|
const res = await withFetch(upstream(200) as unknown as typeof fetch, () =>
|
|
handler.fetch(new Request("https://snapotter.com/api/status"), env),
|
|
);
|
|
expect(res.status).toBe(200);
|
|
expect(await res.json()).toEqual({ status: "operational" });
|
|
// A synthesized Response carries no _headers decoration, so it has to set
|
|
// its own. A verdict that got indexed would be a search result of its own.
|
|
expect(res.headers.get("X-Robots-Tag")).toBe("noindex");
|
|
expect(res.headers.get("Cache-Control")).toBe("public, max-age=60");
|
|
});
|
|
|
|
test("a 3xx from a sibling still counts as up", async () => {
|
|
const res = await withFetch(upstream(302) as unknown as typeof fetch, () =>
|
|
handler.fetch(new Request("https://snapotter.com/api/status"), env),
|
|
);
|
|
expect(await res.json()).toEqual({ status: "operational" });
|
|
});
|
|
|
|
test("one sibling down reports partial, both down reports down", async () => {
|
|
const oneDown = (async (url: string | URL | Request) =>
|
|
new Response(null, {
|
|
status: String(url).includes("demo.") ? 503 : 200,
|
|
})) as unknown as typeof fetch;
|
|
|
|
const partial = await withFetch(oneDown, () =>
|
|
handler.fetch(new Request("https://snapotter.com/api/status"), env),
|
|
);
|
|
expect(await partial.json()).toEqual({ status: "partial" });
|
|
|
|
const both = await withFetch(upstream(503) as unknown as typeof fetch, () =>
|
|
handler.fetch(new Request("https://snapotter.com/api/status"), env),
|
|
);
|
|
expect(await both.json()).toEqual({ status: "down" });
|
|
// A false red pins in the browser across navigations, so it is rechecked sooner.
|
|
expect(both.headers.get("Cache-Control")).toBe("public, max-age=15");
|
|
});
|
|
|
|
test("a throwing probe retries once before it reports the leg down", async () => {
|
|
const calls: string[] = [];
|
|
const flaky = (async (url: string | URL | Request) => {
|
|
calls.push(String(url));
|
|
// Fail the first attempt for each host, succeed on the retry.
|
|
if (calls.filter((c) => c === String(url)).length === 1) throw new Error("network");
|
|
return new Response(null, { status: 200 });
|
|
}) as unknown as typeof fetch;
|
|
|
|
const res = await withFetch(flaky, () =>
|
|
handler.fetch(new Request("https://snapotter.com/api/status"), env),
|
|
);
|
|
expect(await res.json()).toEqual({ status: "operational" });
|
|
expect(calls.length).toBe(4); // two hosts, two attempts each
|
|
});
|
|
|
|
test("every other path falls through to the static assets", async () => {
|
|
const res = await handler.fetch(new Request("https://snapotter.com/faq/"), env);
|
|
expect(res.status).toBe(200);
|
|
expect(await res.text()).toBe(ASSET_BODY);
|
|
});
|
|
});
|