External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve 3 pre-existing issues found during test coverage expansion

Browse Source 
1. passport-photo 404 vs 501: add base route at /api/v1/tools/passport-photo
   that returns 501 FEATURE_NOT_INSTALLED when the AI bundle is missing,
   matching other AI tools. The /generate sub-route is Sharp-only (no
   sidecar) so it correctly skips the isToolInstalled guard.

2. AuthGuard analytics consent race: don't evaluate shouldShowConsent()
   until analyticsConfig has been fetched (guard on analyticsConfig !== null).
   Prevents redirect to /analytics-consent before config is loaded.

3. Fragile sidebar Settings selector: add openSettings(page) helper to
   E2E helpers that checks sidebar visibility with fallback to button role.
   Replace all 134 occurrences of page.locator("aside").getByText("Settings")
   across 18 test files.
This commit is contained in:
SnapOtter
2026-05-01 13:44:04 +08:00
parent 7ce0f7b431
commit fa479dcee4
22 changed files with 195 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/rbac.spec.ts
+4 -4
View File
@@ -1,5 +1,5 @@
import { test as base, expect } from "@playwright/test";
import { login } from "./helpers";
import { login, openSettings } from "./helpers";
const API = process.env.API_URL || "http://localhost:13490";
@@ -108,7 +108,7 @@ base.describe("RBAC - Admin sees all tabs", () => {
base.test("admin sees all settings tabs", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await expect(page.getByRole("button", { name: /general/i })).toBeVisible();
await expect(page.getByRole("button", { name: /system settings/i })).toBeVisible();
@@ -138,7 +138,7 @@ base.describe("RBAC - User sees restricted tabs", () => {
base.test("user role only sees permitted settings tabs", async ({ page }) => {
await login(page, TEST_USER, TEST_PASSWORD);
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
// Should see these tabs
await expect(page.getByRole("button", { name: /general/i })).toBeVisible();
@@ -251,7 +251,7 @@ base.describe("RBAC - Editor sees collaborative tabs", () => {
"editor sees general, security, api-keys, tools, about but not admin tabs",
async ({ page }) => {
await login(page, "editortest", "EditorTest1");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
// Should see these
await expect(page.getByRole("button", { name: /general/i })).toBeVisible();