External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve 3 pre-existing issues found during test coverage expansion

Browse Source 
1. passport-photo 404 vs 501: add base route at /api/v1/tools/passport-photo
   that returns 501 FEATURE_NOT_INSTALLED when the AI bundle is missing,
   matching other AI tools. The /generate sub-route is Sharp-only (no
   sidecar) so it correctly skips the isToolInstalled guard.

2. AuthGuard analytics consent race: don't evaluate shouldShowConsent()
   until analyticsConfig has been fetched (guard on analyticsConfig !== null).
   Prevents redirect to /analytics-consent before config is loaded.

3. Fragile sidebar Settings selector: add openSettings(page) helper to
   E2E helpers that checks sidebar visibility with fallback to button role.
   Replace all 134 occurrences of page.locator("aside").getByText("Settings")
   across 18 test files.
This commit is contained in:
SnapOtter
2026-05-01 13:44:04 +08:00
parent 7ce0f7b431
commit fa479dcee4
22 changed files with 195 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/rbac-full.spec.ts
+8 -8
View File
@@ -1,5 +1,5 @@
import { test as base, expect } from "@playwright/test";
import { login } from "./helpers";
import { login, openSettings } from "./helpers";
const API = process.env.API_URL || "http://localhost:13490";
@@ -143,7 +143,7 @@ base.describe("RBAC Full — People Management UI", () => {
"admin sees role dropdown with admin/editor/user options when adding members",
async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /people/i }).click();
// Click "Add Members" to reveal the form
@@ -174,14 +174,14 @@ base.describe("RBAC Full — Roles Management UI", () => {
base.test("admin sees Roles tab in settings", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await expect(page.getByRole("button", { name: /^roles$/i })).toBeVisible();
});
base.test("roles section shows built-in roles with Built-in badge", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /^roles$/i }).click();
// Wait for roles to load
@@ -207,14 +207,14 @@ base.describe("RBAC Full — Audit Log UI", () => {
base.test("admin sees Audit Log tab in settings", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await expect(page.getByRole("button", { name: /audit log/i })).toBeVisible();
});
base.test("audit log displays LOGIN_SUCCESS entries", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /audit log/i }).click();
// Wait for audit log section to load
@@ -244,7 +244,7 @@ base.describe("RBAC Full — API Key Scoping UI", () => {
base.test("API Keys section has permission scoping toggle", async ({ page }) => {
await page.goto("/");
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
// The scoping toggle text should be visible
@@ -295,7 +295,7 @@ base.describe("RBAC Full — Custom Role User", () => {
base.test("custom role user only sees permitted tabs (no admin tabs)", async ({ page }) => {
await login(page, CUSTOM_USER, CUSTOM_PASSWORD);
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
// Should see these tabs (available to all authenticated users or matching permissions)
await expect(page.getByRole("button", { name: /general/i })).toBeVisible();