External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve 3 pre-existing issues found during test coverage expansion

Browse Source 
1. passport-photo 404 vs 501: add base route at /api/v1/tools/passport-photo
   that returns 501 FEATURE_NOT_INSTALLED when the AI bundle is missing,
   matching other AI tools. The /generate sub-route is Sharp-only (no
   sidecar) so it correctly skips the isToolInstalled guard.

2. AuthGuard analytics consent race: don't evaluate shouldShowConsent()
   until analyticsConfig has been fetched (guard on analyticsConfig !== null).
   Prevents redirect to /analytics-consent before config is loaded.

3. Fragile sidebar Settings selector: add openSettings(page) helper to
   E2E helpers that checks sidebar visibility with fallback to button role.
   Replace all 134 occurrences of page.locator("aside").getByText("Settings")
   across 18 test files.
This commit is contained in:
SnapOtter
2026-05-01 13:44:04 +08:00
parent 7ce0f7b431
commit fa479dcee4
22 changed files with 195 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/gui-settings-tools.spec.ts
+9 -9
View File
@@ -1,4 +1,4 @@
import { expect, test } from "./helpers";
import { expect, openSettings, test } from "./helpers";
// ---------------------------------------------------------------------------
// Settings Dialog -- Tools tab (enable/disable) and Product Analytics
@@ -6,7 +6,7 @@ import { expect, test } from "./helpers";
test.describe("GUI Settings - Tools Tab", () => {
test("displays tools list with category headings", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /tools/i }).click();
await expect(page.locator("h3").filter({ hasText: "Tools" }).first()).toBeVisible();
@@ -18,7 +18,7 @@ test.describe("GUI Settings - Tools Tab", () => {
});
test("Save Tool Settings button and disabled tools counter", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /tools/i }).click();
await expect(page.getByRole("button", { name: /save tool settings/i })).toBeVisible();
@@ -28,7 +28,7 @@ test.describe("GUI Settings - Tools Tab", () => {
});
test("saving tool settings shows restart banner", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /tools/i }).click();
await page.getByRole("button", { name: /save tool settings/i }).click();
@@ -41,7 +41,7 @@ test.describe("GUI Settings - Tools Tab", () => {
test.describe("GUI Settings - Tools Tab (additional)", () => {
test("each category has a heading", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /tools/i }).click();
await expect(page.locator("h3").filter({ hasText: "Tools" }).first()).toBeVisible();
@@ -56,7 +56,7 @@ test.describe("GUI Settings - Tools Tab (additional)", () => {
});
test("tools show both name and description", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /tools/i }).click();
// Wait for tools to load
@@ -70,7 +70,7 @@ test.describe("GUI Settings - Tools Tab (additional)", () => {
test.describe("GUI Settings - Product Analytics Tab", () => {
test("displays analytics consent section", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /product analytics/i }).click();
await expect(page.getByText("Product Analytics").first()).toBeVisible();
@@ -78,7 +78,7 @@ test.describe("GUI Settings - Product Analytics Tab", () => {
});
test("analytics toggle is present", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /product analytics/i }).click();
// Either the toggle button is present, or the admin-disabled message is shown
@@ -93,7 +93,7 @@ test.describe("GUI Settings - Product Analytics Tab", () => {
});
test("privacy policy link is present", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /product analytics/i }).click();
await expect(page.getByRole("link", { name: /learn more/i })).toBeVisible();