External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve 3 pre-existing issues found during test coverage expansion

Browse Source 
1. passport-photo 404 vs 501: add base route at /api/v1/tools/passport-photo
   that returns 501 FEATURE_NOT_INSTALLED when the AI bundle is missing,
   matching other AI tools. The /generate sub-route is Sharp-only (no
   sidecar) so it correctly skips the isToolInstalled guard.

2. AuthGuard analytics consent race: don't evaluate shouldShowConsent()
   until analyticsConfig has been fetched (guard on analyticsConfig !== null).
   Prevents redirect to /analytics-consent before config is loaded.

3. Fragile sidebar Settings selector: add openSettings(page) helper to
   E2E helpers that checks sidebar visibility with fallback to button role.
   Replace all 134 occurrences of page.locator("aside").getByText("Settings")
   across 18 test files.
This commit is contained in:
SnapOtter
2026-05-01 13:44:04 +08:00
parent 7ce0f7b431
commit fa479dcee4
22 changed files with 195 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/gui-settings-security.spec.ts
+12 -12
View File
@@ -1,4 +1,4 @@
import { expect, test } from "./helpers";
import { expect, openSettings, test } from "./helpers";
// ---------------------------------------------------------------------------
// Settings Dialog -- Security (change password) and API Keys tabs
@@ -6,7 +6,7 @@ import { expect, test } from "./helpers";
test.describe("GUI Settings - Security Tab", () => {
test("shows Change Password form with required inputs", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /security/i }).click();
await expect(page.locator("h3").filter({ hasText: "Security" })).toBeVisible();
@@ -22,7 +22,7 @@ test.describe("GUI Settings - Security Tab", () => {
});
test("mismatched passwords show error message", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /security/i }).click();
await page.getByPlaceholder("Current Password").fill("admin");
@@ -35,7 +35,7 @@ test.describe("GUI Settings - Security Tab", () => {
});
test("password visibility toggles work", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /security/i }).click();
const currentPwInput = page.getByPlaceholder("Current Password");
@@ -49,7 +49,7 @@ test.describe("GUI Settings - Security Tab", () => {
});
test("short password shows validation error", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /security/i }).click();
await page.getByPlaceholder("Current Password").fill("admin");
@@ -63,7 +63,7 @@ test.describe("GUI Settings - Security Tab", () => {
});
test("security section shows login attempt limit reference", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /security/i }).click();
await expect(page.getByText(/login attempt limits/i)).toBeVisible();
@@ -75,7 +75,7 @@ test.describe("GUI Settings - Security Tab", () => {
test.describe("GUI Settings - API Keys Tab", () => {
test("shows Generate API Key button and name input", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
await expect(page.locator("h3").filter({ hasText: "API Keys" })).toBeVisible();
@@ -84,7 +84,7 @@ test.describe("GUI Settings - API Keys Tab", () => {
});
test("generating an API key displays the key once", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
// Give a unique name so we can identify and clean it up
@@ -108,7 +108,7 @@ test.describe("GUI Settings - API Keys Tab", () => {
});
test("generated key appears in existing keys list", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
const keyName = `listTest-${Date.now()}`;
@@ -129,7 +129,7 @@ test.describe("GUI Settings - API Keys Tab", () => {
});
test("permission scoping toggle reveals checkboxes", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
const scopingToggle = page.getByText("Restrict permissions (optional)");
@@ -144,7 +144,7 @@ test.describe("GUI Settings - API Keys Tab", () => {
});
test("deleting an API key removes it from the list", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
// Create a key to delete
@@ -165,7 +165,7 @@ test.describe("GUI Settings - API Keys Tab", () => {
});
test("expiration date input is available", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
await page.getByRole("button", { name: /api keys/i }).click();
await expect(page.getByText("Expires:")).toBeVisible();