External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve 3 pre-existing issues found during test coverage expansion

Browse Source 
1. passport-photo 404 vs 501: add base route at /api/v1/tools/passport-photo
   that returns 501 FEATURE_NOT_INSTALLED when the AI bundle is missing,
   matching other AI tools. The /generate sub-route is Sharp-only (no
   sidecar) so it correctly skips the isToolInstalled guard.

2. AuthGuard analytics consent race: don't evaluate shouldShowConsent()
   until analyticsConfig has been fetched (guard on analyticsConfig !== null).
   Prevents redirect to /analytics-consent before config is loaded.

3. Fragile sidebar Settings selector: add openSettings(page) helper to
   E2E helpers that checks sidebar visibility with fallback to button role.
   Replace all 134 occurrences of page.locator("aside").getByText("Settings")
   across 18 test files.
This commit is contained in:
SnapOtter
2026-05-01 13:44:04 +08:00
parent 7ce0f7b431
commit fa479dcee4
22 changed files with 195 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/gui-accessibility.spec.ts
+8 -15
View File
@@ -1,4 +1,4 @@
import { expect, test } from "./helpers";
import { expect, openSettings, test } from "./helpers";
// ---------------------------------------------------------------------------
// GUI Accessibility: ARIA semantics, focus management, keyboard navigation
@@ -188,7 +188,7 @@ test.describe("Heading Hierarchy - Tool Pages", () => {
// ---------------------------------------------------------------------------
test.describe("Settings Dialog Accessibility", () => {
test("settings dialog opens as a layered panel with backdrop", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await openSettings(page);
// Dialog content should be visible
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
@@ -199,8 +199,7 @@ test.describe("Settings Dialog Accessibility", () => {
});
test("Escape key closes settings dialog", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
await page.keyboard.press("Escape");
@@ -208,8 +207,7 @@ test.describe("Settings Dialog Accessibility", () => {
});
test("settings dialog can be closed via close button", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
// Use the X close button
const closeBtn = page
@@ -222,8 +220,7 @@ test.describe("Settings Dialog Accessibility", () => {
});
test("settings dialog has a close button", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
// Close button with X icon
const closeBtn = page.locator("button").filter({ has: page.locator("svg.lucide-x") });
@@ -234,8 +231,7 @@ test.describe("Settings Dialog Accessibility", () => {
});
test("settings dialog backdrop is marked aria-hidden", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
// The backdrop overlay has aria-hidden="true" to keep it out of the a11y tree
const backdrop = page.locator("div[aria-hidden='true'].absolute.inset-0");
@@ -245,8 +241,7 @@ test.describe("Settings Dialog Accessibility", () => {
});
test("focus is contained inside settings dialog while open", async ({ loggedInPage: page }) => {
await page.locator("aside").getByText("Settings").click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
// Tab through several elements -- focus should stay within the dialog
for (let i = 0; i < 10; i++) {
@@ -430,9 +425,7 @@ test.describe("Focus Management", () => {
test.describe("Focus Management - Dialogs", () => {
test("closing settings dialog returns focus to page", async ({ loggedInPage: page }) => {
// Open settings
const settingsBtn = page.locator("aside").getByText("Settings");
await settingsBtn.click();
await expect(page.locator("h2").filter({ hasText: "Settings" })).toBeVisible();
await openSettings(page);
// Close via Escape
await page.keyboard.press("Escape");