mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
test: add real device-emulated mobile and tablet testing (phase 3)
Replace the fake resized-desktop mobile specs with real Playwright device projects (Pixel 7, iPhone 14, iPad gen 7, Galaxy Tab S9) that exercise real touch, mobile UA, DPR, and WebKit engine. Device projects in playwright.config.ts: - mobile-chromium (Pixel 7, 412x839, Chromium) - mobile-webkit (iPhone 14, 390x664, WebKit) - tablet-webkit (iPad gen 7, 810x1080, WebKit) - tablet-chromium (Galaxy Tab S9, 640x1024, Chromium) Device specs (16 mobile, 10 tablet): - Core flow: navigate to tool, upload, process, download - Responsive chrome: bottom-nav, sidebar hidden, search, overflow - Touch interactions: before-after slider, crop canvas - Editor gate: phone asserts "Desktop Recommended" message - Editor tablet: iPad (810px) renders canvas, Galaxy Tab (640px) shows gate - SSE visibility-recovery regression guard - RTL Arabic locale responsive check Key finding: Galaxy Tab S9 viewport (640px) is below the 768px mobile breakpoint, so useMobile() returns true and the editor shows the mobile gate. Only iPad gen 7 (810px) is classified as non-mobile. Component tests (17 tests, Vitest/jsdom): - use-mobile hook: breakpoint behavior across all 4 device widths - mobile-bottom-nav: render, navigation links, settings callback, icons CI wiring: - ci.yml: mobile-chromium smoke job (PR gate) - nightly.yml: full device matrix with webkit - update-visual-baselines.yml: webkit + device projects for goldens Parity: 13218 passed, 0 dropped (PARITY OK)
This commit is contained in:
@@ -0,0 +1,93 @@
|
||||
// @vitest-environment jsdom
|
||||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||
import { MemoryRouter } from "react-router-dom";
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { MobileBottomNav } from "@/components/layout/mobile-bottom-nav";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
function renderNav(onSettingsClick?: () => void) {
|
||||
return render(
|
||||
<MemoryRouter>
|
||||
<MobileBottomNav onSettingsClick={onSettingsClick} />
|
||||
</MemoryRouter>,
|
||||
);
|
||||
}
|
||||
|
||||
describe("MobileBottomNav", () => {
|
||||
it("renders all navigation items", () => {
|
||||
renderNav(() => {});
|
||||
|
||||
// Navigation links (i18n keys render their English values)
|
||||
expect(screen.getByText("Tools")).toBeDefined();
|
||||
expect(screen.getByText("Automate")).toBeDefined();
|
||||
expect(screen.getByText("Editor")).toBeDefined();
|
||||
expect(screen.getByText("Files")).toBeDefined();
|
||||
expect(screen.getByText("Settings")).toBeDefined();
|
||||
});
|
||||
|
||||
it("renders as a nav element with fixed positioning", () => {
|
||||
renderNav(() => {});
|
||||
|
||||
const nav = document.querySelector("nav");
|
||||
expect(nav).not.toBeNull();
|
||||
expect(nav!.className).toContain("fixed");
|
||||
expect(nav!.className).toContain("bottom-0");
|
||||
});
|
||||
|
||||
it("navigation links have correct href targets", () => {
|
||||
renderNav(() => {});
|
||||
|
||||
const links = document.querySelectorAll("a");
|
||||
const hrefs = Array.from(links).map((a) => a.getAttribute("href"));
|
||||
|
||||
expect(hrefs).toContain("/");
|
||||
expect(hrefs).toContain("/automate");
|
||||
expect(hrefs).toContain("/editor");
|
||||
expect(hrefs).toContain("/files");
|
||||
});
|
||||
|
||||
it("settings button calls onSettingsClick when clicked", () => {
|
||||
const onClick = vi.fn();
|
||||
renderNav(onClick);
|
||||
|
||||
const settingsBtn = screen.getByText("Settings");
|
||||
fireEvent.click(settingsBtn);
|
||||
expect(onClick).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("settings button is hidden when onSettingsClick is not provided", () => {
|
||||
renderNav();
|
||||
|
||||
// Without onSettingsClick, the settings button should not render
|
||||
expect(screen.queryByText("Settings")).toBeNull();
|
||||
});
|
||||
|
||||
it("renders icons for each navigation item", () => {
|
||||
renderNav(() => {});
|
||||
|
||||
// 4 items use lucide SVG icons (Tools, Automate, Files, Settings)
|
||||
// Editor uses ImageEditIcon which is a CSS-masked <span>, not SVG
|
||||
const svgs = document.querySelectorAll("nav svg");
|
||||
expect(svgs.length).toBe(4);
|
||||
|
||||
// The Editor icon is a span with a mask-image
|
||||
const spans = document.querySelectorAll("nav span");
|
||||
const maskedSpan = Array.from(spans).find((s) => (s as HTMLElement).style.maskImage !== "");
|
||||
expect(maskedSpan).toBeDefined();
|
||||
});
|
||||
|
||||
it("nav has backdrop blur and border-top styling", () => {
|
||||
renderNav(() => {});
|
||||
|
||||
const nav = document.querySelector("nav") as HTMLElement;
|
||||
expect(nav).not.toBeNull();
|
||||
// The component applies bg-background/95 backdrop-blur-sm border-t
|
||||
expect(nav.className).toContain("backdrop-blur");
|
||||
expect(nav.className).toContain("border-t");
|
||||
expect(nav.className).toContain("z-30");
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,162 @@
|
||||
// @vitest-environment jsdom
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Mock window.matchMedia for controlled breakpoint testing
|
||||
// ---------------------------------------------------------------------------
|
||||
let currentMatches = false;
|
||||
const listeners = new Map<string, Set<(e: MediaQueryListEvent) => void>>();
|
||||
|
||||
function createMockMql(query: string): MediaQueryList {
|
||||
if (!listeners.has(query)) {
|
||||
listeners.set(query, new Set());
|
||||
}
|
||||
return {
|
||||
matches: currentMatches,
|
||||
media: query,
|
||||
onchange: null,
|
||||
addEventListener: (_: string, handler: (e: MediaQueryListEvent) => void) => {
|
||||
listeners.get(query)!.add(handler);
|
||||
},
|
||||
removeEventListener: (_: string, handler: (e: MediaQueryListEvent) => void) => {
|
||||
listeners.get(query)!.delete(handler);
|
||||
},
|
||||
addListener: vi.fn(),
|
||||
removeListener: vi.fn(),
|
||||
dispatchEvent: vi.fn(),
|
||||
} as unknown as MediaQueryList;
|
||||
}
|
||||
|
||||
function fireMediaChange(query: string, matches: boolean) {
|
||||
currentMatches = matches;
|
||||
const set = listeners.get(query);
|
||||
if (set) {
|
||||
for (const handler of set) {
|
||||
handler({ matches, media: query } as MediaQueryListEvent);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
describe("use-mobile hook", () => {
|
||||
beforeEach(() => {
|
||||
currentMatches = false;
|
||||
listeners.clear();
|
||||
vi.stubGlobal(
|
||||
"matchMedia",
|
||||
vi.fn((q: string) => createMockMql(q)),
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("exports MOBILE_BREAKPOINT at 768", async () => {
|
||||
// The hook uses max-width: 767px (MOBILE_BREAKPOINT - 1)
|
||||
const mod = await import("@/hooks/use-mobile");
|
||||
// useMobile calls useMediaQuery with `(max-width: 767px)`
|
||||
expect(mod.useMobile).toBeDefined();
|
||||
});
|
||||
|
||||
it("useMobile returns false when viewport >= 768px (desktop)", async () => {
|
||||
// Viewport wider than breakpoint: matchMedia returns false
|
||||
currentMatches = false;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(false);
|
||||
});
|
||||
|
||||
it("useMobile returns true when viewport < 768px (mobile)", async () => {
|
||||
// Viewport narrower than breakpoint: matchMedia returns true
|
||||
currentMatches = true;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(true);
|
||||
});
|
||||
|
||||
it("useMediaQuery updates when media query changes", async () => {
|
||||
currentMatches = false;
|
||||
const { renderHook, act } = await import("@testing-library/react");
|
||||
const { useMediaQuery } = await import("@/hooks/use-mobile");
|
||||
|
||||
const query = "(max-width: 767px)";
|
||||
const { result } = renderHook(() => useMediaQuery(query));
|
||||
expect(result.current).toBe(false);
|
||||
|
||||
// Simulate viewport shrinking below breakpoint
|
||||
await act(() => {
|
||||
fireMediaChange(query, true);
|
||||
});
|
||||
expect(result.current).toBe(true);
|
||||
|
||||
// Simulate viewport growing above breakpoint
|
||||
await act(() => {
|
||||
fireMediaChange(query, false);
|
||||
});
|
||||
expect(result.current).toBe(false);
|
||||
});
|
||||
|
||||
it("useTouchDevice returns true for coarse pointer", async () => {
|
||||
currentMatches = true;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useTouchDevice } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useTouchDevice());
|
||||
expect(result.current).toBe(true);
|
||||
});
|
||||
|
||||
it("useTouchDevice returns false for fine pointer (desktop)", async () => {
|
||||
currentMatches = false;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useTouchDevice } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useTouchDevice());
|
||||
expect(result.current).toBe(false);
|
||||
});
|
||||
|
||||
// Device-specific breakpoint validation
|
||||
describe("device breakpoint classification", () => {
|
||||
it("Pixel 7 (412px) is classified as mobile", async () => {
|
||||
// 412 < 768, so max-width:767px matches
|
||||
currentMatches = true;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(true);
|
||||
});
|
||||
|
||||
it("iPhone 14 (390px) is classified as mobile", async () => {
|
||||
currentMatches = true;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(true);
|
||||
});
|
||||
|
||||
it("Galaxy Tab S9 (640px) is classified as mobile", async () => {
|
||||
// 640 < 768, so max-width:767px matches -> mobile!
|
||||
currentMatches = true;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(true);
|
||||
});
|
||||
|
||||
it("iPad gen 7 (810px) is NOT classified as mobile", async () => {
|
||||
// 810 >= 768, so max-width:767px does NOT match -> not mobile
|
||||
currentMatches = false;
|
||||
const { renderHook } = await import("@testing-library/react");
|
||||
const { useMobile } = await import("@/hooks/use-mobile");
|
||||
|
||||
const { result } = renderHook(() => useMobile());
|
||||
expect(result.current).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user