External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(resize): add aspect-ratio proportion presets (#530)

Browse Source 
Add a proportion chip row (Free, Original, 1:1, 4:3, 3:2, 16:9, 3:4, 9:16) to the Resize tool's Custom tab. Picking a ratio locks width and height so editing one recomputes the other, and prefills the largest box of that ratio that fits the source so it never upscales. Free stays the default, preserving existing behavior. Replaces the previously non-functional lock-aspect button. Frontend only, no backend or schema change; adds strings to all 21 locales.
This commit is contained in:
SnapOtter
2026-07-16 16:12:08 +08:00
committed by GitHub
parent 0e608e1524
commit d88999e7a9
25 changed files with 317 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/gui-tools-essential.spec.ts
+18 -11
View File
@@ -823,18 +823,25 @@ test.describe("GUI Essential Tools", () => {
// RESIZE: LINKED ASPECT RATIO AUTO-UPDATE
// ========================================================================
test.describe("Resize Aspect Ratio Linked Fields", () => {
// The resize component stores lockAspect as UI state but does not
// auto-compute the paired dimension on input change. The width/height
// onChange handlers call setWidth/setHeight independently. Linked
// auto-update is not implemented in the current component, so these
// tests cannot pass until that feature is added.
test.skip("width auto-updates height when aspect ratio locked", async ({
loggedInPage: _page,
}) => {});
// Selecting a ratio chip on the Custom tab locks the width/height fields:
// editing one recomputes the other. 16:9 is fixture-independent (1600 -> 900).
test("width auto-updates height when a ratio is locked", async ({ loggedInPage: page }) => {
await page.goto("/image/resize");
await uploadTestImage(page);
test.skip("height auto-updates width when aspect ratio locked", async ({
loggedInPage: _page,
}) => {});
await page.getByRole("button", { name: "16:9", exact: true }).click();
await page.locator("#resize-width").fill("1600");
await expect(page.locator("#resize-height")).toHaveValue("900");
});
test("height auto-updates width when a ratio is locked", async ({ loggedInPage: page }) => {
await page.goto("/image/resize");
await uploadTestImage(page);
await page.getByRole("button", { name: "16:9", exact: true }).click();
await page.locator("#resize-height").fill("900");
await expect(page.locator("#resize-width")).toHaveValue("1600");
});
});
// ========================================================================