External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent hydration effect from overwriting user consent actions

Browse Source
This commit is contained in:
ashim-hq
2026-04-23 11:14:48 +08:00
parent fc059c751d
commit d543141d19
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/App.tsx
+10 -2
View File
@@ -87,15 +87,23 @@ function AuthGuard({ children }: { children: React.ReactNode }) {
const setStoreConsent = useAnalyticsStore((s) => s.setConsent); const setStoreConsent = useAnalyticsStore((s) => s.setConsent);
const location = useLocation(); const location = useLocation();
// Hydrate the analytics store from session data on initial load // Hydrate the analytics store from session data on initial load.
// Only hydrate if the store is still in its initial state (user hasn't taken
// an explicit action like accepting/declining on the consent page).
useEffect(() => { useEffect(() => {
if (!loading && analyticsEnabled !== undefined) { if (
!loading &&
analyticsEnabled !== undefined &&
storeConsent.analyticsConsentShownAt === null &&
storeConsent.analyticsEnabled === null
) {
setStoreConsent({ setStoreConsent({
analyticsEnabled: analyticsEnabled ?? null, analyticsEnabled: analyticsEnabled ?? null,
analyticsConsentShownAt: analyticsConsentShownAt ?? null, analyticsConsentShownAt: analyticsConsentShownAt ?? null,
analyticsConsentRemindAt: null, analyticsConsentRemindAt: null,
}); });
} }
// eslint-disable-next-line -- only hydrate on session load, not on store changes
}, [loading, analyticsEnabled, analyticsConsentShownAt, setStoreConsent]); }, [loading, analyticsEnabled, analyticsConsentShownAt, setStoreConsent]);
// Don't guard the login or change-password pages // Don't guard the login or change-password pages