mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix: custom logo not showing in sidebar and silent upload failures
The desktop sidebar never rendered the custom logo because only mobile views used the customLogo state. Added a logo section at the top of the desktop sidebar that displays the custom logo (or the default OtterLogo when none is set). The upload handler used raw fetch() without checking response.ok, so HTTP 4xx errors (e.g. file too large) were silently ignored and the UI falsely reported success. Now checks response status and surfaces the server error message. Closes #125
This commit is contained in:
@@ -258,6 +258,125 @@ describe("POST /api/v1/settings/logo", () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// Settings state verification (customLogo flag)
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("customLogo setting reflects actual state", () => {
|
||||
it("sets customLogo to true after successful upload", async () => {
|
||||
const png = await makeTestPng();
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "logo.png", contentType: "image/png", content: png },
|
||||
]);
|
||||
|
||||
const uploadRes = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: {
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
"content-type": contentType,
|
||||
},
|
||||
payload: body,
|
||||
});
|
||||
expect(uploadRes.statusCode).toBe(200);
|
||||
|
||||
const settingsRes = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/v1/settings",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
const { settings } = JSON.parse(settingsRes.body);
|
||||
expect(settings.customLogo).toBe("true");
|
||||
});
|
||||
|
||||
it("does not set customLogo to true when upload is rejected (oversized)", async () => {
|
||||
// First ensure no logo exists
|
||||
await app.inject({
|
||||
method: "DELETE",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
const largePng = await sharp({
|
||||
create: { width: 500, height: 500, channels: 4, background: { r: 0, g: 0, b: 0, alpha: 1 } },
|
||||
})
|
||||
.png({ compressionLevel: 0 })
|
||||
.toBuffer();
|
||||
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "big.png", contentType: "image/png", content: largePng },
|
||||
]);
|
||||
|
||||
const uploadRes = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: {
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
"content-type": contentType,
|
||||
},
|
||||
payload: body,
|
||||
});
|
||||
expect(uploadRes.statusCode).toBe(400);
|
||||
|
||||
const settingsRes = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/v1/settings",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
const { settings } = JSON.parse(settingsRes.body);
|
||||
expect(settings.customLogo).not.toBe("true");
|
||||
});
|
||||
|
||||
it("sets customLogo to false after deletion", async () => {
|
||||
// Upload first
|
||||
const png = await makeTestPng();
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "logo.png", contentType: "image/png", content: png },
|
||||
]);
|
||||
|
||||
await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: {
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
"content-type": contentType,
|
||||
},
|
||||
payload: body,
|
||||
});
|
||||
|
||||
// Delete
|
||||
await app.inject({
|
||||
method: "DELETE",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
const settingsRes = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/v1/settings",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
const { settings } = JSON.parse(settingsRes.body);
|
||||
expect(settings.customLogo).toBe("false");
|
||||
});
|
||||
|
||||
it("returns 400 with clear error when no file is attached", async () => {
|
||||
const { body, contentType } = createMultipartPayload([]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/settings/logo",
|
||||
headers: {
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
"content-type": contentType,
|
||||
},
|
||||
payload: body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
expect(JSON.parse(res.body).error).toMatch(/no file/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// GET /api/v1/settings/logo
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
|
||||
Reference in New Issue
Block a user