External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: release QA hardening across processing, media, security, and CI gates (#649)

Browse Source 
A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
This commit is contained in:
SnapOtter
2026-07-27 15:37:30 +08:00
committed by GitHub
parent bc32f86a07
commit d10d0f544f
855 changed files with 54564 additions and 13092 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/generated/format-matrix-ai.test.ts
+58 -51
View File
@@ -22,6 +22,7 @@ import { join } from "node:path";
import { apiToolPath } from "@snapotter/shared";
import { afterAll, beforeAll, describe, expect, it } from "vitest";
import { fixtureDir, fixtures } from "../../fixtures/index.js";
import { featureUnavailableDisposition } from "../../helpers/generated-case-accounting.js";
import { cancelAcceptedJobAndWait } from "../settle-job.js";
import {
buildTestApp,
@@ -337,7 +338,8 @@ const AI_TOOLS: AiToolDef[] = [
* - 422: processing error (format decode failure, etc.)
* - 501: AI feature not installed (FEATURE_NOT_INSTALLED)
*/
const ACCEPTABLE_AI_CODES = [200, 202, 400, 422, 501];
const ACCEPTABLE_AI_CODES = [200, 202, 400, 422];
const REQUIRE_AI_FEATURES = process.env.REQUIRE_AI_FEATURES === "1";
// ---------------------------------------------------------------------------
// Helpers
@@ -354,6 +356,22 @@ function getToolUrl(toolId: string): string {
return apiToolPath(toolId);
}
function featurePrerequisiteSkipReason(
toolId: string,
statusCode: number,
body: Record<string, unknown>,
): string | undefined {
const disposition = featureUnavailableDisposition({
toolId,
statusCode,
code: body.code,
requireAiFeatures: REQUIRE_AI_FEATURES,
});
return disposition === "skip"
? `${toolId}: optional AI prerequisite absent; set REQUIRE_AI_FEATURES=1 after install`
: undefined;
}
/**
* Build multipart payload for an AI tool request.
* Handles the mask requirement for erase-object.
@@ -435,8 +453,10 @@ describe("AI tool cross-format matrix", () => {
it(
`${tool.label}`,
async () => {
if (!existsSync(fixturePath)) return;
async (context) => {
if (!existsSync(fixturePath)) {
return context.skip(`${tool.id}: missing fixture ${fmt.file}`);
}
const buffer = readFileSync(fixturePath);
const { body: payload, contentType } = buildAiPayload(
@@ -461,20 +481,17 @@ describe("AI tool cross-format matrix", () => {
500,
);
const responseBody = JSON.parse(res.body) as Record<string, unknown>;
const skipReason = featurePrerequisiteSkipReason(tool.id, res.statusCode, responseBody);
if (skipReason) return context.skip(skipReason);
// Must be one of the acceptable codes
expect(ACCEPTABLE_AI_CODES).toContain(res.statusCode);
// Response must always be valid JSON
const body = JSON.parse(res.body);
const body = responseBody;
if (res.statusCode === 501) {
// The optional runtime may be absent or present for another
// platform (for example, Linux bundles on a macOS developer
// machine). Both are truthful ingress outcomes for this matrix.
expect(["FEATURE_NOT_INSTALLED", "FEATURE_INCOMPATIBLE"]).toContain(body.code);
expect(body.error).toBeDefined();
expect(typeof body.error).toBe("string");
} else if (res.statusCode === 202) {
if (res.statusCode === 202) {
// Async processing accepted
expect(body.jobId).toBeDefined();
expect(typeof body.jobId).toBe("string");
@@ -508,7 +525,7 @@ describe("AI tool cross-format matrix", () => {
// ---------------------------------------------------------------------------
describe("Missing file returns 400", () => {
for (const tool of AI_TOOLS) {
it(`${tool.label}: no file -> 400`, async () => {
it(`${tool.label}: no file -> 400`, async (context) => {
// Send empty multipart with only settings
const fields: Array<{
name: string;
@@ -544,14 +561,10 @@ describe("Missing file returns 400", () => {
body: payload,
});
// Tools with 501 guard may return 501 before checking for file
if (tool.has501Guard) {
expect([400, 501]).toContain(res.statusCode);
} else {
expect(res.statusCode).toBe(400);
}
const body = JSON.parse(res.body);
const body = JSON.parse(res.body) as Record<string, unknown>;
const skipReason = featurePrerequisiteSkipReason(tool.id, res.statusCode, body);
if (skipReason) return context.skip(skipReason);
expect(res.statusCode).toBe(400);
expect(body.error).toBeDefined();
expect(typeof body.error).toBe("string");
});
@@ -563,9 +576,9 @@ describe("Missing file returns 400", () => {
// ---------------------------------------------------------------------------
describe("Unauthenticated requests return 401", () => {
for (const tool of AI_TOOLS) {
it(`${tool.label}: no auth -> 401`, async () => {
it(`${tool.label}: no auth -> 401`, async (context) => {
const fixturePath = fixtures.image.formats("png");
if (!existsSync(fixturePath)) return;
if (!existsSync(fixturePath)) return context.skip(`${tool.id}: missing fixture sample.png`);
const buffer = readFileSync(fixturePath);
const fmt = FORMAT_SAMPLES.find((f) => f.file === "sample.png")!;
@@ -602,9 +615,9 @@ describe("Invalid settings return 400", () => {
);
for (const tool of TOOLS_WITH_INVALID_SETTINGS) {
it(`${tool.label}: invalid settings -> 400`, async () => {
it(`${tool.label}: invalid settings -> 400`, async (context) => {
const fixturePath = fixtures.image.formats("png");
if (!existsSync(fixturePath)) return;
if (!existsSync(fixturePath)) return context.skip(`${tool.id}: missing fixture sample.png`);
const buffer = readFileSync(fixturePath);
@@ -648,14 +661,10 @@ describe("Invalid settings return 400", () => {
body: payload,
});
// Tools with 501 guard may return 501 before validating settings
if (tool.has501Guard) {
expect([400, 501]).toContain(res.statusCode);
} else {
expect(res.statusCode).toBe(400);
}
const body = JSON.parse(res.body);
const body = JSON.parse(res.body) as Record<string, unknown>;
const skipReason = featurePrerequisiteSkipReason(tool.id, res.statusCode, body);
if (skipReason) return context.skip(skipReason);
expect(res.statusCode).toBe(400);
expect(body.error).toBeDefined();
expect(typeof body.error).toBe("string");
});
@@ -666,9 +675,9 @@ describe("Invalid settings return 400", () => {
// Erase-object specific: missing mask -> 400
// ---------------------------------------------------------------------------
describe("Erase-object missing mask returns 400", () => {
it("erase-object without mask file -> 400 or 501", async () => {
it("erase-object without mask file -> 400", async (context) => {
const fixturePath = fixtures.image.formats("png");
if (!existsSync(fixturePath)) return;
if (!existsSync(fixturePath)) return context.skip("erase-object: missing fixture sample.png");
const buffer = readFileSync(fixturePath);
const { body: payload, contentType } = createMultipartPayload([
@@ -690,10 +699,10 @@ describe("Erase-object missing mask returns 400", () => {
body: payload,
});
// 501 if AI not installed, 400 if validation catches missing mask
expect([400, 501]).toContain(res.statusCode);
const body = JSON.parse(res.body);
const body = JSON.parse(res.body) as Record<string, unknown>;
const skipReason = featurePrerequisiteSkipReason("erase-object", res.statusCode, body);
if (skipReason) return context.skip(skipReason);
expect(res.statusCode).toBe(400);
expect(body.error).toBeDefined();
expect(typeof body.error).toBe("string");
});
@@ -703,9 +712,11 @@ describe("Erase-object missing mask returns 400", () => {
// Content-aware-resize specific: missing dimensions -> 400
// ---------------------------------------------------------------------------
describe("Content-aware-resize without dimensions returns 400", () => {
it("content-aware-resize without width/height/square -> 400", async () => {
it("content-aware-resize without width/height/square -> 400", async (context) => {
const fixturePath = fixtures.image.formats("png");
if (!existsSync(fixturePath)) return;
if (!existsSync(fixturePath)) {
return context.skip("content-aware-resize: missing fixture sample.png");
}
const buffer = readFileSync(fixturePath);
const { body: payload, contentType } = createMultipartPayload([
@@ -749,9 +760,9 @@ describe("Malformed JSON settings return 400", () => {
).slice(0, 5);
for (const tool of REPRESENTATIVE_TOOLS) {
it(`${tool.label}: malformed JSON settings -> 400 or 501`, async () => {
it(`${tool.label}: malformed JSON settings -> 400`, async (context) => {
const fixturePath = fixtures.image.formats("png");
if (!existsSync(fixturePath)) return;
if (!existsSync(fixturePath)) return context.skip(`${tool.id}: missing fixture sample.png`);
const buffer = readFileSync(fixturePath);
const { body: payload, contentType } = createMultipartPayload([
@@ -777,14 +788,10 @@ describe("Malformed JSON settings return 400", () => {
body: payload,
});
// 501 if AI not installed, 400 for malformed JSON
if (tool.has501Guard) {
expect([400, 501]).toContain(res.statusCode);
} else {
expect(res.statusCode).toBe(400);
}
const body = JSON.parse(res.body);
const body = JSON.parse(res.body) as Record<string, unknown>;
const skipReason = featurePrerequisiteSkipReason(tool.id, res.statusCode, body);
if (skipReason) return context.skip(skipReason);
expect(res.statusCode).toBe(400);
expect(body.error).toBeDefined();
expect(typeof body.error).toBe("string");
});