mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
This commit is contained in:
@@ -1,25 +1,44 @@
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { existsSync } from "node:fs";
|
||||
import { join } from "node:path";
|
||||
import { posix, win32 } from "node:path";
|
||||
|
||||
interface PythonResolutionOptions {
|
||||
cwd?: string;
|
||||
env?: NodeJS.ProcessEnv;
|
||||
fileExists?: (path: string) => boolean;
|
||||
locate?: (command: "where" | "which", executable: "python" | "python3") => readonly string[];
|
||||
platform?: NodeJS.Platform;
|
||||
}
|
||||
|
||||
function locatePython(command: "where" | "which", executable: "python" | "python3"): string[] {
|
||||
const result = spawnSync(command, [executable], { encoding: "utf8" });
|
||||
if (result.status !== 0 || typeof result.stdout !== "string") return [];
|
||||
return result.stdout
|
||||
.split(/\r?\n/u)
|
||||
.map((path) => path.trim())
|
||||
.filter(Boolean);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve a Python 3 binary path that actually exists.
|
||||
* Checks the configured venv first, then falls back to system python3.
|
||||
* Returns null when no usable python3 is found.
|
||||
*/
|
||||
function resolvePython(): string | null {
|
||||
const venv = process.env.PYTHON_VENV_PATH || join(process.cwd(), ".venv");
|
||||
if (existsSync(`${venv}/bin/python3`)) return `${venv}/bin/python3`;
|
||||
const res = spawnSync("which", ["python3"], { encoding: "utf8" });
|
||||
if (res.status === 0 && res.stdout.trim()) {
|
||||
const bin = res.stdout.trim();
|
||||
const parts = bin.split("/");
|
||||
if (parts.length >= 3) {
|
||||
const prefix = parts.slice(0, -2).join("/");
|
||||
if (existsSync(`${prefix}/bin/python3`)) return `${prefix}/bin/python3`;
|
||||
}
|
||||
}
|
||||
return null;
|
||||
export function resolvePython({
|
||||
cwd = process.cwd(),
|
||||
env = process.env,
|
||||
fileExists = existsSync,
|
||||
locate = locatePython,
|
||||
platform = process.platform,
|
||||
}: PythonResolutionOptions = {}): string | null {
|
||||
const path = platform === "win32" ? win32 : posix;
|
||||
const venv = env.PYTHON_VENV_PATH || path.join(cwd, ".venv");
|
||||
const venvPython = path.join(venv, platform === "win32" ? "Scripts/python.exe" : "bin/python3");
|
||||
if (fileExists(venvPython)) return venvPython;
|
||||
|
||||
const locator = platform === "win32" ? "where" : "which";
|
||||
const executable = platform === "win32" ? "python" : "python3";
|
||||
return locate(locator, executable).find(fileExists) ?? null;
|
||||
}
|
||||
|
||||
export const pythonBin = resolvePython();
|
||||
@@ -34,3 +53,51 @@ export function pythonWith(mod: string): boolean {
|
||||
export const hasPython = pythonBin !== null;
|
||||
export const hasFitz = hasPython && pythonWith("fitz");
|
||||
export const hasPikepdf = hasPython && pythonWith("pikepdf");
|
||||
|
||||
export interface GeneratedPythonCapabilities {
|
||||
fitz: boolean;
|
||||
markdown: boolean;
|
||||
pdf2docx: boolean;
|
||||
pikepdf: boolean;
|
||||
weasyprint: boolean;
|
||||
}
|
||||
|
||||
const GENERATED_PYTHON_CAPABILITIES: GeneratedPythonCapabilities = {
|
||||
fitz: hasFitz,
|
||||
markdown: hasPython && pythonWith("markdown"),
|
||||
pdf2docx: hasPython && pythonWith("pdf2docx"),
|
||||
pikepdf: hasPikepdf,
|
||||
weasyprint: hasPython && pythonWith("weasyprint"),
|
||||
};
|
||||
|
||||
const GENERATED_TOOL_MODULES: Readonly<
|
||||
Record<string, readonly (keyof GeneratedPythonCapabilities)[]>
|
||||
> = {
|
||||
"flatten-pdf": ["fitz"],
|
||||
"html-to-pdf": ["weasyprint"],
|
||||
"markdown-to-pdf": ["weasyprint", "markdown"],
|
||||
"pdf-metadata": ["pikepdf"],
|
||||
"pdf-to-text": ["fitz"],
|
||||
"pdf-to-word": ["pdf2docx"],
|
||||
"redact-pdf": ["fitz"],
|
||||
"sign-pdf": ["fitz"],
|
||||
};
|
||||
|
||||
/** Return the missing Python module for generated source and HTTP campaigns. */
|
||||
export function findMissingGeneratedPythonPrerequisite(
|
||||
toolId: string,
|
||||
settings: unknown,
|
||||
capabilities: GeneratedPythonCapabilities = GENERATED_PYTHON_CAPABILITIES,
|
||||
): string | undefined {
|
||||
let modules = GENERATED_TOOL_MODULES[toolId];
|
||||
if (toolId === "epub-convert") {
|
||||
const format =
|
||||
settings && typeof settings === "object" && "format" in settings
|
||||
? (settings as { format?: unknown }).format
|
||||
: undefined;
|
||||
modules = format === "pdf" ? ["weasyprint"] : [];
|
||||
}
|
||||
|
||||
const missing = modules?.find((moduleName) => !capabilities[moduleName]);
|
||||
return missing ? `Python module ${missing} is unavailable in this source environment` : undefined;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user