mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
This commit is contained in:
@@ -1,13 +1,12 @@
|
||||
import path from "node:path";
|
||||
import { expect, type Page, test } from "@playwright/test";
|
||||
|
||||
const SCREENSHOT_DIR = path.join(__dirname, "screenshots");
|
||||
let screenshotIndex = 0;
|
||||
let screenshotOutputPath: (filename: string) => string;
|
||||
|
||||
async function snap(page: Page, name: string) {
|
||||
screenshotIndex++;
|
||||
const filename = `${String(screenshotIndex).padStart(2, "0")}-${name}.png`;
|
||||
await page.screenshot({ path: path.join(SCREENSHOT_DIR, filename) });
|
||||
await page.screenshot({ path: screenshotOutputPath(filename) });
|
||||
}
|
||||
|
||||
async function login(page: Page) {
|
||||
@@ -38,8 +37,9 @@ async function getCanvasBox(page: Page) {
|
||||
}
|
||||
|
||||
test.describe("Image Editor - Full GUI Test Suite", () => {
|
||||
test.beforeEach(async ({ page }) => {
|
||||
test.beforeEach(async ({ page }, testInfo) => {
|
||||
screenshotIndex = 0;
|
||||
screenshotOutputPath = (filename) => testInfo.outputPath(filename);
|
||||
await login(page);
|
||||
});
|
||||
|
||||
|
||||
@@ -13,7 +13,7 @@ test.describe("Editor Layers Panel", () => {
|
||||
await expect(layersPanel).toBeVisible();
|
||||
|
||||
// Should have at least one layer with "Layer 1" text
|
||||
const layerRows = layersPanel.locator("[role='option']");
|
||||
const layerRows = layersPanel.locator("[data-layer-id]");
|
||||
await expect(layerRows).toHaveCount(1);
|
||||
await expect(layersPanel.getByText("Layer 1")).toBeVisible();
|
||||
});
|
||||
@@ -27,7 +27,7 @@ test.describe("Editor Layers Panel", () => {
|
||||
|
||||
// Now there should be 2 layers
|
||||
const layersPanel = page.locator("[data-testid='layers-panel']");
|
||||
const layerRows = layersPanel.locator("[role='option']");
|
||||
const layerRows = layersPanel.locator("[data-layer-id]");
|
||||
await expect(layerRows).toHaveCount(2);
|
||||
});
|
||||
|
||||
@@ -50,7 +50,7 @@ test.describe("Editor Layers Panel", () => {
|
||||
|
||||
test("eye icon toggles visibility", async ({ editorPage: page }) => {
|
||||
const layersPanel = page.locator("[data-testid='layers-panel']");
|
||||
const layerRow = layersPanel.locator("[role='option']").first();
|
||||
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
||||
|
||||
// Initially visible (Eye icon, aria-label "Hide layer")
|
||||
const hideBtn = layerRow.locator("button[aria-label='Hide layer']");
|
||||
@@ -73,7 +73,7 @@ test.describe("Editor Layers Panel", () => {
|
||||
|
||||
test("lock icon toggles lock state", async ({ editorPage: page }) => {
|
||||
const layersPanel = page.locator("[data-testid='layers-panel']");
|
||||
const layerRow = layersPanel.locator("[role='option']").first();
|
||||
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
||||
|
||||
// Initially unlocked
|
||||
const lockBtn = layerRow.locator("button[aria-label='Lock layer']");
|
||||
@@ -122,7 +122,7 @@ test.describe("Editor Layers Panel", () => {
|
||||
|
||||
// Double-click the layer name button
|
||||
const nameBtn = layersPanel
|
||||
.locator("[role='option']")
|
||||
.locator("[data-layer-id]")
|
||||
.first()
|
||||
.locator("button")
|
||||
.filter({ hasText: "Layer 1" });
|
||||
@@ -136,8 +136,46 @@ test.describe("Editor Layers Panel", () => {
|
||||
|
||||
test("layer row highlights active layer", async ({ editorPage: page }) => {
|
||||
const layersPanel = page.locator("[data-testid='layers-panel']");
|
||||
const layerRow = layersPanel.locator("[role='option']").first();
|
||||
const layerRow = layersPanel.locator("[data-layer-id]").first();
|
||||
|
||||
await expect(layerRow).toHaveAttribute("aria-selected", "true");
|
||||
await expect(layerRow).toHaveAttribute("aria-current", "true");
|
||||
});
|
||||
|
||||
test("Enter selects an inactive layer from its name button", async ({ editorPage: page }) => {
|
||||
await page.getByTestId("add-layer-btn").click();
|
||||
const layerOne = page.getByTestId(/^layer-name-/).filter({ hasText: "Layer 1" });
|
||||
await expect(layerOne).toHaveAttribute("aria-pressed", "false");
|
||||
|
||||
await layerOne.focus();
|
||||
await page.keyboard.press("Enter");
|
||||
|
||||
await expect(layerOne).toHaveAttribute("aria-pressed", "true");
|
||||
});
|
||||
|
||||
test("Space selects an inactive layer from its name button", async ({ editorPage: page }) => {
|
||||
await page.getByTestId("add-layer-btn").click();
|
||||
const layerOne = page.getByTestId(/^layer-name-/).filter({ hasText: "Layer 1" });
|
||||
await expect(layerOne).toHaveAttribute("aria-pressed", "false");
|
||||
|
||||
await layerOne.focus();
|
||||
await page.keyboard.press("Space");
|
||||
|
||||
await expect(layerOne).toHaveAttribute("aria-pressed", "true");
|
||||
});
|
||||
|
||||
test("keyboard-accessible controls reorder the active layer", async ({ editorPage: page }) => {
|
||||
await page.getByTestId("add-layer-btn").click();
|
||||
const rows = page.locator("[data-layer-id]");
|
||||
await expect(rows).toHaveText(["Layer 2", "Layer 1"]);
|
||||
|
||||
const moveDown = page.getByRole("button", { name: "Move down: Layer 2" });
|
||||
await moveDown.focus();
|
||||
await page.keyboard.press("Enter");
|
||||
await expect(rows).toHaveText(["Layer 1", "Layer 2"]);
|
||||
|
||||
const moveUp = page.getByRole("button", { name: "Move up: Layer 2" });
|
||||
await moveUp.focus();
|
||||
await page.keyboard.press("Space");
|
||||
await expect(rows).toHaveText(["Layer 2", "Layer 1"]);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -71,6 +71,60 @@ test.describe("Editor Navigation", () => {
|
||||
await expect(historyTab).toHaveText("History");
|
||||
});
|
||||
|
||||
test("right panel tabs use roving focus and standard navigation keys", async ({
|
||||
editorPage: page,
|
||||
}) => {
|
||||
const layersTab = page.getByTestId("tab-layers");
|
||||
const adjustmentsTab = page.getByTestId("tab-adjustments");
|
||||
const historyTab = page.getByTestId("tab-history");
|
||||
|
||||
await expect(layersTab).toHaveAttribute("tabindex", "0");
|
||||
await expect(adjustmentsTab).toHaveAttribute("tabindex", "-1");
|
||||
await expect(historyTab).toHaveAttribute("tabindex", "-1");
|
||||
for (const tab of [layersTab, adjustmentsTab, historyTab]) {
|
||||
await expect(tab).toHaveAttribute("aria-controls", "editor-panel");
|
||||
}
|
||||
await expect(page.locator("#editor-panel")).toHaveCount(1);
|
||||
|
||||
await layersTab.focus();
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(adjustmentsTab).toBeFocused();
|
||||
await expect(adjustmentsTab).toHaveAttribute("aria-selected", "true");
|
||||
|
||||
await page.keyboard.press("End");
|
||||
await expect(historyTab).toBeFocused();
|
||||
await expect(historyTab).toHaveAttribute("aria-selected", "true");
|
||||
|
||||
await page.keyboard.press("Home");
|
||||
await expect(layersTab).toBeFocused();
|
||||
await expect(layersTab).toHaveAttribute("aria-selected", "true");
|
||||
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await expect(historyTab).toBeFocused();
|
||||
await expect(historyTab).toHaveAttribute("aria-selected", "true");
|
||||
});
|
||||
|
||||
test("Tab leaves the tablist without collapsing the right panel", async ({
|
||||
editorPage: page,
|
||||
}) => {
|
||||
const layersTab = page.getByTestId("tab-layers");
|
||||
await layersTab.focus();
|
||||
|
||||
await page.keyboard.press("Tab");
|
||||
|
||||
await expect(layersTab).toBeVisible();
|
||||
await expect(page.locator('button[aria-label="Collapse panel"]')).toBeFocused();
|
||||
});
|
||||
|
||||
test("editor skip link focuses the main landmark", async ({ editorPage: page }) => {
|
||||
const skipLink = page.locator('a[href="#main-content"]');
|
||||
await skipLink.focus();
|
||||
|
||||
await page.keyboard.press("Enter");
|
||||
|
||||
await expect(page.locator("#main-content")).toBeFocused();
|
||||
});
|
||||
|
||||
test("right panel collapses and expands", async ({ editorPage: page }) => {
|
||||
// Panel starts visible with tabs
|
||||
await expect(page.locator("[data-testid='tab-layers']")).toBeVisible();
|
||||
|
||||
Reference in New Issue
Block a user