External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: release QA hardening across processing, media, security, and CI gates (#649)

Browse Source 
A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
This commit is contained in:
SnapOtter
2026-07-27 15:37:30 +08:00
committed by GitHub
parent bc32f86a07
commit d10d0f544f
855 changed files with 54564 additions and 13092 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e-docker/embedded-mode.mjs
+103 -40
View File
@@ -7,11 +7,27 @@
// lifecycle: bare-run boot, restart persistence, clean shutdown, the non-root and
// partial-config fail-fast guards, and the 1.x SQLite auto-detect upgrade.
import { execFileSync, spawnSync } from "node:child_process";
import { randomBytes } from "node:crypto";
const IMAGE = process.env.SNAPOTTER_IMAGE || "snapotter:embed-wip";
const NAME = "so-embed-test";
const VOL = "so-embed-test-data";
const PORT = process.env.SNAPOTTER_TEST_PORT || "13492";
const RUN_ID =
process.env.SNAPOTTER_TEST_RUN_ID || `${process.pid}_${randomBytes(6).toString("hex")}`;
if (!/^[A-Za-z0-9][A-Za-z0-9_-]{0,63}$/.test(RUN_ID)) {
throw new Error("SNAPOTTER_TEST_RUN_ID must be 1-64 letters, digits, underscores, or hyphens");
}
const OWNER_LABEL_KEY = "com.snapotter.e2e.run";
const OWNER_LABEL = `${OWNER_LABEL_KEY}=${RUN_ID}`;
const NAME = `so-embed-test-${RUN_ID}`;
const VOL = `so-embed-test-data-${RUN_ID}`;
const requestedPort = process.env.SNAPOTTER_TEST_PORT;
if (requestedPort && !/^\d+$/.test(requestedPort)) {
throw new Error("SNAPOTTER_TEST_PORT must be an integer port");
}
if (requestedPort && (Number(requestedPort) < 1024 || Number(requestedPort) > 65_535)) {
throw new Error("SNAPOTTER_TEST_PORT must be between 1024 and 65535");
}
const PORT_SPEC = requestedPort ? `127.0.0.1:${requestedPort}:1349` : "127.0.0.1::1349";
let PORT = requestedPort || "";
let failures = 0;
const ok = (m) => console.log(` PASS ${m}`);
@@ -46,9 +62,75 @@ const dockerLogs = (name) => {
const res = spawnSync("docker", ["logs", name], { encoding: "utf-8" });
return `${res.stdout || ""}${res.stderr || ""}`;
};
const containerIsOwned = () =>
quiet(["inspect", "--format", `{{ index .Config.Labels "${OWNER_LABEL_KEY}" }}`, NAME]).trim() ===
RUN_ID;
const volumeIsOwned = () =>
quiet([
"volume",
"inspect",
"--format",
`{{ index .Labels "${OWNER_LABEL_KEY}" }}`,
VOL,
]).trim() === RUN_ID;
const cleanup = () => {
quiet(["rm", "-f", NAME]);
quiet(["volume", "rm", VOL]);
if (quiet(["inspect", NAME])) {
if (containerIsOwned()) quiet(["rm", "-f", NAME]);
else console.error(`Refusing to remove unowned container ${NAME}`);
}
if (quiet(["volume", "inspect", VOL])) {
if (volumeIsOwned()) quiet(["volume", "rm", VOL]);
else console.error(`Refusing to remove unowned volume ${VOL}`);
}
};
const exitOnSignal = (exitCode) => {
process.exitCode = exitCode;
cleanup();
process.exit();
};
process.once("SIGINT", () => exitOnSignal(130));
process.once("SIGTERM", () => exitOnSignal(143));
process.once("exit", cleanup);
const createVolume = () => {
if (quiet(["volume", "inspect", VOL])) {
throw new Error(`Unique volume name collision: ${VOL}`);
}
docker(["volume", "create", "--label", OWNER_LABEL, VOL]);
if (!volumeIsOwned()) throw new Error(`Created volume failed ownership validation: ${VOL}`);
};
const resolveContainerPort = () => {
const binding = docker(["port", NAME, "1349/tcp"]).trim();
const match = /^127\.0\.0\.1:(\d+)$/.exec(binding);
if (!match) throw new Error(`Invalid Docker port binding: ${binding}`);
PORT = match[1];
};
const runEmbeddedContainer = () => {
if (quiet(["inspect", NAME])) {
throw new Error(`Unique container name collision: ${NAME}`);
}
docker([
"run",
"-d",
"--name",
NAME,
"--label",
OWNER_LABEL,
"-p",
PORT_SPEC,
"-v",
`${VOL}:/data`,
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]);
if (!containerIsOwned()) {
throw new Error(`Created container failed ownership validation: ${NAME}`);
}
resolveContainerPort();
};
const restartEmbeddedContainer = () => {
docker(["restart", NAME]);
resolveContainerPort();
};
async function waitHealthy(timeoutMs) {
@@ -72,25 +154,13 @@ const countMatches = (haystack, re) => (haystack.match(re) || []).length;
async function main() {
console.log(`Embedded-mode tests against ${IMAGE}`);
cleanup();
createVolume();
// 1. Bare `docker run` with no DB env boots and becomes healthy.
// Prod images bake real telemetry keys, so every container start in this
// harness sets SNAPOTTER_TELEMETRY=0 to keep test-fleet boots silent.
console.log("\n[1] bare docker run boots healthy");
docker([
"run",
"-d",
"--name",
NAME,
"-p",
`${PORT}:1349`,
"-v",
`${VOL}:/data`,
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]);
runEmbeddedContainer();
const healthy = await waitHealthy(300000);
healthy
? ok("embedded container reached healthy")
@@ -104,7 +174,7 @@ async function main() {
// 2. Restart reuses PGDATA (no second initdb), stays healthy.
console.log("\n[2] restart persists data, no re-init");
docker(["restart", NAME]);
restartEmbeddedContainer();
(await waitHealthy(180000)) ? ok("healthy after restart") : bad("unhealthy after restart");
countMatches(dockerLogs(NAME), /first-boot initdb/g) === 1
? ok("no second initdb on restart")
@@ -151,6 +221,7 @@ async function main() {
// this proves the auto-detect wiring (row migration is covered elsewhere).
console.log("\n[6] 1.x SQLite auto-detect upgrade");
cleanup();
createVolume();
const tables = [
"users",
"teams",
@@ -174,19 +245,7 @@ async function main() {
"-c",
`apk add --no-cache sqlite >/dev/null 2>&1 && sqlite3 /data/snapotter.db "${seedSql}"`,
]);
docker([
"run",
"-d",
"--name",
NAME,
"-p",
`${PORT}:1349`,
"-v",
`${VOL}:/data`,
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]);
runEmbeddedContainer();
(await waitHealthy(300000))
? ok("healthy after upgrade boot")
: bad("unhealthy after upgrade boot");
@@ -195,7 +254,7 @@ async function main() {
: bad("did not auto-import the 1.x SQLite DB");
// Second boot must NOT re-import (target Postgres now non-empty).
docker(["restart", NAME]);
restartEmbeddedContainer();
(await waitHealthy(180000))
? ok("healthy after second boot")
: bad("unhealthy after second boot");
@@ -205,11 +264,15 @@ async function main() {
cleanup();
console.log(`\n${failures === 0 ? "ALL PASSED" : `${failures} FAILED`}`);
process.exit(failures === 0 ? 0 : 1);
return failures === 0 ? 0 : 1;
}
main().catch((e) => {
console.error(e);
cleanup();
process.exit(1);
});
main()
.then((exitCode) => {
process.exitCode = exitCode;
})
.catch((e) => {
console.error(e);
process.exitCode = 1;
})
.finally(cleanup);