mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
This commit is contained in:
@@ -1,8 +1,6 @@
|
||||
import { expect, test } from "@playwright/test";
|
||||
import { expect, test } from "./helpers";
|
||||
|
||||
test.describe("QA Fixes Verification", () => {
|
||||
test.use({ storageState: ".playwright/.auth/qa-user.json" });
|
||||
|
||||
test("home page loads after login", async ({ page }) => {
|
||||
await page.goto("/");
|
||||
await page.waitForLoadState("networkidle");
|
||||
@@ -20,13 +18,9 @@ test.describe("QA Fixes Verification", () => {
|
||||
await expect(page.locator("text=Resize").first()).toBeVisible({ timeout: 10_000 });
|
||||
});
|
||||
|
||||
test("/tools/:toolId redirects to /:toolId", async ({ page }) => {
|
||||
test("noncanonical section for a known tool shows not-found state", async ({ page }) => {
|
||||
await page.goto("/tools/resize");
|
||||
await page.waitForTimeout(2_000);
|
||||
const url = page.url();
|
||||
// After the fix, /tools/resize should redirect to /resize
|
||||
// On pre-fix builds, it stays at /tools/resize (treated as unknown tool)
|
||||
expect(url).toContain("/resize");
|
||||
await expect(page.getByText(/tool not found/i)).toBeVisible();
|
||||
});
|
||||
|
||||
test("invalid tool slug shows not-found state", async ({ page }) => {
|
||||
@@ -40,18 +34,12 @@ test.describe("QA Fixes Verification", () => {
|
||||
test("multi-segment invalid URL shows 404 page", async ({ page }) => {
|
||||
await page.goto("/some/deep/nested/invalid/path");
|
||||
await page.waitForLoadState("networkidle");
|
||||
// After the fix, should show 404 page. On pre-fix, shows blank.
|
||||
// At minimum, verify the page has some visible content (not completely blank)
|
||||
const has404 = await page
|
||||
const notFound = page
|
||||
.locator("text=404")
|
||||
.or(page.locator("text=not found"))
|
||||
.or(page.locator("text=Page not found"))
|
||||
.first()
|
||||
.isVisible({ timeout: 5_000 })
|
||||
.catch(() => false);
|
||||
if (!has404) {
|
||||
test.skip(true, "404 catch-all route not present in this build (pre-fix)");
|
||||
}
|
||||
.first();
|
||||
await expect(notFound).toBeVisible({ timeout: 10_000 });
|
||||
});
|
||||
|
||||
test("privacy page renders", async ({ page }) => {
|
||||
|
||||
Reference in New Issue
Block a user