mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into defects a user would hit and gates that were reporting green while measuring nothing. ## Fixes that change behaviour Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so request.ip came from a client-set header and a forged X-Forwarded-For got past the login limiter. The default is now a private-network trust list. A transient Postgres outage stranded in-flight jobs, leaving finished output on disk with no row pointing at it. A reconciler now resolves those rows and adopts the bytes rather than dropping the work. A Redis connection that moved to a new address wedged every read-blocked consumer, so completions stopped signalling while health still answered 200. Socket timeouts plus subscriber pings recover it. Installing more than one AI bundle left the shared venv multi-versioned and silently broke three tools. The installer now reconciles distributions to one version each. Converting an image to JXL at quality 1 through 4 returned a 500, because libjxl 0.7 rejects the distance those values compute. The quality is floored at what the encoder honours. A missing ffmpeg was also reported to the user as a corrupt upload; it now says the engine is unavailable. RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at 0.22.2, and the release scan was split so it can fail on an unfixed critical instead of hiding it behind ignore-unfixed. ## Gates that could not fail Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs build; coverage discarded its whole report on any failing test; the lint gate skipped root tests, scripts, and two workspaces; and several generated matrices counted a host missing ffmpeg as a passing tool. Each now measures what it claims. Full evidence and the outstanding release items are tracked locally and are not part of this branch.
This commit is contained in:
@@ -104,6 +104,15 @@ describe("compress: format selection", () => {
|
||||
const out = await (await compress(sharp(svg), { quality: 80 })).toBuffer();
|
||||
expect(await outputFormat(out)).toBe("png");
|
||||
});
|
||||
|
||||
it.each(["bmp", "heic", "qoi", "../../outside"])(
|
||||
"rejects a runtime-unsupported explicit format (%s)",
|
||||
async (format) => {
|
||||
await expect(
|
||||
compress(sharp(photoPng), { quality: 80, format: format as "jpg" }),
|
||||
).rejects.toThrow(`Unsupported compression format: ${format}`);
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
describe("compress: quality controls output size", () => {
|
||||
@@ -148,22 +157,39 @@ describe("compress: quality clamp boundaries", () => {
|
||||
/between 1 and 100/,
|
||||
);
|
||||
});
|
||||
|
||||
it.each([Number.NaN, Number.POSITIVE_INFINITY, 1.5])(
|
||||
"rejects a non-finite or fractional quality (%s)",
|
||||
async (quality) => {
|
||||
await expect(compress(sharp(photoPng), { quality, format: "jpg" })).rejects.toThrow(
|
||||
"Quality must be an integer between 1 and 100",
|
||||
);
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
describe("compress: target size", () => {
|
||||
it("rejects a non-positive target and accepts the smallest positive target", async () => {
|
||||
it("rejects non-positive and unreachable targets", async () => {
|
||||
await expect(compress(sharp(photoPng), { targetSizeBytes: 0, format: "jpg" })).rejects.toThrow(
|
||||
/greater than 0/,
|
||||
);
|
||||
await expect(compress(sharp(photoPng), { targetSizeBytes: -5, format: "jpg" })).rejects.toThrow(
|
||||
/greater than 0/,
|
||||
);
|
||||
// target=1 is > 0, so it must NOT throw (kills a `<= 0` -> `< 0` mutant).
|
||||
await expect(
|
||||
compress(sharp(photoPng), { targetSizeBytes: 1, format: "jpg" }),
|
||||
).resolves.toBeDefined();
|
||||
await expect(compress(sharp(photoPng), { targetSizeBytes: 1, format: "jpg" })).rejects.toThrow(
|
||||
"Unable to compress image to 1 bytes within safe resize limits",
|
||||
);
|
||||
});
|
||||
|
||||
it.each([Number.NaN, Number.POSITIVE_INFINITY, 1.5])(
|
||||
"rejects a non-finite or fractional target (%s)",
|
||||
async (targetSizeBytes) => {
|
||||
await expect(compress(sharp(photoPng), { targetSizeBytes, format: "jpg" })).rejects.toThrow(
|
||||
"Target size must be a positive integer",
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
it("hits a reachable target without downscaling", async () => {
|
||||
// Target comfortably above the q=1 full-size floor: the quality search
|
||||
// succeeds, dimensions stay full, and the result fits under the target.
|
||||
@@ -190,6 +216,7 @@ describe("compress: target size", () => {
|
||||
expect(meta.height).toBeLessThan(400);
|
||||
// The fallback should still shrink the file well below the original.
|
||||
expect(out.length).toBeLessThan(photoPng.length);
|
||||
expect(out.length).toBeLessThanOrEqual(target);
|
||||
});
|
||||
|
||||
it("a smaller target produces a smaller (or equal) file than a larger target", async () => {
|
||||
|
||||
Reference in New Issue
Block a user