fix: release QA hardening across processing, media, security, and CI gates (#649)

A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
This commit is contained in:
SnapOtter
2026-07-27 15:37:30 +08:00
committed by GitHub
parent bc32f86a07
commit d10d0f544f
855 changed files with 54564 additions and 13092 deletions
+24 -4
View File
@@ -41,6 +41,29 @@ GFPGAN_MODEL_PATH = os.environ.get(
)
def realesrgan_failure_message(error: BaseException) -> str:
"""Say what actually went wrong with Real-ESRGAN, and what to do about it.
Telling someone to install what they already installed sends them in a
circle (AI-20260726-002): on a venv where scipy was carrying two versions
this path fired on an ImportError raised deep inside a package that had been
present the whole time. A missing module or missing weights is the only
shape that really means "not installed"; anything else is an install that is
there and broken, which needs a reinstall rather than an install.
"""
missing = isinstance(error, (ModuleNotFoundError, FileNotFoundError))
remedy = (
"Install the upscale-enhance feature"
if missing
else (
"The upscale-enhance libraries are present but did not load, which usually "
"means a partial or conflicting install. Reinstall it from Settings > AI "
"Features, or use Reset AI Environment if that does not help"
)
)
return f"Real-ESRGAN is not available: {error}. {remedy}, or use model=lanczos for basic upscaling."
def apply_denoise(img, strength):
"""Apply denoising to a PIL image. Uses OpenCV when available, falls back to PIL."""
if strength <= 0:
@@ -236,10 +259,7 @@ def main():
traceback.print_exc(file=sys.stderr)
print(json.dumps({
"success": False,
"error": (
f"Real-ESRGAN is not available: {e}. "
"Install the upscale-enhance feature or use model=lanczos for basic upscaling."
),
"error": realesrgan_failure_message(e),
}))
sys.exit(1)