feat: add OIDC/SSO authentication (#3)

Add OpenID Connect (OIDC) authentication alongside existing
username/password login. Users can log in via any standards-compliant
OIDC provider (Keycloak, Authentik, Authelia, Google, Azure AD, Okta)
while preserving full backward compatibility.

- OIDC Fastify plugin with lazy discovery, PKCE, cookie-based sessions
- Login page OIDC button, auth hook updates, settings dialog badges
- 28 integration tests, OIDC setup guide with provider examples
- Fix pre-existing test failures (content-aware-crop, watermark, SVGZ)
- WAL checkpoint fix for SQLite test stability

Closes #3

# Conflicts:
#	apps/api/src/lib/env.ts
#	apps/api/src/routes/tools/watermark-image.ts
#	pnpm-lock.yaml
#	tests/integration/color-palette.test.ts
#	tests/integration/compare.test.ts
#	tests/integration/watermark-image.test.ts
This commit is contained in:
SnapOtter
2026-05-14 22:31:26 +08:00
32 changed files with 3503 additions and 149 deletions
+3 -2
View File
@@ -158,7 +158,7 @@ describe("Error handling", () => {
expect(result.error).toBeDefined();
});
it("returns 422 for corrupted image data", async () => {
it("returns 400 for corrupted image data", async () => {
const badBuffer = Buffer.from("not an image at all");
const { body: payload, contentType } = makeFilePayload(badBuffer, "bad.png", "image/png");
const res = await app.inject({
@@ -170,7 +170,8 @@ describe("Error handling", () => {
authorization: `Bearer ${adminToken}`,
},
});
expect([400, 422]).toContain(res.statusCode);
// validateImageBuffer catches corrupt data before processing
expect(res.statusCode).toBe(400);
});
});
+8 -7
View File
@@ -463,7 +463,7 @@ describe("Compare", () => {
// ── Branch coverage: multipart parse error (lines 35-39) ────────────
it("returns 422 when corrupt image data fails processing", async () => {
it("returns 400 when corrupt image data fails validation", async () => {
// Create a buffer that looks like an image but corrupts Sharp
const corruptBuffer = Buffer.from("not a real image content at all");
const { body, contentType } = createMultipartPayload([
@@ -481,10 +481,10 @@ describe("Compare", () => {
body,
});
// Returns 400 (invalid image detected at validation) or 422 (processing failure)
expect([400, 422]).toContain(res.statusCode);
// validateImageBuffer catches corrupt data before processing
expect(res.statusCode).toBe(400);
const result = JSON.parse(res.body);
expect(result.error).toMatch(/comparison failed|invalid.*image|unrecognized/i);
expect(result.error).toBeDefined();
});
// ── Branch coverage: 1x1 tiny images (line 117-121 area) ───────────
@@ -649,7 +649,7 @@ describe("Compare", () => {
// ── Branch coverage: both corrupt images fail processing ───────────
it("returns 422 when both images are corrupt", async () => {
it("returns 400 when both images are corrupt", async () => {
const corrupt1 = Buffer.from("this is not an image");
const corrupt2 = Buffer.from("neither is this one");
const { body, contentType } = createMultipartPayload([
@@ -667,9 +667,10 @@ describe("Compare", () => {
body,
});
expect([400, 422]).toContain(res.statusCode);
// validateImageBuffer catches corrupt data before processing
expect(res.statusCode).toBe(400);
const result = JSON.parse(res.body);
expect(result.error).toMatch(/comparison failed|invalid.*image|unrecognized/i);
expect(result.error).toBeDefined();
});
// ── Branch coverage: HEIF content format input ─────────────────────
+902
View File
@@ -0,0 +1,902 @@
/**
* OIDC authentication integration tests.
*
* Strategy:
* - Tests that don't need OIDC routes (password guards, session fields, users
* list) create OIDC users directly in the DB and use the default test app.
* - Tests that need OIDC routes (config endpoint, login redirect) mutate the
* cached `env` object and spin up a separate Fastify instance with OIDC
* routes enabled.
*/
import { randomUUID } from "node:crypto";
import { createServer, type Server } from "node:http";
import { eq } from "drizzle-orm";
import { afterAll, beforeAll, describe, expect, it } from "vitest";
import { env } from "../../apps/api/src/config.js";
import { db, schema } from "../../apps/api/src/db/index.js";
import { buildTestApp, loginAsAdmin, type TestApp } from "./test-server.js";
// ── Helpers ──────────────────────────────────────────────────────────
let testApp: TestApp;
let adminToken: string;
beforeAll(async () => {
testApp = await buildTestApp();
adminToken = await loginAsAdmin(testApp.app);
}, 30_000);
afterAll(async () => {
await testApp.cleanup();
}, 10_000);
/**
* Insert an OIDC-only user directly into the DB (no passwordHash).
* Returns a session token for the user.
*/
function createOidcUser(opts: { username?: string; email?: string; role?: string } = {}): {
userId: string;
username: string;
sessionToken: string;
} {
const userId = randomUUID();
const username = opts.username || `oidc_${Date.now()}_${Math.random().toString(36).slice(2, 6)}`;
db.insert(schema.users)
.values({
id: userId,
username,
passwordHash: null,
role: opts.role || "user",
team: "default-team-00000000",
mustChangePassword: false,
authProvider: "oidc",
externalId: `sub-${userId}`,
email: opts.email || `${username}@example.com`,
})
.run();
// Create a session (simulates what the OIDC callback would do)
const sessionToken = randomUUID();
db.insert(schema.sessions)
.values({
id: sessionToken,
userId,
expiresAt: new Date(Date.now() + 3_600_000),
idToken: "mock-id-token-jwt",
})
.run();
return { userId, username, sessionToken };
}
/**
* Insert a session for an existing user with custom options.
*/
function createOidcSession(
userId: string,
opts: { expiresAt?: Date; idToken?: string | null } = {},
): string {
const sessionToken = randomUUID();
db.insert(schema.sessions)
.values({
id: sessionToken,
userId,
expiresAt: opts.expiresAt ?? new Date(Date.now() + 3_600_000),
idToken: opts.idToken ?? null,
})
.run();
return sessionToken;
}
/**
* Insert a "hybrid" user -- has both a local password AND an OIDC link.
*/
function createHybridUser(
passwordHash: string,
opts: { username?: string; email?: string } = {},
): { userId: string; username: string; sessionToken: string } {
const userId = randomUUID();
const username =
opts.username || `hybrid_${Date.now()}_${Math.random().toString(36).slice(2, 6)}`;
db.insert(schema.users)
.values({
id: userId,
username,
passwordHash,
role: "user",
team: "default-team-00000000",
mustChangePassword: false,
authProvider: "oidc",
externalId: `sub-${userId}`,
email: opts.email || `${username}@example.com`,
})
.run();
const sessionToken = randomUUID();
db.insert(schema.sessions)
.values({
id: sessionToken,
userId,
expiresAt: new Date(Date.now() + 3_600_000),
})
.run();
return { userId, username, sessionToken };
}
// =====================================================================
// SESSION RESPONSE FIELDS
// =====================================================================
describe("Session response fields", () => {
it("returns OIDC fields for an OIDC user session", async () => {
const { sessionToken, username } = createOidcUser();
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
headers: { authorization: `Bearer ${sessionToken}` },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.user.username).toBe(username);
expect(body.user.authProvider).toBe("oidc");
expect(body.user.loginMethod).toBe("oidc");
expect(body.user.hasLocalPassword).toBe(false);
expect(body.user.hasOidcLink).toBe(true);
expect(body.user.email).toMatch(/@example\.com$/);
});
it("returns local fields for a local user session", async () => {
// Admin is a local user
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
headers: { authorization: `Bearer ${adminToken}` },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.user.authProvider).toBe("local");
expect(body.user.loginMethod).toBe("local");
expect(body.user.hasLocalPassword).toBe(true);
expect(body.user.hasOidcLink).toBe(false);
});
it("Bearer token still works for session check", async () => {
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
headers: { authorization: `Bearer ${adminToken}` },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.user.id).toBeTruthy();
expect(body.expiresAt).toBeTruthy();
});
});
// =====================================================================
// PASSWORD GUARDS
// =====================================================================
describe("Password guards for OIDC users", () => {
it("OIDC user (no passwordHash) cannot change password", async () => {
const { sessionToken } = createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: "/api/auth/change-password",
headers: { authorization: `Bearer ${sessionToken}` },
payload: {
currentPassword: "anything",
newPassword: "NewValid1",
},
});
expect(res.statusCode).toBe(400);
const body = JSON.parse(res.body);
expect(body.code).toBe("OIDC_NO_PASSWORD");
});
it("admin cannot reset password for OIDC user", async () => {
const { userId } = createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: `/api/auth/users/${userId}/reset-password`,
headers: { authorization: `Bearer ${adminToken}` },
payload: { newPassword: "NewValid1" },
});
expect(res.statusCode).toBe(400);
const body = JSON.parse(res.body);
expect(body.code).toBe("OIDC_NO_PASSWORD");
});
});
// =====================================================================
// USERS LIST
// =====================================================================
describe("Users list includes OIDC fields", () => {
it("GET /api/auth/users includes authProvider, hasLocalPassword, hasOidcLink", async () => {
const { username: oidcUsername } = createOidcUser();
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/users",
headers: { authorization: `Bearer ${adminToken}` },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
// Find the OIDC user we just created
const oidcEntry = body.users.find((u: any) => u.username === oidcUsername);
expect(oidcEntry).toBeDefined();
expect(oidcEntry.authProvider).toBe("oidc");
expect(oidcEntry.hasLocalPassword).toBe(false);
expect(oidcEntry.hasOidcLink).toBe(true);
expect(oidcEntry.email).toMatch(/@example\.com$/);
// The admin user should be local
const adminEntry = body.users.find((u: any) => u.username === "admin");
expect(adminEntry).toBeDefined();
expect(adminEntry.authProvider).toBe("local");
expect(adminEntry.hasLocalPassword).toBe(true);
expect(adminEntry.hasOidcLink).toBe(false);
});
it("users list does not expose passwordHash or externalId directly", async () => {
createOidcUser();
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/users",
headers: { authorization: `Bearer ${adminToken}` },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
for (const user of body.users) {
expect(user).not.toHaveProperty("passwordHash");
expect(user).not.toHaveProperty("externalId");
}
});
});
// =====================================================================
// BACKWARD COMPATIBILITY
// =====================================================================
describe("Backward compatibility", () => {
it("local login still works when OIDC users exist in the DB", async () => {
// Create an OIDC user (just to prove it doesn't break local login)
createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: "/api/auth/login",
payload: { username: "admin", password: "Adminpass1" },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.token).toBeTruthy();
expect(body.user.username).toBe("admin");
});
it("OIDC user cannot log in via local login (no passwordHash)", async () => {
const { username } = createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: "/api/auth/login",
payload: { username, password: "anything" },
});
// Should fail because passwordHash is null
expect(res.statusCode).toBe(401);
});
});
// =====================================================================
// CONFIG ENDPOINT (requires OIDC_ENABLED = true)
// =====================================================================
describe("Config endpoint with OIDC enabled", () => {
let oidcApp: TestApp;
// Save original env values
const origOidcEnabled = env.OIDC_ENABLED;
const origExternalUrl = env.EXTERNAL_URL;
const origIssuerUrl = env.OIDC_ISSUER_URL;
const origClientId = env.OIDC_CLIENT_ID;
const origClientSecret = env.OIDC_CLIENT_SECRET;
const origProviderName = env.OIDC_PROVIDER_NAME;
beforeAll(async () => {
// Mutate the cached env to enable OIDC for route registration
(env as any).OIDC_ENABLED = true;
(env as any).EXTERNAL_URL = "http://localhost:9999";
(env as any).OIDC_ISSUER_URL = "http://localhost:0";
(env as any).OIDC_CLIENT_ID = "test-client-id";
(env as any).OIDC_CLIENT_SECRET = "test-client-secret";
(env as any).OIDC_PROVIDER_NAME = "TestProvider";
oidcApp = await buildTestApp();
}, 30_000);
afterAll(async () => {
// Restore original env values
(env as any).OIDC_ENABLED = origOidcEnabled;
(env as any).EXTERNAL_URL = origExternalUrl;
(env as any).OIDC_ISSUER_URL = origIssuerUrl;
(env as any).OIDC_CLIENT_ID = origClientId;
(env as any).OIDC_CLIENT_SECRET = origClientSecret;
(env as any).OIDC_PROVIDER_NAME = origProviderName;
await oidcApp.cleanup();
}, 10_000);
it("config returns OIDC fields when enabled", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/v1/config/auth",
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.oidcEnabled).toBe(true);
expect(body.oidcProviderName).toBe("TestProvider");
expect(body.oidcLoginUrl).toBe("/api/auth/oidc/login");
});
it("config does NOT leak OIDC secrets", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/v1/config/auth",
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body).not.toHaveProperty("clientSecret");
expect(body).not.toHaveProperty("oidcClientSecret");
expect(body).not.toHaveProperty("issuerUrl");
expect(body).not.toHaveProperty("oidcIssuerUrl");
});
});
// =====================================================================
// CONFIG ENDPOINT (OIDC disabled -- default)
// =====================================================================
describe("Config endpoint with OIDC disabled", () => {
it("config omits OIDC fields when disabled", async () => {
// The default test app has OIDC_ENABLED=false
const res = await testApp.app.inject({
method: "GET",
url: "/api/v1/config/auth",
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body).not.toHaveProperty("oidcEnabled");
expect(body).not.toHaveProperty("oidcProviderName");
expect(body).not.toHaveProperty("oidcLoginUrl");
expect(body.authEnabled).toBe(true);
});
});
// =====================================================================
// LOGIN REDIRECT (requires OIDC routes + mock OIDC discovery)
// =====================================================================
describe("OIDC login redirect", () => {
let oidcApp: TestApp;
let mockServer: Server;
let mockPort: number;
// Save original env values
const origOidcEnabled = env.OIDC_ENABLED;
const origExternalUrl = env.EXTERNAL_URL;
const origIssuerUrl = env.OIDC_ISSUER_URL;
const origClientId = env.OIDC_CLIENT_ID;
const origClientSecret = env.OIDC_CLIENT_SECRET;
beforeAll(async () => {
// Start a minimal mock OIDC provider that serves discovery only
mockServer = createServer((req, res) => {
if (req.url === "/.well-known/openid-configuration") {
const discovery = {
issuer: `http://localhost:${mockPort}`,
authorization_endpoint: `http://localhost:${mockPort}/authorize`,
token_endpoint: `http://localhost:${mockPort}/token`,
jwks_uri: `http://localhost:${mockPort}/jwks`,
response_types_supported: ["code"],
subject_types_supported: ["public"],
id_token_signing_alg_values_supported: ["RS256"],
code_challenge_methods_supported: ["S256"],
};
res.writeHead(200, { "Content-Type": "application/json" });
res.end(JSON.stringify(discovery));
return;
}
if (req.url === "/jwks") {
res.writeHead(200, { "Content-Type": "application/json" });
res.end(JSON.stringify({ keys: [] }));
return;
}
res.writeHead(404);
res.end();
});
// Bind to random port
await new Promise<void>((resolve) => {
mockServer.listen(0, "127.0.0.1", () => {
const addr = mockServer.address();
mockPort = typeof addr === "object" && addr ? addr.port : 0;
resolve();
});
});
// Mutate the cached env to enable OIDC
(env as any).OIDC_ENABLED = true;
(env as any).EXTERNAL_URL = "http://localhost:9999";
(env as any).OIDC_ISSUER_URL = `http://localhost:${mockPort}`;
(env as any).OIDC_CLIENT_ID = "test-client-id";
(env as any).OIDC_CLIENT_SECRET = "test-client-secret";
// Clear the cached OIDC config so discovery hits our mock
const oidcModule = await import("../../apps/api/src/plugins/oidc.js");
// The module caches config in a module-level variable; rebuild app to get fresh routes
oidcApp = await buildTestApp();
}, 30_000);
afterAll(async () => {
// Restore original env values
(env as any).OIDC_ENABLED = origOidcEnabled;
(env as any).EXTERNAL_URL = origExternalUrl;
(env as any).OIDC_ISSUER_URL = origIssuerUrl;
(env as any).OIDC_CLIENT_ID = origClientId;
(env as any).OIDC_CLIENT_SECRET = origClientSecret;
await oidcApp.cleanup();
await new Promise<void>((resolve) => mockServer.close(() => resolve()));
}, 10_000);
it("GET /api/auth/oidc/login returns 302 redirect to IdP", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/auth/oidc/login",
});
// Should redirect to the mock IdP's authorization endpoint
expect(res.statusCode).toBe(302);
const location = res.headers.location as string;
expect(location).toBeTruthy();
const redirectUrl = new URL(location);
expect(redirectUrl.origin).toBe(`http://localhost:${mockPort}`);
expect(redirectUrl.pathname).toBe("/authorize");
// Verify required OIDC params
expect(redirectUrl.searchParams.get("client_id")).toBe("test-client-id");
expect(redirectUrl.searchParams.get("redirect_uri")).toBe(
"http://localhost:9999/api/auth/oidc/callback",
);
expect(redirectUrl.searchParams.get("response_type")).toBe("code");
expect(redirectUrl.searchParams.get("scope")).toContain("openid");
expect(redirectUrl.searchParams.get("state")).toBeTruthy();
expect(redirectUrl.searchParams.get("nonce")).toBeTruthy();
expect(redirectUrl.searchParams.get("code_challenge")).toBeTruthy();
expect(redirectUrl.searchParams.get("code_challenge_method")).toBe("S256");
});
it("login redirect sets oidc-state cookie", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/auth/oidc/login",
});
expect(res.statusCode).toBe(302);
// Check for oidc-state cookie in Set-Cookie header
const cookies = res.headers["set-cookie"];
const cookieStr = Array.isArray(cookies) ? cookies.join("; ") : cookies || "";
expect(cookieStr).toContain("oidc-state=");
expect(cookieStr).toContain("HttpOnly");
expect(cookieStr).toContain("SameSite=Lax");
});
});
// =====================================================================
// OIDC CALLBACK EDGE CASES (without a full mock provider)
// =====================================================================
describe("OIDC callback edge cases", () => {
let oidcApp: TestApp;
let mockServer: Server;
let mockPort: number;
// Save original env values
const origOidcEnabled = env.OIDC_ENABLED;
const origExternalUrl = env.EXTERNAL_URL;
const origIssuerUrl = env.OIDC_ISSUER_URL;
const origClientId = env.OIDC_CLIENT_ID;
const origClientSecret = env.OIDC_CLIENT_SECRET;
beforeAll(async () => {
// Minimal mock server for discovery
mockServer = createServer((req, res) => {
if (req.url === "/.well-known/openid-configuration") {
const discovery = {
issuer: `http://localhost:${mockPort}`,
authorization_endpoint: `http://localhost:${mockPort}/authorize`,
token_endpoint: `http://localhost:${mockPort}/token`,
jwks_uri: `http://localhost:${mockPort}/jwks`,
response_types_supported: ["code"],
subject_types_supported: ["public"],
id_token_signing_alg_values_supported: ["RS256"],
code_challenge_methods_supported: ["S256"],
};
res.writeHead(200, { "Content-Type": "application/json" });
res.end(JSON.stringify(discovery));
return;
}
if (req.url === "/jwks") {
res.writeHead(200, { "Content-Type": "application/json" });
res.end(JSON.stringify({ keys: [] }));
return;
}
res.writeHead(404);
res.end();
});
await new Promise<void>((resolve) => {
mockServer.listen(0, "127.0.0.1", () => {
const addr = mockServer.address();
mockPort = typeof addr === "object" && addr ? addr.port : 0;
resolve();
});
});
(env as any).OIDC_ENABLED = true;
(env as any).EXTERNAL_URL = "http://localhost:9999";
(env as any).OIDC_ISSUER_URL = `http://localhost:${mockPort}`;
(env as any).OIDC_CLIENT_ID = "test-client-id";
(env as any).OIDC_CLIENT_SECRET = "test-client-secret";
oidcApp = await buildTestApp();
}, 30_000);
afterAll(async () => {
(env as any).OIDC_ENABLED = origOidcEnabled;
(env as any).EXTERNAL_URL = origExternalUrl;
(env as any).OIDC_ISSUER_URL = origIssuerUrl;
(env as any).OIDC_CLIENT_ID = origClientId;
(env as any).OIDC_CLIENT_SECRET = origClientSecret;
await oidcApp.cleanup();
await new Promise<void>((resolve) => mockServer.close(() => resolve()));
}, 10_000);
it("callback without state cookie redirects to login with error", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/auth/oidc/callback?code=abc&state=xyz",
});
// Should redirect to /login?error=oidc_session_expired
expect(res.statusCode).toBe(302);
const location = res.headers.location as string;
expect(location).toContain("/login?error=oidc_session_expired");
});
it("callback with invalid cookie signature redirects to login with error", async () => {
const res = await oidcApp.app.inject({
method: "GET",
url: "/api/auth/oidc/callback?code=abc&state=xyz",
cookies: { "oidc-state": "tampered-garbage-value" },
});
expect(res.statusCode).toBe(302);
const location = res.headers.location as string;
expect(location).toContain("/login?error=oidc_session_expired");
});
it("callback with IdP error redirects to login with oidc_auth_failed", async () => {
// First, do a login to get a valid state cookie
const loginRes = await oidcApp.app.inject({
method: "GET",
url: "/api/auth/oidc/login",
});
expect(loginRes.statusCode).toBe(302);
// Extract the state cookie and state param from redirect
const rawCookies = loginRes.headers["set-cookie"];
const cookieStr = Array.isArray(rawCookies) ? rawCookies[0] : rawCookies || "";
const cookieMatch = cookieStr.match(/oidc-state=([^;]+)/);
expect(cookieMatch).toBeTruthy();
// The cookie value may be URL-encoded; decode for inject()
const cookieValue = decodeURIComponent(cookieMatch![1]);
const redirectUrl = new URL(loginRes.headers.location as string);
const state = redirectUrl.searchParams.get("state");
// Simulate IdP returning an error
const callbackRes = await oidcApp.app.inject({
method: "GET",
url: `/api/auth/oidc/callback?error=access_denied&error_description=User+denied&state=${state}`,
cookies: { "oidc-state": cookieValue },
});
expect(callbackRes.statusCode).toBe(302);
const location = callbackRes.headers.location as string;
expect(location).toContain("/login?error=oidc_auth_failed");
});
});
// =====================================================================
// ADMIN OPERATIONS ON OIDC USERS
// =====================================================================
describe("Admin operations on OIDC users", () => {
it("admin can delete an OIDC user", async () => {
const { userId } = createOidcUser();
const res = await testApp.app.inject({
method: "DELETE",
url: `/api/auth/users/${userId}`,
headers: { authorization: `Bearer ${adminToken}` },
});
expect(res.statusCode).toBe(200);
// Verify user is gone
const user = db.select().from(schema.users).where(eq(schema.users.id, userId)).get();
expect(user).toBeUndefined();
});
it("admin can update role of an OIDC user", async () => {
const { userId } = createOidcUser();
const res = await testApp.app.inject({
method: "PUT",
url: `/api/auth/users/${userId}`,
headers: { authorization: `Bearer ${adminToken}` },
payload: { role: "editor" },
});
expect(res.statusCode).toBe(200);
const user = db.select().from(schema.users).where(eq(schema.users.id, userId)).get();
expect(user?.role).toBe("editor");
});
});
// =====================================================================
// COOKIE-BASED SESSION AUTH
// =====================================================================
describe("Cookie-based session auth", () => {
it("OIDC session cookie works for authenticated requests", async () => {
const { sessionToken, username } = createOidcUser();
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
cookies: { "snapotter-session": sessionToken },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.user.username).toBe(username);
expect(body.user.authProvider).toBe("oidc");
});
it("Both cookie and Bearer work simultaneously", async () => {
const { sessionToken: oidcToken, username: oidcUsername } = createOidcUser();
// Bearer token for local user (admin)
const bearerRes = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
headers: { authorization: `Bearer ${adminToken}` },
});
expect(bearerRes.statusCode).toBe(200);
const bearerBody = JSON.parse(bearerRes.body);
expect(bearerBody.user.username).toBe("admin");
expect(bearerBody.user.authProvider).toBe("local");
// Cookie for OIDC user
const cookieRes = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
cookies: { "snapotter-session": oidcToken },
});
expect(cookieRes.statusCode).toBe(200);
const cookieBody = JSON.parse(cookieRes.body);
expect(cookieBody.user.username).toBe(oidcUsername);
expect(cookieBody.user.authProvider).toBe("oidc");
});
it("request with neither Bearer nor cookie returns 401", async () => {
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
});
expect(res.statusCode).toBe(401);
});
});
// =====================================================================
// SESSION EXPIRY
// =====================================================================
describe("Session expiry", () => {
it("expired OIDC session returns 401", async () => {
const { userId } = createOidcUser();
// Create a session that expired 10 minutes ago
const expiredToken = createOidcSession(userId, {
expiresAt: new Date(Date.now() - 600_000),
});
const res = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
cookies: { "snapotter-session": expiredToken },
});
expect(res.statusCode).toBe(401);
// Verify the expired session was cleaned up from DB
const session = db
.select()
.from(schema.sessions)
.where(eq(schema.sessions.id, expiredToken))
.get();
expect(session).toBeUndefined();
});
});
// =====================================================================
// API KEYS FOR OIDC USERS
// =====================================================================
describe("API keys for OIDC users", () => {
it("OIDC user can create an API key", async () => {
const { sessionToken } = createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: "/api/v1/api-keys",
cookies: { "snapotter-session": sessionToken },
payload: { name: "test-key" },
});
expect(res.statusCode).toBe(201);
const body = JSON.parse(res.body);
expect(body.key).toMatch(/^si_/);
expect(body.name).toBe("test-key");
});
it("API key works for auth after creation", async () => {
const { sessionToken } = createOidcUser();
// Create the API key via cookie auth
const createRes = await testApp.app.inject({
method: "POST",
url: "/api/v1/api-keys",
cookies: { "snapotter-session": sessionToken },
payload: { name: "auth-test-key" },
});
expect(createRes.statusCode).toBe(201);
const { key: rawKey } = JSON.parse(createRes.body);
// Use the raw API key as Bearer token
const sessionRes = await testApp.app.inject({
method: "GET",
url: "/api/auth/session",
headers: { authorization: `Bearer ${rawKey}` },
});
// API key auth on GET /api/auth/session is a public route, but
// the middleware still attaches the user if a valid token is found.
// The session endpoint itself checks for session, not API key,
// so it returns 401 since the si_ token is not a session ID.
// Instead, test with a non-public route that requires auth.
const healthRes = await testApp.app.inject({
method: "GET",
url: "/api/v1/api-keys",
headers: { authorization: `Bearer ${rawKey}` },
});
expect(healthRes.statusCode).toBe(200);
const body = JSON.parse(healthRes.body);
expect(body.apiKeys).toBeDefined();
expect(Array.isArray(body.apiKeys)).toBe(true);
});
});
// =====================================================================
// LOGOUT
// =====================================================================
describe("Logout", () => {
it("logout clears the snapotter-session cookie", async () => {
const { sessionToken } = createOidcUser();
const res = await testApp.app.inject({
method: "POST",
url: "/api/auth/logout",
cookies: { "snapotter-session": sessionToken },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.ok).toBe(true);
// Check that response includes a Set-Cookie header clearing the session
const setCookieHeader = res.headers["set-cookie"];
const cookieStr = Array.isArray(setCookieHeader)
? setCookieHeader.join("; ")
: setCookieHeader || "";
expect(cookieStr).toContain("snapotter-session=");
// The cookie should be expired (Expires in the past or Max-Age=0)
const hasExpiry =
cookieStr.toLowerCase().includes("max-age=0") ||
cookieStr.toLowerCase().includes("expires=thu, 01 jan 1970");
expect(hasExpiry).toBe(true);
});
it("session is deleted from DB after logout", async () => {
const { sessionToken } = createOidcUser();
// Verify session exists before logout
const before = db
.select()
.from(schema.sessions)
.where(eq(schema.sessions.id, sessionToken))
.get();
expect(before).toBeDefined();
await testApp.app.inject({
method: "POST",
url: "/api/auth/logout",
cookies: { "snapotter-session": sessionToken },
});
// Verify session is gone
const after = db
.select()
.from(schema.sessions)
.where(eq(schema.sessions.id, sessionToken))
.get();
expect(after).toBeUndefined();
});
it("logout returns logoutUrl when session has idToken and OIDC discovery is cached", async () => {
const { sessionToken } = createOidcUser();
// The default createOidcUser sets idToken to "mock-id-token-jwt".
// Without a running OIDC provider and cached discovery, the logout
// route's try/catch will swallow the error and return no logoutUrl.
// We still verify the response shape is correct.
const res = await testApp.app.inject({
method: "POST",
url: "/api/auth/logout",
cookies: { "snapotter-session": sessionToken },
});
expect(res.statusCode).toBe(200);
const body = JSON.parse(res.body);
expect(body.ok).toBe(true);
// logoutUrl is only present when OIDC discovery has been cached with
// an end_session_endpoint. In test env without mock provider, it is
// absent. We verify it's either undefined or a string URL.
if (body.logoutUrl !== undefined) {
expect(typeof body.logoutUrl).toBe("string");
expect(body.logoutUrl).toContain("id_token_hint=");
}
});
});
+25 -6
View File
@@ -19,6 +19,7 @@ import { dirname } from "node:path";
mkdirSync(dirname(process.env.DB_PATH!), { recursive: true });
mkdirSync(process.env.WORKSPACE_PATH!, { recursive: true });
import cookie from "@fastify/cookie";
import cors from "@fastify/cors";
import { APP_VERSION } from "@snapotter/shared";
import { eq } from "drizzle-orm";
@@ -31,6 +32,7 @@ import { db, schema } from "../../apps/api/src/db/index.js";
import { runMigrations } from "../../apps/api/src/db/migrate.js";
import { requirePermission } from "../../apps/api/src/permissions.js";
import { authMiddleware, authRoutes, ensureDefaultAdmin } from "../../apps/api/src/plugins/auth.js";
import { oidcRoutes } from "../../apps/api/src/plugins/oidc.js";
import { registerUpload } from "../../apps/api/src/plugins/upload.js";
import { analyticsRoutes } from "../../apps/api/src/routes/analytics.js";
import { apiKeyRoutes } from "../../apps/api/src/routes/api-keys.js";
@@ -80,12 +82,18 @@ export async function buildTestApp(): Promise<TestApp> {
// Multipart upload support
await registerUpload(app);
// Cookie support
await app.register(cookie, { secret: "test-cookie-secret", hook: "onRequest" });
// Auth middleware (must be registered before routes)
await authMiddleware(app);
// Auth routes
await authRoutes(app);
// OIDC routes
await oidcRoutes(app);
// File upload/download routes
await fileRoutes(app);
@@ -161,18 +169,29 @@ export async function buildTestApp(): Promise<TestApp> {
});
// Public config endpoint
app.get("/api/v1/config/auth", async () => ({
authEnabled: env.AUTH_ENABLED,
}));
app.get("/api/v1/config/auth", async () => {
const config: Record<string, unknown> = { authEnabled: env.AUTH_ENABLED };
if (env.OIDC_ENABLED) {
config.oidcEnabled = true;
config.oidcProviderName = env.OIDC_PROVIDER_NAME || null;
config.oidcLoginUrl = "/api/auth/oidc/login";
}
return config;
});
// Ensure Fastify is ready (all plugins loaded)
await app.ready();
const cleanup = async () => {
await app.close();
// Don't delete the temp DB directory here — other test files in the same
// vitest run share it. The directory lives under /tmp with a random UUID
// and is cleaned up by the OS.
// Checkpoint WAL to prevent unbounded growth across sequential test files.
// Without this, the WAL/SHM files grow until SQLite hits SQLITE_IOERR_SHMSIZE.
try {
const { sqlite } = await import("../../apps/api/src/db/index.js");
sqlite.pragma("wal_checkpoint(TRUNCATE)");
} catch {
// best-effort
}
};
return { app, cleanup };
+9 -5
View File
@@ -210,8 +210,8 @@ describe("watermark-image", () => {
// ── Branch coverage: lines 164-168 (processing failure) ───────────
it("returns 422 when processing fails on corrupted main image", async () => {
// A buffer that passes multipart parsing but fails Sharp processing
it("returns 400 when main image is corrupted", async () => {
// A buffer that passes multipart parsing but fails image validation
const corruptedBuffer = Buffer.alloc(100, 0xff);
const { body, contentType } = createMultipartPayload([
{ name: "file", filename: "main.png", contentType: "image/png", content: corruptedBuffer },
@@ -226,7 +226,9 @@ describe("watermark-image", () => {
body,
});
expect([400, 422]).toContain(res.statusCode);
expect(res.statusCode).toBe(400);
const json = JSON.parse(res.body);
expect(json.error).toContain("Invalid image");
});
// ── HEIC input handling ───────────────────────────────────────────
@@ -336,7 +338,7 @@ describe("watermark-image", () => {
// ── Corrupted watermark image (processing failure) ───────────────
it("returns 422 when watermark image is corrupted", async () => {
it("returns 400 when watermark image is corrupted", async () => {
const corruptedWm = Buffer.alloc(50, 0xaa);
const { body, contentType } = createMultipartPayload([
{ name: "file", filename: "main.png", contentType: "image/png", content: PNG },
@@ -351,7 +353,9 @@ describe("watermark-image", () => {
body,
});
expect([400, 422]).toContain(res.statusCode);
expect(res.statusCode).toBe(400);
const json = JSON.parse(res.body);
expect(json.error).toContain("Invalid watermark image");
});
// ── Tiny 1x1 main image ──────────────────────────────────────────
@@ -138,6 +138,9 @@ vi.mock("@/components/tools/meme-generator-preview", () => ({
vi.mock("@/components/tools/color-blindness-settings", () => ({
ColorBlindnessSettings: () => null,
}));
vi.mock("@/components/tools/ai-canvas-expand-settings", () => ({
AiCanvasExpandSettings: () => null,
}));
import { TOOLS } from "@snapotter/shared";
import type { DisplayMode, ToolRegistryEntry } from "@/lib/tool-registry";
+3
View File
@@ -181,6 +181,9 @@ vi.mock("@/components/tools/meme-generator-preview", () => ({
vi.mock("@/components/tools/color-blindness-settings", () => ({
ColorBlindnessSettings: () => null,
}));
vi.mock("@/components/tools/ai-canvas-expand-settings", () => ({
AiCanvasExpandSettings: () => null,
}));
// ---------------------------------------------------------------------------
// Import after mocks