External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: repair docker validation QA tooling, dispatcher crash-accounting, and image-enhancement RAW hang (#391)

Browse Source 
Found and fixed during a full local Docker build validation (amd64/arm64, all
four fleet targets, AI bundle installs, QA harness) and the follow-up bug
sweep requested afterward. None of the affected scripts run in CI, so these
had been silently broken indefinitely.

- docker/feature-manifest.json: pythonVersion was a flat "3.11", but the
  amd64 base (Ubuntu 24.04) ships Python 3.12 while arm64 (Debian bookworm)
  ships 3.11. Changed to a per-arch object matching the file's existing
  convention.
- tests/qa/api-sweep.mts and verify-ai.mts: bare "@snapotter/shared" import
  can't resolve since tests/ is not a pnpm workspace member, making both
  silently unrunnable via their own documented command on any fresh
  checkout. Switched to a relative import.
- tests/qa/generate-ledger.mts: wrote to docs/qa/ without creating the
  directory first; docs/ is gitignored except COMMUNITY_GUIDE.md, so a fresh
  checkout threw ENOENT.
- Seven QA Playwright spec files (input-preview, settings,
  settings-extended, multifile, output-preview, pipeline-ui, smoke) had
  ~115 fixture() calls using directory names that don't exist. Resolved
  every call programmatically against the real fixture tree.
- packages/ai/src/bridge.ts: AI dispatcher restart (happens on every bundle
  install) was falsely counted as a crash, risking permanent dispatcher
  disable after enough legitimate restarts within the crash window. Added a
  shuttingDown flag checked at all three recordCrash() call sites.
- packages/image-engine/src/operations/auto-enhance.ts: image-enhancement
  hung 40+ seconds on large RAW photos (confirmed on a real 20.2MP file) in
  Sharp's .clahe() step, whose cost scales with total pixel count regardless
  of tile size. Added a 16-megapixel cap above which CLAHE is skipped;
  verified against the real file (40+s -> 2.0s) with no regression to other
  RAW formats or normal-sized images. Fixing this surfaced a second,
  smaller bug where the saturation step's CLAHE compensation boost was
  keyed off the raw toggle instead of whether CLAHE actually ran.
- Two QA-harness robustness gaps closed per "fix everything, even the small
  bugs": the passport-photo/erase-object input-preview tests now skip
  cleanly with a clear reason on a container without their AI bundle
  installed, and docker-compose.qa.yml's hardcoded project/container name
  (the actual root cause of a mid-validation container swap between two
  concurrent sessions) is now parameterized via QA_PROJECT_NAME.

Full validation report is local-only per repo convention.
This commit is contained in:
SnapOtter
2026-07-02 14:21:13 +08:00
committed by GitHub
parent 7e01d3637e
commit bd1838e40b
17 changed files with 1110 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/qa/multifile.qa.spec.ts
+73 -45
View File
@@ -177,8 +177,8 @@ test.describe("A) Multi-input tools", () => {
const issues = instrument(page);
await gotoTool(page, "merge-pdf");
await uploadFiles(page, [
fixture("documents", "tiny.pdf"),
fixture("content", "alt-2page.pdf"),
fixture("document", "formats", "tiny.pdf"),
fixture("document", "valid", "alt-2page.pdf"),
]);
await page.waitForTimeout(1_000);
const res = await processTool(page, "merge-pdf", "fast");
@@ -202,7 +202,10 @@ test.describe("A) Multi-input tools", () => {
// endpoint.
const issues = instrument(page);
await gotoTool(page, "merge-audio");
await uploadFiles(page, [fixture("media", "tiny.mp3"), fixture("media", "tiny.wav")]);
await uploadFiles(page, [
fixture("audio", "formats", "tiny.mp3"),
fixture("audio", "formats", "tiny.wav"),
]);
await page.waitForTimeout(1_000);
// Click submit and watch what happens
@@ -255,7 +258,10 @@ test.describe("A) Multi-input tools", () => {
test("merge-videos: mp4 + mov -> duration ~= sum", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "merge-videos");
await uploadFiles(page, [fixture("media", "tiny.mp4"), fixture("media", "tiny.mov")]);
await uploadFiles(page, [
fixture("video", "formats", "tiny.mp4"),
fixture("video", "formats", "tiny.mov"),
]);
await page.waitForTimeout(1_000);
// merge-videos has executionHint "long" => SSE/async
@@ -278,7 +284,10 @@ test.describe("A) Multi-input tools", () => {
// files are present.
const issues = instrument(page);
await gotoTool(page, "merge-csvs");
await uploadFiles(page, [fixture("data", "tiny-a.csv"), fixture("data", "tiny-b.csv")]);
await uploadFiles(page, [
fixture("data", "valid", "tiny-a.csv"),
fixture("data", "valid", "tiny-b.csv"),
]);
await page.waitForTimeout(1_000);
await clickSubmit(page, "merge-csvs");
@@ -329,7 +338,10 @@ test.describe("A) Multi-input tools", () => {
test("stitch: 2 images -> stitched output with combined dimensions", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "stitch");
await uploadFiles(page, [fixture("formats", "sample.png"), fixture("formats", "sample.jpg")]);
await uploadFiles(page, [
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
]);
await page.waitForTimeout(1_000);
await clickSubmit(page, "stitch");
@@ -340,8 +352,8 @@ test.describe("A) Multi-input tools", () => {
expect(dl.size).toBeGreaterThan(0);
const info = imageInfo(dl.path);
const src1 = imageInfo(fixture("formats", "sample.png"));
const src2 = imageInfo(fixture("formats", "sample.jpg"));
const src1 = imageInfo(fixture("image", "formats", "sample.png"));
const src2 = imageInfo(fixture("image", "formats", "sample.jpg"));
// Default direction is horizontal => width should be roughly sum of inputs
expect(
info.width,
@@ -355,7 +367,10 @@ test.describe("A) Multi-input tools", () => {
const issues = instrument(page);
await gotoTool(page, "collage");
await uploadFiles(page, [fixture("formats", "sample.png"), fixture("formats", "sample.jpg")]);
await uploadFiles(page, [
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
]);
await page.waitForTimeout(1_500);
await clickSubmit(page, "collage");
@@ -373,10 +388,14 @@ test.describe("A) Multi-input tools", () => {
test("compose: base + overlay -> composited image", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "compose");
await uploadFiles(page, fixture("formats", "sample.png"));
await uploadFiles(page, fixture("image", "formats", "sample.png"));
await page.waitForTimeout(500);
await setSecondaryInput(page, "#compose-overlay-image", fixture("formats", "sample.jpg"));
await setSecondaryInput(
page,
"#compose-overlay-image",
fixture("image", "formats", "sample.jpg"),
);
await page.waitForTimeout(500);
await clickSubmit(page, "compose");
@@ -394,13 +413,13 @@ test.describe("A) Multi-input tools", () => {
test("compare: two distinct images -> similarity score + diff image", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "compare");
await uploadFiles(page, fixture("formats", "sample.png"));
await uploadFiles(page, fixture("image", "formats", "sample.png"));
await page.waitForTimeout(500);
await setSecondaryInput(
page,
"#compare-second-image",
fixture("content", "portrait-color.jpg"),
fixture("image", "valid", "portrait-color.jpg"),
);
await page.waitForTimeout(500);
@@ -423,9 +442,9 @@ test.describe("A) Multi-input tools", () => {
const issues = instrument(page);
await gotoTool(page, "find-duplicates");
await uploadFiles(page, [
fixture("content", "portrait-color.jpg"),
fixture("content", "portrait-color-dup.jpg"),
fixture("formats", "sample.png"),
fixture("image", "valid", "portrait-color.jpg"),
fixture("image", "valid", "portrait-color-dup.jpg"),
fixture("image", "formats", "sample.png"),
]);
await page.waitForTimeout(1_500);
@@ -451,9 +470,9 @@ test.describe("A) Multi-input tools", () => {
const issues = instrument(page);
await gotoTool(page, "images-to-video");
await uploadFiles(page, [
fixture("formats", "sample.png"),
fixture("formats", "sample.jpg"),
fixture("formats", "sample.webp"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
fixture("image", "formats", "sample.webp"),
]);
await page.waitForTimeout(1_000);
@@ -487,9 +506,9 @@ test.describe("A) Multi-input tools", () => {
await gotoTool(page, "create-zip");
// Use a mix of file types since create-zip should accept all types
const inputFiles = [
fixture("documents", "tiny.pdf"),
fixture("data", "tiny-a.csv"),
fixture("documents", "tiny.txt"),
fixture("document", "formats", "tiny.pdf"),
fixture("data", "valid", "tiny-a.csv"),
fixture("document", "formats", "tiny.txt"),
];
await uploadFiles(page, inputFiles);
await page.waitForTimeout(2_000);
@@ -561,7 +580,10 @@ test.describe("A) Multi-input tools", () => {
test("replace-audio: video + audio -> output video has audio track", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "replace-audio");
await uploadFiles(page, [fixture("media", "tiny.mp4"), fixture("media", "tiny.mp3")]);
await uploadFiles(page, [
fixture("video", "formats", "tiny.mp4"),
fixture("audio", "formats", "tiny.mp3"),
]);
await page.waitForTimeout(1_000);
const res = await processTool(page, "replace-audio", "fast");
@@ -581,7 +603,10 @@ test.describe("A) Multi-input tools", () => {
test("burn-subtitles: video + srt -> output produced", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "burn-subtitles");
await uploadFiles(page, [fixture("media", "tiny.mp4"), fixture("media", "tiny.srt")]);
await uploadFiles(page, [
fixture("video", "formats", "tiny.mp4"),
fixture("video", "formats", "tiny.srt"),
]);
await page.waitForTimeout(1_000);
const res = await processTool(page, "burn-subtitles", "long");
@@ -599,7 +624,10 @@ test.describe("A) Multi-input tools", () => {
test("embed-subtitles: video + srt -> output has subtitle stream", async ({ page }) => {
const issues = instrument(page);
await gotoTool(page, "embed-subtitles");
await uploadFiles(page, [fixture("media", "tiny.mp4"), fixture("media", "tiny.srt")]);
await uploadFiles(page, [
fixture("video", "formats", "tiny.mp4"),
fixture("video", "formats", "tiny.srt"),
]);
await page.waitForTimeout(1_000);
const res = await processTool(page, "embed-subtitles", "fast");
@@ -626,11 +654,11 @@ test.describe("B) Batch processing", () => {
const issues = instrument(page);
await gotoTool(page, "resize");
const batchFiles = [
fixture("formats", "sample.png"),
fixture("formats", "sample.jpg"),
fixture("formats", "sample.webp"),
fixture("formats", "sample.bmp"),
fixture("formats", "sample.gif"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
fixture("image", "formats", "sample.webp"),
fixture("image", "formats", "sample.bmp"),
fixture("image", "formats", "sample.gif"),
];
await uploadFiles(page, batchFiles);
await page.waitForTimeout(1_500);
@@ -657,11 +685,11 @@ test.describe("B) Batch processing", () => {
const issues = instrument(page);
await gotoTool(page, "convert");
const batchFiles = [
fixture("formats", "sample.png"),
fixture("formats", "sample.jpg"),
fixture("formats", "sample.bmp"),
fixture("formats", "sample.gif"),
fixture("formats", "sample.tiff"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
fixture("image", "formats", "sample.bmp"),
fixture("image", "formats", "sample.gif"),
fixture("image", "formats", "sample.tiff"),
];
await uploadFiles(page, batchFiles);
await page.waitForTimeout(1_500);
@@ -685,11 +713,11 @@ test.describe("B) Batch processing", () => {
const issues = instrument(page);
await gotoTool(page, "compress");
const batchFiles = [
fixture("formats", "sample.png"),
fixture("formats", "sample.jpg"),
fixture("formats", "sample.webp"),
fixture("formats", "sample.gif"),
fixture("formats", "sample.tiff"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
fixture("image", "formats", "sample.webp"),
fixture("image", "formats", "sample.gif"),
fixture("image", "formats", "sample.tiff"),
];
await uploadFiles(page, batchFiles);
await page.waitForTimeout(1_500);
@@ -727,7 +755,7 @@ test.describe("C) Edge cases", () => {
// Upload 11 copies of the same video to exceed the 10-file limit.
const manyFiles: string[] = [];
for (let i = 0; i < 11; i++) {
manyFiles.push(fixture("media", "tiny.mp4"));
manyFiles.push(fixture("video", "formats", "tiny.mp4"));
}
await uploadFiles(page, manyFiles);
await page.waitForTimeout(2_000);
@@ -790,7 +818,7 @@ test.describe("C) Edge cases", () => {
await gotoTool(page, "collage");
// Upload a text file into collage (expects images)
await uploadFiles(page, fixture("documents", "tiny.txt"));
await uploadFiles(page, fixture("document", "formats", "tiny.txt"));
await page.waitForTimeout(1_500);
// Try to submit -- the button may be disabled (no valid images) or server rejects
@@ -825,9 +853,9 @@ test.describe("C) Edge cases", () => {
// Upload the same file twice (same filename) plus a different one.
const dupeFiles = [
fixture("formats", "sample.png"),
fixture("formats", "sample.png"),
fixture("formats", "sample.jpg"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.png"),
fixture("image", "formats", "sample.jpg"),
];
await uploadFiles(page, dupeFiles);
await page.waitForTimeout(1_500);