External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(telemetry): sharpen Sentry signal for v2.1.0 residual defects (#498)

Browse Source 
Follow-ups to the v2.1.0 Sentry telemetry overhaul, found by reviewing live release:2.1.0 events:

- error_code tag was empty because reportError read only the top-level err.code; add extractErrorCode() to walk the cause chain (pg SQLSTATE, node E-code, else first short code).
- InputValidationError from a tool's processV2 in the worker was logged as error_class=bug; classify it as expected for any source. Worker-side ZodError stays a bug (schema drift).
- AI dispatcher timeouts rejected with a bare Error, which the sanitizer scrubbed to a message-less "Error: Error"; reject with an operational SafeError (code "timeout") at both timeout sites.

Each fix written failing-test-first; affected and adjacent unit suites green plus full CI (integration + e2e).
This commit is contained in:
SnapOtter
2026-07-11 16:18:26 +08:00
committed by GitHub
parent b8c3700c15
commit b457596649
7 changed files with 165 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/lib/error-report.ts
+9 -4
View File
@@ -13,6 +13,7 @@
*/
import {
connectivityClass,
extractErrorCode,
isClientAbort,
isSafeMessageError,
isToolInputError,
@@ -38,6 +39,10 @@ export interface ReportContext {
export function classifyError(err: unknown, source?: ReportContext["source"]): ErrorClass {
if (isToolInputError(err)) return "expected";
const e = err as { name?: string; message?: string; code?: string } | null;
// InputValidationError (apps/api/src/modality/contract.ts) is a 400 the user
// caused with a bad file/args. Tools throw it from processV2 inside the worker
// (e.g. sprite-sheet), so it is expected wherever it surfaces, not only http.
if (e?.name === "InputValidationError") return "expected";
if (e && typeof e.message === "string" && /^(Canceled$|Timed out after )/.test(e.message)) {
return "expected";
}
@@ -48,9 +53,9 @@ export function classifyError(err: unknown, source?: ReportContext["source"]): E
// worker-side parse failure is our bug.
if (source === "http" || source === undefined) {
if (isClientAbort(err)) return "expected";
// ZodError = settings validation; InputValidationError = upload validation
// (apps/api/src/modality/contract.ts). Both are user-input problems.
if (e?.name === "ZodError" || e?.name === "InputValidationError") return "expected";
// ZodError = settings validation. Settings are validated at the boundary, so
// a worker-side ZodError is schema drift (our bug); only expected on http.
if (e?.name === "ZodError") return "expected";
}
if (isSafeMessageError(err)) return err.kind === "bug" ? "bug" : "operational";
if (connectivityClass(err)) return "operational";
@@ -106,7 +111,7 @@ export async function reportError(err: unknown, ctx: ReportContext): Promise<voi
scope.setLevel(cls === "operational" ? "warning" : "error");
scope.setTag("source", ctx.source);
scope.setTag("error_class", cls);
const code = (err as { code?: string } | null)?.code;
const code = extractErrorCode(err);
if (code) scope.setTag("error_code", code);
if (ctx.toolId) scope.setTag("tool_id", ctx.toolId);
if (ctx.pool) scope.setTag("pool", ctx.pool);